From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] ZOOM1 Add power reset button
Date: Fri, 12 Jun 2009 23:46:30 +0200 [thread overview]
Message-ID: <20090612214630.GE1802@game.jcrosoft.org> (raw)
In-Reply-To: <1244638432-30893-5-git-send-email-Tom.Rix@windriver.com>
On 07:53 Wed 10 Jun , Tom Rix wrote:
> The reset button is the red circle on the top right, front of
> the board. Press and hold the button for 8 seconds to completely
> reset the board.
>
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
> board/omap3/zoom1/zoom1.c | 8 ++++++++
> drivers/i2c/twl4030_i2c.c | 2 +-
> include/configs/omap3_zoom1.h | 1 +
> 3 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/board/omap3/zoom1/zoom1.c b/board/omap3/zoom1/zoom1.c
> index db4d087..8a3afaf 100644
> --- a/board/omap3/zoom1/zoom1.c
> +++ b/board/omap3/zoom1/zoom1.c
> @@ -31,6 +31,7 @@
> * MA 02111-1307 USA
> */
> #include <common.h>
> +#include <twl4030.h>
> #include <asm/io.h>
> #include <asm/arch/mux.h>
> #include <asm/arch/sys_proto.h>
> @@ -51,6 +52,13 @@ int board_init(void)
> /* boot param addr */
> gd->bd->bi_boot_params = (OMAP34XX_SDRC_CS0 + 0x100);
>
> + /*
> + * Board Reset
> + * The board is reset by holding the red button on the
> + * top right front face for eight seconds.
> + */
> + twl4030_power_reset_init();
> +
> return 0;
> }
>
> diff --git a/drivers/i2c/twl4030_i2c.c b/drivers/i2c/twl4030_i2c.c
> index 549f974..00146f8 100644
> --- a/drivers/i2c/twl4030_i2c.c
> +++ b/drivers/i2c/twl4030_i2c.c
> @@ -40,7 +40,7 @@ static inline int twl4030_i2c_read_u8(u8 chip_no, u8 *val, u8 reg)
> */
> void twl4030_power_reset_init(void)
> {
> -#ifdef CONFIG_OMAP3_ZOOM2
> +#if defined(CONFIG_OMAP3_ZOOM2) || defined(CONFIG_OMAP3_ZOOM1)
I think it will be better to avoid board specifc code in the driver
unless it's the only solution
Best Regards,
J.
next prev parent reply other threads:[~2009-06-12 21:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 12:53 [U-Boot] Zoom hw reset Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 1/4] OMAP3 I2C Fix the sampling clock Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 2/4] I2C Add initial support for TWL4030 Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 4/4] ZOOM1 " Tom Rix
2009-06-12 21:46 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-12 21:57 ` Tom
2009-06-12 23:08 ` Menon, Nishanth
2009-06-13 2:28 ` Tom
2009-06-13 14:16 ` Tom
2009-06-13 14:26 ` Nishanth Menon
2009-06-10 14:27 ` [U-Boot] [PATCH 3/4] ZOOM2 " Peter Tyser
2009-06-10 14:43 ` Menon, Nishanth
2009-06-10 15:43 ` Dirk Behme
2009-06-10 16:16 ` Menon, Nishanth
2009-06-10 16:25 ` Peter Tyser
2009-06-10 18:08 ` Heiko Schocher
2009-06-10 18:27 ` Menon, Nishanth
2009-06-10 18:21 ` Heiko Schocher
2009-06-10 18:50 ` Menon, Nishanth
2009-06-10 20:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 13:02 ` Tom
2009-06-13 14:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-10 18:06 ` Heiko Schocher
2009-06-10 18:04 ` Heiko Schocher
2009-06-10 17:56 ` Heiko Schocher
2009-06-10 17:48 ` Heiko Schocher
2009-06-10 14:46 ` [U-Boot] [PATCH 2/4] I2C Add initial support for TWL4030 Menon, Nishanth
2009-06-10 17:59 ` Heiko Schocher
2009-06-10 17:45 ` Heiko Schocher
2009-07-19 9:19 ` Wolfgang Denk
2009-07-19 15:23 ` Heiko Schocher
2009-07-19 17:06 ` Tom
2009-07-20 9:12 ` Heiko Schocher
2009-07-22 21:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-20 15:38 ` Dirk Behme
2009-06-10 14:52 ` [U-Boot] [PATCH 1/4] OMAP3 I2C Fix the sampling clock Menon, Nishanth
2009-06-11 2:43 ` Tom
2009-06-11 4:12 ` Menon, Nishanth
2009-06-11 14:02 ` Tom
2009-06-12 21:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 22:06 ` Tom
2009-06-17 22:31 ` [U-Boot] RFC " Tom
2009-06-12 21:41 ` [U-Boot] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612214630.GE1802@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox