From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Sat, 20 Jun 2009 15:01:36 +0200 Subject: [U-Boot] [PATCH 1/2 V2] Move libgcc inclusion from common Makefile to platform configs files In-Reply-To: <200906200857.42360.vapier@gentoo.org> References: <1245490407-22770-1-git-send-email-plagnioj@jcrosoft.com> <200906200708.31469.vapier@gentoo.org> <20090620113041.GE6870@game.jcrosoft.org> <200906200857.42360.vapier@gentoo.org> Message-ID: <20090620130136.GF3849@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08:57 Sat 20 Jun , Mike Frysinger wrote: > On Saturday 20 June 2009 07:30:41 Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 07:08 Sat 20 Jun , Mike Frysinger wrote: > > > On Saturday 20 June 2009 06:40:07 Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > On 06:18 Sat 20 Jun , Mike Frysinger wrote: > > > > > On Saturday 20 June 2009 05:33:26 Jean-Christophe wrote: > > > > > > This patch moves the libgcc Makefile inclusion from the toplevel > > > > > > Makefile to the arch_config.mk files. This is in preparation for > > > > > > the ARM architecture to move away from including libgcc function > > > > > > and only using self-contained U-Boot functions as done in Linux. > > > > > > > > > > why not change the top level Makefile to read: > > > > > PLATFORM_LIBGCC ?= ... > > > > > > > > > > then any board/arch that doesnt want it can simply do: > > > > > PLATFORM_LIBGCC = # dont want it > > > > > > > > because you need to provide the equivalent functions for standalone > > > > application and api and U-Boot ofcourse > > > > > > so move it to config.mk. this doesnt change the important point: leave > > > PLATFORM_LIBGCC default in the toplevel common files. what i proposed > > > doesnt limit what you want to do with arm in any way. > > > > I think it's better to let it at arch level and force any new arch adding > > to manage it instead provide a default one > > considering most arches want this code, i dont think so. you're proposing we > duplicate the same common code in all arches to support one deviating arch -- > arm. the defaults should reflect the common state while the deviating ones > change the behavior as they like. This is where I disagree other arch as mips and other will also need to move away from the needs to include libgcc to be really toolchain independant I do think it's really important for U-Boot be able to have full control to have a functions embedded into. So stop to have libgcc include by default will really reflect it Best Regards, J.