public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix
Date: Tue, 23 Jun 2009 10:40:30 +0200	[thread overview]
Message-ID: <20090623084030.GD23512@game.jcrosoft.org> (raw)
In-Reply-To: <20090623092138.25372642@hskinnemoen-d830>

On 09:21 Tue 23 Jun     , Haavard Skinnemoen wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 08:53 Tue 23 Jun     , Haavard Skinnemoen wrote:
> > > Jean-Christophe PLAGNIOL-VILLARD wrote:  
> > > > for at91 the GUARD_TIME is 1 and IIRC it's lcd specific  
> > > 
> > > You just contradicted yourself.  
> > at91 boards
> 
> Ok, I see.
> 
> > > 
> > > The Guard time is the number of empty frames (with control signals
> > > enabled but no data) to wait before starting to send valid data to the
> > > display.
> > > 
> > > Setting it slightly too high shouldn't make any difference. However,
> > > setting it slightly too low may cause strange failures every now and
> > > then.  
> > for at91 boards it's 1 and I've never seen any problem, same in the kernel
> > 
> > So I'll prefer to make it optionial and no hardcoded for all boards.
> 
> Good point. How about if we turn it into a configuration symbol and
> default to 1 if it's unset?
fine for me

Best Regards,
J.

      reply	other threads:[~2009-06-23  8:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 14:58 [U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix Mark Jackson
2009-06-22 15:01 ` Mark Jackson
2009-06-22 15:21   ` Haavard Skinnemoen
2009-06-22 15:31     ` Mark Jackson
2009-06-22 15:36       ` Peter Tyser
2009-06-22 17:29       ` Haavard Skinnemoen
2009-06-22 21:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23  6:53   ` Haavard Skinnemoen
2009-06-23  7:07     ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23  7:21       ` Haavard Skinnemoen
2009-06-23  8:40         ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090623084030.GD23512@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox