From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Tue, 23 Jun 2009 10:40:30 +0200 Subject: [U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix In-Reply-To: <20090623092138.25372642@hskinnemoen-d830> References: <4A3F9C33.10800@mimc.co.uk> <20090622213911.GC4463@game.jcrosoft.org> <20090623085358.0b3cd2c5@hskinnemoen-d830> <20090623070703.GB23512@game.jcrosoft.org> <20090623092138.25372642@hskinnemoen-d830> Message-ID: <20090623084030.GD23512@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09:21 Tue 23 Jun , Haavard Skinnemoen wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 08:53 Tue 23 Jun , Haavard Skinnemoen wrote: > > > Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > for at91 the GUARD_TIME is 1 and IIRC it's lcd specific > > > > > > You just contradicted yourself. > > at91 boards > > Ok, I see. > > > > > > > The Guard time is the number of empty frames (with control signals > > > enabled but no data) to wait before starting to send valid data to the > > > display. > > > > > > Setting it slightly too high shouldn't make any difference. However, > > > setting it slightly too low may cause strange failures every now and > > > then. > > for at91 boards it's 1 and I've never seen any problem, same in the kernel > > > > So I'll prefer to make it optionial and no hardcoded for all boards. > > Good point. How about if we turn it into a configuration symbol and > default to 1 if it's unset? fine for me Best Regards, J.