[U-Boot] PATCH: Fixed PPC4xx debug compilation error in uic.c

[U-Boot] PATCH: Fixed PPC4xx debug compilation error in uic.c

[Alessio Centazzo]

This patch fixes a debug compilation error for PPC4xx platforms, all other architectures are not affected by this change.  The 'handler' pointer was undefined.  The fix is exercised and has effect only if DEBUG is defined.

Signed-off-by: Alessio Centazzo acpatin {AT} yahoo {DOT} com

diff u-boot-2009.06/cpu/ppc4xx/uic.c.orig u-boot-2009.06/cpu/ppc4xx/uic.c
--- u-boot-2009.06/cpu/ppc4xx/uic.c.orig    2009-06-14 12:30:39.000000000 -0700
+++ u-boot-2009.06/cpu/ppc4xx/uic.c    2009-06-16 23:04:14.000000000 -0700
@@ -164,7 +164,7 @@
     else if (vec >= 96)
         mtdcr(uic3er, mfdcr(uic3er) | UIC_MASK(vec));
 
-    debug("Install interrupt for vector %d ==> %p\n", vec, handler);
+    debug("Enable interrupt for vector %d\n", vec);
 }
 
 void pic_irq_disable(unsigned int vec)



      

[U-Boot] PATCH: Fixed PPC4xx debug compilation error in uic.c

[Stefan Roese]

Hi Alessio,

a few general comments to your patch:

Please add "ppc4xx:" at the start of the commit subject and change "PATCH" to 
"[PATCH]". The line should look like this:

"[PATCH] ppc4xx: Fixed PPC4xx debug compilation error in uic.c"

I really suggest that you use the git tools to create and send such patches 
(git format-patch and git send-email). This really simplifies things.

This patch doesn't apply:

[stefan at stefan-desktop u-boot-ppc4xx (master)]$ git am patches_misc/PATCH\:\ 
Fixed\ PPC4xx\ debug\ compilation\ error\ in\ uic.mbox
Applying: PATCH: Fixed PPC4xx debug compilation error in uic.c
error: patch failed: cpu/ppc4xx/uic.c:164
error: cpu/ppc4xx/uic.c: patch does not apply
Patch failed at 0001 PATCH: Fixed PPC4xx debug compilation error in uic.c

More comments below:

So please fix the problems mentioned above and resubmit. Thanks.

On Wednesday 17 June 2009 08:40:54 Alessio Centazzo wrote:
> This patch fixes a debug compilation error for PPC4xx platforms, all other
> architectures are not affected by this change.  The 'handler' pointer was
> undefined.  The fix is exercised and has effect only if DEBUG is defined.

Too long line. Please use something like 70 chars max. for commit text.

> Signed-off-by: Alessio Centazzo acpatin {AT} yahoo {DOT} com

Use real email address here.

> diff u-boot-2009.06/cpu/ppc4xx/uic.c.orig u-boot-2009.06/cpu/ppc4xx/uic.c
> --- u-boot-2009.06/cpu/ppc4xx/uic.c.orig    2009-06-14 12:30:39.000000000
> -0700 +++ u-boot-2009.06/cpu/ppc4xx/uic.c    2009-06-16 23:04:14.000000000
> -0700 @@ -164,7 +164,7 @@
>      else if (vec >= 96)
>          mtdcr(uic3er, mfdcr(uic3er) | UIC_MASK(vec));
>
> -    debug("Install interrupt for vector %d ==> %p\n", vec, handler);
> +    debug("Enable interrupt for vector %d\n", vec);
>  }
>
>  void pic_irq_disable(unsigned int vec)

So please fix the problems mentioned above and resubmit. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================