From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] A320: driver for FTRTC010 real time clock
Date: Wed, 24 Jun 2009 01:47:06 +0200 [thread overview]
Message-ID: <20090623234706.GA6875@game.jcrosoft.org> (raw)
In-Reply-To: <ec1aee9f0906230635o7e706fecs507d18c8feae49a3@mail.gmail.com>
> +
> +static volatile struct ftrtc010 *rtc = (struct ftrtc010 *)CONFIG_SYS_RTC_BASE;
> +
> +static void ftrtc_enable (void)
you use it at one please only the reset
> +{
> + rtc->cr = cpu_to_le32 (FTRTC010_CR_ENABLE);
so please move this code there
> +}
> +
> +/*
> + * return current time in seconds
> + */
> +static unsigned long ftrtc_time (void)
> +{
> + unsigned long day;
> + unsigned long hour;
> + unsigned long minute;
> + unsigned long second;
> + unsigned long second2;
> +
> + do {
> + second = le32_to_cpu (rtc->sec);
please use proper accessor
readl/writel
Best Regards,
J.
next prev parent reply other threads:[~2009-06-23 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 13:35 [U-Boot] [PATCH 2/3] A320: driver for FTRTC010 real time clock Po-Yu Chuang
2009-06-23 23:47 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-24 5:05 ` Po-Yu Chuang
2009-06-24 8:47 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623234706.GA6875@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox