public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Fixed PPC4xx debug compilation error in uic.c
Date: Fri, 26 Jun 2009 10:41:17 +0200	[thread overview]
Message-ID: <200906261041.18176.sr@denx.de> (raw)
In-Reply-To: <157572.11230.qm@web51906.mail.re2.yahoo.com>

On Wednesday 24 June 2009 04:31:01 Alessio Centazzo wrote:
> This patch fixes a debug compilation error for PPC4xx platforms, all
> other architectures are not affected by this change.  The 'handler'
> pointer was undefined.  The fix is exercised and has effect only if
> DEBUG is defined.
>
> Signed-off-by: Alessio Centazzo acpatin at yahoo.com
> ---
>  cpu/ppc4xx/uic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
> index a95d1cb..0ce7a93 100644
> --- a/cpu/ppc4xx/uic.c
> +++ b/cpu/ppc4xx/uic.c
> @@ -164,7 +164,7 @@ void pic_irq_enable(unsigned int vec)
>      else if (vec >= 96)
>          mtdcr(uic3er, mfdcr(uic3er) | UIC_MASK(vec));
>
> -    debug("Install interrupt for vector %d ==> %p\n", vec, handler);
> +    debug("Enable interrupt for vector %d\n", vec);
>  }
>
>  void pic_irq_disable(unsigned int vec)

Patch still doesn't apply:

Applying: ppc4xx: Fixed PPC4xx debug compilation error in uic.c
error: patch failed: cpu/ppc4xx/uic.c:164
error: cpu/ppc4xx/uic.c: patch does not apply
Patch failed at 0001 ppc4xx: Fixed PPC4xx debug compilation error in uic.c

Not sure what went wrong here. On which repository did you base your patch? 
Please base it on the u-boot-ppc4xx repository (master branch).

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-06-26  8:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  2:31 [U-Boot] [PATCH] ppc4xx: Fixed PPC4xx debug compilation error in uic.c Alessio Centazzo
2009-06-26  8:41 ` Stefan Roese [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-01  3:40 Alessio Centazzo
2009-07-01  7:19 ` Stefan Roese
2009-07-02  5:20 Alessio Centazzo
2009-07-06  5:23 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906261041.18176.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox