From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3 pandora: update pin mux for rev3 boards
Date: Sun, 28 Jun 2009 23:21:55 +0200 [thread overview]
Message-ID: <20090628212155.GA9333@game.jcrosoft.org> (raw)
In-Reply-To: <6ed0b2680906281307h1e178ee0m73692045ca0d4f25@mail.gmail.com>
On 23:07 Sun 28 Jun , Grazvydas Ignotas wrote:
> > when you will be in possession of the old version of a board and just because
> > few people have the board is remove from the mainline you will not be happy.
> > So no we will support the both
>
> Well old boards *do* actually work after these changes, except one
> game button and one analog controller (because of changed GPIOs). But
> all old boards don't have the analog controllers soldered to them,
> except one that I have (there were more but they were disassembled).
> Game buttons can't be used with old boards anyway because they don't
> fit into the case. So after considering these points I can say my "old
> boards are no longer supported" statement is not really valid.
>
> >> What I read is
> >>
> >> "no users ... ever got these boards"
> >>
> >> I would bet that you have some early (broken?) alpha boards not
> >> being supported by U-Boot and never used because replaced by fixed
> >> revisions, too.
> > They will not have to be mainline until the hardware will be stablized
>
> It's true, I sent initial patches before hardware was stabilized, but
> I thought it would be no problem sending patches like this later,
> after all hardware updates. Sorry if I was wrong.
you was not wrong, you just need to be carefull when you add new hardware revision
support as the code was add for precedent hardware and you will need it to bisect it.
I've seen this kind of problem too much to not be carefull as you can have to
pass hours maybe days to debug it
>
> So now I'm going to split this patch and resend, is that ok with you?
as you confirm you do not brake the old hardware support
just take a look to not loose the "game button" as the analog controller is
not even availlable
otherwise fine
Best Regards,
J.
next prev parent reply other threads:[~2009-06-28 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 11:57 [U-Boot] [PATCH] OMAP3 pandora: update pin mux for rev3 boards Grazvydas Ignotas
2009-06-25 21:59 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-26 0:12 ` Jason Kridner
2009-06-27 21:58 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-28 5:40 ` Dirk Behme
2009-06-28 9:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-28 11:11 ` Dirk Behme
2009-06-28 11:50 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-28 12:17 ` Dirk Behme
2009-06-28 20:07 ` Grazvydas Ignotas
2009-06-28 21:21 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-26 8:43 ` Grazvydas Ignotas
2009-06-27 21:55 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090628212155.GA9333@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox