From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 30 Jun 2009 15:01:11 -0400 Subject: [U-Boot] [PATCH] flread: new command for reading indirect mapped flashes In-Reply-To: <1246387465-13156-1-git-send-email-vapier@gentoo.org> References: <1246387465-13156-1-git-send-email-vapier@gentoo.org> Message-ID: <200906301501.12299.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 30 June 2009 14:44:25 Mike Frysinger wrote: > + if (dst < CONFIG_SYS_SDRAM_BASE || > + (dst + size) > (CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_MAX_RAM_SIZE)) { > + printf("Error: memory area %#08lx to %#08lx is not in RAM\n", > + dst, dst + size); > + return 1; > + } actually, now that i think about it and read the diff yet again, this check doesnt make sense. if the user gives a bad address, that is their fault. this prevents reading of the flash into say on-chip data SRAMs on a Blackfin part, or into SRAM that is mapped into the async bank. once Stefan (and anyone else) gets a chance to review, i'll post a new patch -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090630/24237e13/attachment.pgp