From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 1 Jul 2009 09:21:29 +0200 Subject: [U-Boot] [PATCH] ppc4xx: Fixed compilation warning in 4xx_enet.c In-Reply-To: <527726.98174.qm@web51908.mail.re2.yahoo.com> References: <527726.98174.qm@web51908.mail.re2.yahoo.com> Message-ID: <200907010921.29454.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 01 July 2009 05:43:53 Alessio Centazzo wrote: > This patch fixes a compilation warning for some Ethernet PHY-less > PPC4xx platforms (440SPE based ones) and a potential compilation > error for 440SP platforms (use of undefined 'ethgroup' variable). > In the original code and in case of 440SPE platforms, 'ethgroup' > is initialized to -1 and never modified. Later in the function, > within an #ifdef statement, an 'if statement' executes code only > if 'ethgroup' is set to 4, therefore it is harmless to avoid > executing the 'if statement' by removing the CONFIG_440SPE from > the affected #ifdefs. In case of 440SP platforms with on-board > Ethernet PHY, 'ethgroup' is undefined but used (there are not such > platforms in the repository yet). All other architectures are not > affected by this change. This is the current warning message with > a Ethernet PHY-less 440SPE platform build (there is not such > platform in the repository yet): > > 4xx_enet.c: In function 'ppc_4xx_eth_init': > 4xx_enet.c:880: warning: unused variable 'ethgroup' Same issue here. Still doesn't apply. Most like again a whitespace issue (tabs vs spaces). Please fix and resubmit. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================