From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 3 Jul 2009 23:00:22 +0200 Subject: [U-Boot] [PATCH 1/1] OMAP3 Fix compiler warning for v7_flush_dcache_all In-Reply-To: <4A4D2D05.1080508@windriver.com> References: <1246392253-8431-1-git-send-email-Tom.Rix@windriver.com> <1246392253-8431-2-git-send-email-Tom.Rix@windriver.com> <20090702210018.GC28287@game.jcrosoft.org> <4A4D2D05.1080508@windriver.com> Message-ID: <20090703210022.GC4937@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:56 Thu 02 Jul , Tom wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 15:04 Tue 30 Jun , Tom Rix wrote: > >>On build of omap3 targets in MAKEALL, the *.ERR files have > >> > >>cpu.c: In function 'cleanup_before_linux': > >>cpu.c:64: warning: implicit declaration of function 'v7_flush_dcache_all' > >>cpu.c:64: warning: implicit declaration of function 'get_device_type > >> > >>The functions v7_flush_dcache_all and get_device_type are declared > >>in include/asm-arm/arch-omap3/sys_proto.h, so use this file to > >>declare the functions. > >> > >>Signed-off-by: Tom Rix > >>--- > >> cpu/arm_cortexa8/cpu.c | 3 +++ > >> 1 files changed, 3 insertions(+), 0 deletions(-) > >> > >>diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c > >>index fcb5775..ab1cfc7 100644 > >>--- a/cpu/arm_cortexa8/cpu.c > >>+++ b/cpu/arm_cortexa8/cpu.c > >>@@ -35,6 +35,9 @@ > >> #include > >> #include > >> #include > >>+#ifndef CONFIG_L2_OFF > >>+#include > >>+#endif > >v7_flush_dcache_all is not omap3 specific but armv7 specific so we must no > >need to depend on arch specific header > > > That is where they are declared. > Would you rather the declaration be moved from sys_proto.h or to > declare them in cpu.c ? remove this non needed dependency and use the generic flush dcache Best Regards, J.