[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

Jean-Christophe PLAGNIOL-VILLARD
2009-07-08T11:05:54Z

> > > > please include config_cmd_default.h
> > > Hi Jean
> > > I do not want to include config_cmd_default.h All commands in this
> > > file are not supported/required for this board.
> > include/config_cmd_default.h
> >
> > please include this one and undef what you do not needis
> Hi Jean,
> Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h.
> There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands
> This will add ~15 lines to the code unnecessarily.
> Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board.
> Is it mandatory to include this file?
mandatory no
but keep the same config style will be better

Best Regards,
J.