[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Remy Bohmer
2009-07-09T14:43:18Z

Hi,

>> At least there is 1 significant difference between your patch
>> and the patch of Michael
>>
>> Your patch contains this:
>> --------------------------------------------------------
>> - ? ? typeReq = req->request << 8 | req->requesttype;
>> + ? ? typeReq = req->request | req->requesttype << 8;
>>
>> ? ? ? switch (le16_to_cpu(typeReq)) {
>> --------------------------------------------------------
>>
>> and Michael patch contains this:
>> --------------------------------------------------------
>> - ? ? typeReq = req->request << 8 | req->requesttype;
>> + ? ? typeReq = req->request | req->requesttype << 8;
>>
>> - ? ? switch (le16_to_cpu(typeReq)) {
>> + ? ? switch (typeReq) {
> Dear Remy
> These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug)
> Well.. for big endian machines someone need to check since it swaps bytes.

Exactly!

> I think we should not remove this macro since it provides arch specific abstraction.

Well, that depends, if it is not needed it should be removed...
So, still I would not prefer to apply patches from which it is obvious
that there is something wrong with it.

Kind Regards,

Remy