[U-Boot] [PATCH v3 0/8] hwconfig and some its users

Anton Vorontsov
2009-06-11T14:39:43Z

On Thu, Jun 11, 2009 at 09:09:56AM -0500, Kim Phillips wrote:
[...]
> > > Suggestion: instead of
> > >
> > > set hwconfig dr_usb,dr_usb_mode:peripheral,dr_usb_phy_type:ulpi
> > >
> > > use:
> > >
> > > set hwconfig dr_usb:mode=peripheral,phy_type=ulpi
> > >
> > > What do you think?
> >
> > Sorry for the delay. Done.
> > New patches on the way.
>
> I had made a similar comment to the original hwconfig posting that
> appears to have been missed:
>
> http://lists.denx.de/pipermail/u-boot/2009-April/051845.html

I didn't miss it. ;-)

> the existing syntax is flawed, e.g., what is the separator character
> going to be when you want to configure something more than dr_usb using
> the syntax used in this patchseries?

The separator between options is ';', between sub-options is ','.

So that would be 'dr_usb:mode=host,phy_type=ulpi; esdhc".

Which translates to

dr_usb {
mode = host;
phy_type = ulpi;
};

esdhc;

> And can we adopt a syntax that's
> more familiar (or recognizable) to our users from the outset?

Sure, I'm open to suggestions. Originally you proposed this scheme:

set hwconfig "usb=dr; dr_usb_mode=peripheral; dr_usb_phy_type=ulpi"

But Wolfgang proposed options and sub-options to save some
typing (notice the repetitive dr_usb), so there should be two
assignment symbols and two symbols for separation.

Thanks,

--
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2