From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache
Date: Tue, 7 Jul 2009 22:31:48 +0200 [thread overview]
Message-ID: <20090707203148.GO30172@game.jcrosoft.org> (raw)
In-Reply-To: <4A52B993.1090103@windriver.com>
On 21:57 Mon 06 Jul , Tom wrote:
> Woodruff, Richard wrote:
> >>From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> >>Behalf Of Tom Rix
> >>Sent: Monday, July 06, 2009 11:48 AM
> >
> >>Since there is only one version of flushing the dcache for
> >>arm_cortex8, rename v7_flush_dcache_all to the the generic
> >>name flush_dcache. Because the function is intended for
> >>only omap3 boards, move the function to the new file
> >>cache_flush.S.
> >
> >Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory).
> >
> I will change the name to cache_ops.S
I prefer cache.S
> flush_dcache was chosen to match other boards/cpu's and one of the
> main reasons for this change. If Jean is ok changing flush_dcache
> to invalidate_dcache, I will make that change too.
invalidate_dcache is fine for me
Best Regards,
J.
next prev parent reply other threads:[~2009-07-07 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 16:47 [U-Boot] V2 remove omap3 compiler warning wrt v7_flush_dcache_all Tom Rix
2009-07-06 16:47 ` [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix
2009-07-06 16:47 ` [U-Boot] [PATCH 2/2] OMAP3 Fix compiler warning for get_device_type Tom Rix
2009-07-06 17:34 ` [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Woodruff, Richard
2009-07-07 2:57 ` Tom
2009-07-07 20:31 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-07 20:44 ` Tom
2009-07-07 21:20 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 9:47 ` Wolfgang Denk
2009-08-08 13:40 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707203148.GO30172@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox