From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Tue, 7 Jul 2009 22:31:48 +0200 Subject: [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache In-Reply-To: <4A52B993.1090103@windriver.com> References: <1246898879-6567-1-git-send-email-Tom.Rix@windriver.com> <1246898879-6567-2-git-send-email-Tom.Rix@windriver.com> <13B9B4C6EF24D648824FF11BE8967162039644516B@dlee02.ent.ti.com> <4A52B993.1090103@windriver.com> Message-ID: <20090707203148.GO30172@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 21:57 Mon 06 Jul , Tom wrote: > Woodruff, Richard wrote: > >>From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On > >>Behalf Of Tom Rix > >>Sent: Monday, July 06, 2009 11:48 AM > > > >>Since there is only one version of flushing the dcache for > >>arm_cortex8, rename v7_flush_dcache_all to the the generic > >>name flush_dcache. Because the function is intended for > >>only omap3 boards, move the function to the new file > >>cache_flush.S. > > > >Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory). > > > I will change the name to cache_ops.S I prefer cache.S > flush_dcache was chosen to match other boards/cpu's and one of the > main reasons for this change. If Jean is ok changing flush_dcache > to invalidate_dcache, I will make that change too. invalidate_dcache is fine for me Best Regards, J.