[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Prafulla Wadaskar]

This driver is tested on Sheevaplug platform

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
 drivers/usb/host/Makefile        |    1 +
 drivers/usb/host/ehci-kirkwood.c |  108 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/host/ehci-kirkwood.c

diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index ec1d689..940d4a8 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -37,6 +37,7 @@ COBJS-$(CONFIG_USB_SL811HS) += sl811-hcd.o
 COBJS-$(CONFIG_USB_EHCI) += ehci-hcd.o
 COBJS-$(CONFIG_USB_EHCI_FSL) += ehci-fsl.o
 COBJS-$(CONFIG_USB_EHCI_IXP4XX) += ehci-ixp.o
+COBJS-$(CONFIG_USB_EHCI_KIRKWOOD) += ehci-kirkwood.o
 COBJS-$(CONFIG_USB_EHCI_PCI) += ehci-pci.o
 COBJS-$(CONFIG_USB_EHCI_VCT) += ehci-vct.o
 
diff --git a/drivers/usb/host/ehci-kirkwood.c b/drivers/usb/host/ehci-kirkwood.c
new file mode 100644
index 0000000..64997b8
--- /dev/null
+++ b/drivers/usb/host/ehci-kirkwood.c
@@ -0,0 +1,108 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <usb.h>
+#include "ehci.h"
+#include "ehci-core.h"
+#include <asm/arch/kirkwood.h>
+
+#define rdl(off)	readl(KW_USB20_BASE + (off))
+#define wrl(off, val)	writel((val), KW_USB20_BASE + (off))
+
+#define USB_WINDOW_CTRL(i)	(0x320 + ((i) << 4))
+#define USB_WINDOW_BASE(i)	(0x324 + ((i) << 4))
+#define USB_TARGET_DRAM		0x0
+
+/*
+ * USB 2.0 Bridge Address Decoding registers setup
+ */
+static void usb_brg_adrdec_setup(void)
+{
+	int i;
+	u32 size, attrib;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+
+		/* Enable DRAM bank */
+		switch (i) {
+		case 0:
+			attrib = KWCPU_ATTR_DRAM_CS0;
+			break;
+		case 1:
+			attrib = KWCPU_ATTR_DRAM_CS1;
+			break;
+		case 2:
+			attrib = KWCPU_ATTR_DRAM_CS2;
+			break;
+		case 3:
+			attrib = KWCPU_ATTR_DRAM_CS3;
+			break;
+		default:
+			/* invalide bank, disable access */
+			attrib = 0;
+			break;
+		}
+
+		size = kw_sdram_bs(i);
+		if ((size) && (attrib))
+			wrl(USB_WINDOW_CTRL(i),
+				KWCPU_WIN_CTRL_DATA(size, USB_TARGET_DRAM,
+					attrib, KWCPU_WIN_ENABLE));
+		else
+			wrl(USB_WINDOW_CTRL(i), KWCPU_WIN_DISABLE);
+
+		wrl(USB_WINDOW_BASE(i), kw_sdram_bar(i));
+	}
+}
+
+/*
+ * Create the appropriate control structures to manage
+ * a new EHCI host controller.
+ */
+int ehci_hcd_init(void)
+{
+	usb_brg_adrdec_setup();
+
+	hccr = (struct ehci_hccr *)(KW_USB20_BASE + 0x100);
+	hcor = (struct ehci_hcor *)((uint32_t) hccr
+			+ HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	debug("Kirkwood-ehci: init hccr %x and hcor %x hc_length %d\n",
+		(uint32_t)hccr, (uint32_t)hcor,
+		(uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	return 0;
+}
+
+/*
+ * Destroy the appropriate control structures corresponding
+ * the the EHCI host controller.
+ */
+int ehci_hcd_stop(void)
+{
+	return 0;
+}
+
-- 
1.5.3.3

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Prafulla Wadaskar]

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND
5. Enabled USB PHY init for kernel need
6. Boot from USB supported

Note: to boot Kirkwood kernel with USB support,
	you should add "usb start" in the boot sequence

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

v5: USB support added

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 ++++++++
 board/Marvell/sheevaplug/config.mk    |   25 ++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 +++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  206 +++++++++++++++++++++++++++++++++
 8 files changed, 486 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h

diff --git a/MAINTAINERS b/MAINTAINERS
index b5b5484..8b16d2f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -659,6 +659,10 @@ Hugo Villeneuve <hugo.villeneuve@lyrtech.com>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <prafulla@marvell.com>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <r-woodruff2@ti.com>
 
 	omap2420h4	ARM1136EJS
diff --git a/MAKEALL b/MAKEALL
index fb80cfa..e1cac9b 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -520,6 +520,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
diff --git a/Makefile b/Makefile
index dbc237f..d770296 100644
--- a/Makefile
+++ b/Makefile
@@ -2918,6 +2918,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3146,7 +3149,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
diff --git a/board/Marvell/sheevaplug/Makefile b/board/Marvell/sheevaplug/Makefile
new file mode 100644
index 0000000..e378b5b
--- /dev/null
+++ b/board/Marvell/sheevaplug/Makefile
@@ -0,0 +1,51 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS	:= sheevaplug.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak .depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/Marvell/sheevaplug/config.mk b/board/Marvell/sheevaplug/config.mk
new file mode 100644
index 0000000..a4ea769
--- /dev/null
+++ b/board/Marvell/sheevaplug/config.mk
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
diff --git a/board/Marvell/sheevaplug/sheevaplug.c b/board/Marvell/sheevaplug/sheevaplug.c
new file mode 100644
index 0000000..547126a
--- /dev/null
+++ b/board/Marvell/sheevaplug/sheevaplug.c
@@ -0,0 +1,155 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <miiphy.h>
+#include <asm/arch/kirkwood.h>
+#include <asm/arch/mpp.h>
+#include "sheevaplug.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int board_init(void)
+{
+	/*
+	 * default gpio configuration
+	 * There are maximum 64 gpios controlled through 2 sets of registers
+	 * the  below configuration configures mainly initial LED status
+	 */
+	kw_config_gpio(SHEEVAPLUG_OE_VAL_LOW,
+			SHEEVAPLUG_OE_VAL_HIGH,
+			SHEEVAPLUG_OE_LOW, SHEEVAPLUG_OE_HIGH);
+
+	/* Multi-Purpose Pins Functionality configuration */
+	u32 kwmpp_config[] = {
+		MPP0_NF_IO2,
+		MPP1_NF_IO3,
+		MPP2_NF_IO4,
+		MPP3_NF_IO5,
+		MPP4_NF_IO6,
+		MPP5_NF_IO7,
+		MPP6_SYSRST_OUTn,
+		MPP7_GPO,
+		MPP8_UART0_RTS,
+		MPP9_UART0_CTS,
+		MPP10_UART0_TXD,
+		MPP11_UART0_RXD,
+		MPP12_SD_CLK,
+		MPP13_SD_CMD,
+		MPP14_SD_D0,
+		MPP15_SD_D1,
+		MPP16_SD_D2,
+		MPP17_SD_D3,
+		MPP18_NF_IO0,
+		MPP19_NF_IO1,
+		MPP20_GPIO,
+		MPP21_GPIO,
+		MPP22_GPIO,
+		MPP23_GPIO,
+		MPP24_GPIO,
+		MPP25_GPIO,
+		MPP26_GPIO,
+		MPP27_GPIO,
+		MPP28_GPIO,
+		MPP29_TSMP9,
+		MPP30_GPIO,
+		MPP31_GPIO,
+		MPP32_GPIO,
+		MPP33_GPIO,
+		MPP34_GPIO,
+		MPP35_GPIO,
+		MPP36_GPIO,
+		MPP37_GPIO,
+		MPP38_GPIO,
+		MPP39_GPIO,
+		MPP40_GPIO,
+		MPP41_GPIO,
+		MPP42_GPIO,
+		MPP43_GPIO,
+		MPP44_GPIO,
+		MPP45_GPIO,
+		MPP46_GPIO,
+		MPP47_GPIO,
+		MPP48_GPIO,
+		MPP49_GPIO,
+		0
+	};
+	kirkwood_mpp_conf(kwmpp_config);
+
+	/*
+	 * arch number of board
+	 */
+	gd->bd->bi_arch_number = MACH_TYPE_SHEEVAPLUG;
+
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	int i;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		gd->bd->bi_dram[i].start = kw_sdram_bar(i);
+		gd->bd->bi_dram[i].size = kw_sdram_bs(i);
+	}
+	return 0;
+}
+
+#ifdef CONFIG_RESET_PHY_R
+/* Configure and enable MV88E1116 PHY */
+void reset_phy(void)
+{
+	u16 reg;
+	u16 devadr;
+	char *name = "egiga0";
+
+	if (miiphy_set_current_dev(name))
+		return;
+
+	/* command to read PHY dev address */
+	if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) {
+		printf("Err..%s could not read PHY dev address\n",
+			__FUNCTION__);
+		return;
+	}
+
+	/*
+	 * Enable RGMII delay on Tx and Rx for CPU port
+	 * Ref: sec 4.7.2 of chip datasheet
+	 */
+	miiphy_write(name, devadr, MV88E1116_PGADR_REG, 2);
+	miiphy_read(name, devadr, MV88E1116_MAC_CTRL_REG, &reg);
+	reg |= (MV88E1116_RGMII_RXTM_CTRL | MV88E1116_RGMII_TXTM_CTRL);
+	miiphy_write(name, devadr, MV88E1116_MAC_CTRL_REG, reg);
+	miiphy_write(name, devadr, MV88E1116_PGADR_REG, 0);
+
+	/* reset the phy */
+	miiphy_reset(name, devadr);
+
+	printf("88E1116 Initialized on %s\n", name);
+}
+#endif /* CONFIG_RESET_PHY_R */
diff --git a/board/Marvell/sheevaplug/sheevaplug.h b/board/Marvell/sheevaplug/sheevaplug.h
new file mode 100644
index 0000000..3ed5b7f
--- /dev/null
+++ b/board/Marvell/sheevaplug/sheevaplug.h
@@ -0,0 +1,41 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __SHEEVAPLUG_H
+#define __SHEEVAPLUG_H
+
+#define SHEEVAPLUG_OE_LOW		(~(0))
+#define SHEEVAPLUG_OE_HIGH		(~(0))
+#define SHEEVAPLUG_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define SHEEVAPLUG_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+/* PHY related */
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* __SHEEVAPLUG_H */
diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
new file mode 100644
index 0000000..cdd7acd
--- /dev/null
+++ b/include/configs/sheevaplug.h
@@ -0,0 +1,206 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_SHEEVAPLUG_H
+#define _CONFIG_SHEEVAPLUG_H
+
+/*
+ * Version number information
+ */
+#define CONFIG_IDENT_STRING	"\nMarvell-Sheevaplug"
+
+/*
+ * High Level Configuration Options (easy to change)
+ */
+#define CONFIG_MARVELL		1
+#define CONFIG_ARM926EJS	1	/* Basic Architecture */
+#define CONFIG_FEROCEON_88FR131	1	/* CPU Core subversion */
+#define CONFIG_KIRKWOOD		1	/* SOC Family Name */
+#define CONFIG_KW88F6281	1	/* SOC Name */
+#define CONFIG_MACH_SHEEVAPLUG	/* Machine type */
+
+#define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
+#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
+#define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
+#define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
+
+/*
+ * CLKs configurations
+ */
+#define CONFIG_SYS_HZ		1000
+
+/*
+ * NS16550 Configuration
+ */
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
+#define CONFIG_SYS_NS16550_CLK		CONFIG_SYS_TCLK
+#define CONFIG_SYS_NS16550_COM1		KW_UART0_BASE
+
+/*
+ * Serial Port configuration
+ * The following definitions let you select what serial you want to use
+ * for your console driver.
+ */
+
+#define CONFIG_CONS_INDEX	1	/*Console on UART0 */
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, \
+					  115200,230400, 460800, 921600 }
+/* auto boot */
+#define CONFIG_BOOTDELAY	3	/* default enable autoboot */
+
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define CONFIG_CMDLINE_TAG	1	/* enable passing of ATAGs  */
+#define CONFIG_INITRD_TAG	1	/* enable INITRD tag */
+#define CONFIG_SETUP_MEMORY_TAGS 1	/* enable memory tag */
+
+#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* Command Prompt */
+#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O Buff Size */
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
+		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
+/*
+ * Commands configuration
+ */
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_BOOTD
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_LOADB
+#define CONFIG_CMD_MEMORY
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_RUN
+#define CONFIG_CMD_SAVEENV
+#define CONFIG_CMD_USB
+
+/*
+ * Flash configuration
+ */
+#ifndef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		1	/* Declare no flash (NOR/SPI) */
+#endif
+
+/*
+ * NAND configuration
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_NAND_KIRKWOOD
+#define CONFIG_SYS_MAX_NAND_DEVICE	1
+#define NAND_MAX_CHIPS			1
+#define CONFIG_SYS_NAND_BASE		0xD8000000	/* KW_DEFADR_NANDF */
+#define NAND_ALLOW_ERASE_ALL		1
+#endif
+
+/*
+ *  Environment variables configurations
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_ENV_IS_IN_NAND		1
+#define CONFIG_ENV_SECT_SIZE		0x20000	/* 128K */
+#else
+#define CONFIG_ENV_IS_NOWHERE		1	/* if env in SDRAM */
+#endif
+/*
+ * max 4k env size is enough, but in case of nand
+ * it has to be rounded to sector size
+ */
+#define CONFIG_ENV_SIZE			0x20000	/* 128k */
+#define CONFIG_ENV_ADDR			0x40000
+#define CONFIG_ENV_OFFSET		0x40000	/* env starts here */
+
+/*
+ * Default environment variables
+ */
+#define CONFIG_BOOTCOMMAND		"${x_bootcmd_kernel}; "	\
+	"setenv bootargs ${x_bootargs} ${x_bootargs_root}; "	\
+	"${x_bootcmd_usb}; bootm 0x6400000;"
+
+#define CONFIG_MTDPARTS		"orion_nand:512k(uboot),"	\
+	"3m at 1m(kernel),1m at 4m(psm),13m at 5m(rootfs) rw\0"
+
+#define CONFIG_EXTRA_ENV_SETTINGS	"x_bootargs=console"	\
+	"=ttyS0,115200 mtdparts="CONFIG_MTDPARTS	\
+	"x_bootcmd_kernel=nand read 0x6400000 0x100000 0x300000\0" \
+	"x_bootcmd_usb=usb start\0" \
+	"x_bootargs_root=root=/dev/mtdblock3 rw rootfstype=jffs2\0"
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN	(1024 * 128) /* 128kB for malloc() */
+/* size in bytes reserved for initial data */
+#define CONFIG_SYS_GBL_DATA_SIZE	128
+
+/*
+ * Other required minimal configurations
+ */
+#define CONFIG_CONSOLE_INFO_QUIET	/* some code reduction */
+#define CONFIG_ARCH_CPU_INIT	/* call arch_cpu_init() */
+#define CONFIG_ARCH_MISC_INIT	/* call arch_misc_init() */
+#define CONFIG_DISPLAY_CPUINFO	/* Display cpu info */
+#define CONFIG_NR_DRAM_BANKS	4
+#define CONFIG_STACKSIZE	0x00100000	/* regular stack- 1M */
+#define CONFIG_SYS_LOAD_ADDR	0x00800000	/* default load adr- 8M */
+#define CONFIG_SYS_MEMTEST_START 0x00400000	/* 4M */
+#define CONFIG_SYS_MEMTEST_END	0x007fffff	/*(_8M -1) */
+#define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
+#define CONFIG_SYS_MAXARGS	16	/* max number of command args */
+
+/*
+ * Ethernet Driver configuration
+ */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_NETCONSOLE	/* include NetConsole support   */
+#define CONFIG_NET_MULTI	/* specify more that one ports available */
+#define	CONFIG_MII		/* expose smi ove miiphy interface */
+#define CONFIG_KIRKWOOD_EGIGA	/* Enable kirkwood Gbe Controller Driver */
+#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN	/* detect link using phy */
+#define CONFIG_KIRKWOOD_EGIGA_PORTS	{1,0}	/* enable port 0 only */
+#define CONFIG_PHY_BASE_ADR	0
+#define CONFIG_ENV_OVERWRITE	/* ethaddr can be reprogrammed */
+#define CONFIG_RESET_PHY_R	/* use reset_phy() to init mv8831116 PHY */
+#endif /* CONFIG_CMD_NET */
+
+/*
+ * USB/EHCI
+ */
+#ifdef CONFIG_CMD_USB
+#define CONFIG_USB_EHCI			/* Enable EHCI USB support */
+#define CONFIG_USB_EHCI_KIRKWOOD	/* on Kirkwood platform	*/
+#define CONFIG_EHCI_IS_TDI
+#define CONFIG_USB_STORAGE
+#define CONFIG_DOS_PARTITION
+#define CONFIG_ISO_PARTITION
+#define CONFIG_SUPPORT_VFAT
+#endif /* CONFIG_CMD_USB */
+
+#endif /* _CONFIG_SHEEVAPLUG_H */
-- 
1.5.3.3

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Prafulla Wadaskar [mailto:prafulla at marvell.com] 
> Sent: Monday, June 29, 2009 9:01 PM
> To: u-boot at lists.denx.de
> Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; 
> Prafulla Wadaskar
> Subject: [PATCH v5 6/6] Marvell Sheevaplug Board support
> 
> Reference:
> http://plugcomputer.org/
> http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support 

Hi Jean and Remy
Any feedback on this patch series?
This is widely used board and there are some other Kirkwood board supports pipelined those will have at least MAINTAINERS file dependency from this patch

Please let me know if I need to do anything more to get them in :-)

Regards..
Prafulla . .

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Jean-Christophe PLAGNIOL-VILLARD]

> +/*
> + * CLKs configurations
> + */
> +#define CONFIG_SYS_HZ		1000
> +
> +/*
> + * NS16550 Configuration
> + */
> +#define CONFIG_SYS_NS16550
> +#define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
> +#define CONFIG_SYS_NS16550_CLK		CONFIG_SYS_TCLK
> +#define CONFIG_SYS_NS16550_COM1		KW_UART0_BASE
> +
> +/*
> + * Serial Port configuration
> + * The following definitions let you select what serial you want to use
> + * for your console driver.
> + */
> +
> +#define CONFIG_CONS_INDEX	1	/*Console on UART0 */
> +#define CONFIG_BAUDRATE			115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, \
> +					  115200,230400, 460800, 921600 }
> +/* auto boot */
> +#define CONFIG_BOOTDELAY	3	/* default enable autoboot */
> +
> +/*
> + * For booting Linux, the board info and command line data
> + * have to be in the first 8 MB of memory, since this is
> + * the maximum mapped by the Linux kernel during initialization.
> + */
> +#define CONFIG_CMDLINE_TAG	1	/* enable passing of ATAGs  */
> +#define CONFIG_INITRD_TAG	1	/* enable INITRD tag */
> +#define CONFIG_SETUP_MEMORY_TAGS 1	/* enable memory tag */
> +
> +#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* Command Prompt */
> +#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O Buff Size */
> +#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
> +		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
> +/*
> + * Commands configuration
> + */
please include config_cmd_default.h
> +#define CONFIG_CMD_AUTOSCRIPT
> +#define CONFIG_CMD_BOOTD
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_ENV
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_LOADB
> +#define CONFIG_CMD_MEMORY
> +#define CONFIG_CMD_NAND
> +#define CONFIG_CMD_NET
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_RUN
> +#define CONFIG_CMD_SAVEENV
> +#define CONFIG_CMD_USB
otherwise ok
Best Regards,
J.

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Saturday, July 04, 2009 5:16 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support
> 
<snip....>
> > +#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* 
> Command Prompt */
> > +#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O 
> Buff Size */
> > +#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
> > +		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
> > +/*
> > + * Commands configuration
> > + */
> please include config_cmd_default.h
Hi Jean
I do not want to include config_cmd_default.h
All commands in this file are not supported/required for this board.

Regards..
Prafulla . .

> > +#define CONFIG_CMD_AUTOSCRIPT
<snip...>
> > +#define CONFIG_CMD_USB
> otherwise ok
> Best Regards,
> J.
> 

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Jean-Christophe PLAGNIOL-VILLARD]

On 00:26 Tue 07 Jul     , Prafulla Wadaskar wrote:
>  
> 
> > -----Original Message-----
> > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> > Sent: Saturday, July 04, 2009 5:16 AM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> > Ronen Shitrit
> > Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support
> > 
> <snip....>
> > > +#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* 
> > Command Prompt */
> > > +#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O 
> > Buff Size */
> > > +#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
> > > +		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
> > > +/*
> > > + * Commands configuration
> > > + */
> > please include config_cmd_default.h
> Hi Jean
> I do not want to include config_cmd_default.h
> All commands in this file are not supported/required for this board.
include/config_cmd_default.h

please include this one and undef what you do not need

Best Regards,
J.

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Wednesday, July 08, 2009 2:00 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support
> 
> On 00:26 Tue 07 Jul     , Prafulla Wadaskar wrote:
> >  
> > 
> > > -----Original Message-----
> > > From: Jean-Christophe PLAGNIOL-VILLARD 
> > > [mailto:plagnioj at jcrosoft.com]
> > > Sent: Saturday, July 04, 2009 5:16 AM
> > > To: Prafulla Wadaskar
> > > Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan 
> Sarnaik; Ronen 
> > > Shitrit
> > > Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board 
> > > support
> > > 
> > <snip....>
> > > > +#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* 
> > > Command Prompt */
> > > > +#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O 
> > > Buff Size */
> > > > +#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
> > > > +		+sizeof(CONFIG_SYS_PROMPT) + 16)	
> /* Print Buff */
> > > > +/*
> > > > + * Commands configuration
> > > > + */
> > > please include config_cmd_default.h
> > Hi Jean
> > I do not want to include config_cmd_default.h All commands in this 
> > file are not supported/required for this board.
> include/config_cmd_default.h
> 
> please include this one and undef what you do not needis
Hi Jean,
Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h.
There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands
This will add ~15 lines to the code unnecessarily.
Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board.
Is it mandatory to include this file?

Regards..
Prafulla . .

> 
> Best Regards,
> J.
> 

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Stefan Roese]

On Wednesday 08 July 2009 07:52:27 Prafulla Wadaskar wrote:
> > > > > +/*
> > > > > + * Commands configuration
> > > > > + */
> > > >
> > > > please include config_cmd_default.h
> > >
> > > Hi Jean
> > > I do not want to include config_cmd_default.h All commands in this
> > > file are not supported/required for this board.
> >
> > include/config_cmd_default.h
> >
> > please include this one and undef what you do not needis
>
> Hi Jean,
> Total 13 commands used for this board out of which only 7 are configured in
> config_cmd_default.h. There are total 20 commands defined in
> config_cmd_default.h i.e. I need to undef 13 commands This will add ~15
> lines to the code unnecessarily.
> Secondly config_cmd_default.h may be updated frequently for commands
> addition, which may not be supported/required on this board. Then again we
> have to apply undef patch for this board. Is it mandatory to include this
> file?

It's not mandatory. But one advantage is that by using this file (and not 
uncommenting most of the stuff) all boards have the same look-and-feel by 
supporting the same command sets.

But your command selection looks fine and I think that it's ok to define then 
the way you did.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

[Jean-Christophe PLAGNIOL-VILLARD]

> > > > please include config_cmd_default.h
> > > Hi Jean
> > > I do not want to include config_cmd_default.h All commands in this 
> > > file are not supported/required for this board.
> > include/config_cmd_default.h
> > 
> > please include this one and undef what you do not needis
> Hi Jean,
> Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h.
> There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands
> This will add ~15 lines to the code unnecessarily.
> Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board.
> Is it mandatory to include this file?
mandatory no
but keep the same config style will be better

Best Regards,
J.

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Prafulla Wadaskar [mailto:prafulla at marvell.com] 
> Sent: Monday, June 29, 2009 8:57 PM
> To: u-boot at lists.denx.de
> Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; 
> Prafulla Wadaskar
> Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> controller driver
> 
> This driver is tested on Sheevaplug platform
Dear Remy

Sorry for pinging :-)
May be this has been skipped from your huge inbox :-)
Can you pls kindly provide your feedback on this patch or Shall I repost it?

Regards..
Prafulla . .

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Remy Bohmer]

Hi,

2009/7/8 Prafulla Wadaskar <prafulla@marvell.com>:
>
>
>> -----Original Message-----
>> From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
>> Sent: Monday, June 29, 2009 8:57 PM
>> To: u-boot at lists.denx.de
>> Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare;
>> Prafulla Wadaskar
>> Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host
>> controller driver
>> This driver is tested on Sheevaplug platform
> Dear Remy
>
> Sorry for pinging :-)
> May be this has been skipped from your huge inbox :-)

No, it was in there, I just overlooked it...

> Can you pls kindly provide your feedback on this patch or Shall I repost it?

This patch looks fine to me.
Applied to u-boot-usb.

Thanks.

Remy

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 21:49 Wed 08 Jul     , Remy Bohmer wrote:
> Hi,
> 
> 2009/7/8 Prafulla Wadaskar <prafulla@marvell.com>:
> >
> >
> >> -----Original Message-----
> >> From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
> >> Sent: Monday, June 29, 2009 8:57 PM
> >> To: u-boot at lists.denx.de
> >> Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare;
> >> Prafulla Wadaskar
> >> Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host
> >> controller driver
> >> This driver is tested on Sheevaplug platform
> > Dear Remy
> >
> > Sorry for pinging :-)
> > May be this has been skipped from your huge inbox :-)
> 
> No, it was in there, I just overlooked it...
> 
> > Can you pls kindly provide your feedback on this patch or Shall I repost it?
> 
> This patch looks fine to me.
> Applied to u-boot-usb.
please send the pull request to finsh the sheevaplug support mainline

Best Regards,
J.

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On 
> Behalf Of Remy Bohmer
> Sent: Thursday, July 09, 2009 1:20 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; 
> Ashish Karkare
> Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> controller driver
> 
> Hi,
> 
> 2009/7/8 Prafulla Wadaskar <prafulla@marvell.com>:
> >
> >
> >> -----Original Message-----
> >> From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
> >> Sent: Monday, June 29, 2009 8:57 PM
> >> To: u-boot at lists.denx.de
> >> Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla 
> >> Wadaskar
> >> Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> controller 
> >> driver This driver is tested on Sheevaplug platform
> > Dear Remy
> >
> > Sorry for pinging :-)
> > May be this has been skipped from your huge inbox :-)
> 
> No, it was in there, I just overlooked it...
> 
> > Can you pls kindly provide your feedback on this patch or 
> Shall I repost it?
> 
> This patch looks fine to me.
> Applied to u-boot-usb.
>
Thanks Remy
As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

Regards..
Prafulla . .
 
> Thanks.
> 
> Remy
> 

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Remy Bohmer]

Hello Prafulla,

> As stated in other email thread too.
> Now all dependencies for Sheevaplug board support are in accepted state except this patch http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

I know that but I cannot test it because I do not have the hardware,
so I depend on others here. (it might be even you). I already
mentioned that I would prefer the cleanup patch from Michael
Trimarchi, if it is correct.

At least there is 1 significant difference between your patch and the
patch of Michael

Your patch contains this:
--------------------------------------------------------
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;

 	switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;

-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {
--------------------------------------------------------

So,@least one of them is wrong.
This difference is reason enough for me to not pull either patch in
until this is clear.

Kind Regards,

Remy

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On 
> Behalf Of Remy Bohmer
> Sent: Thursday, July 09, 2009 1:00 PM
> To: Prafulla Wadaskar; Michael Trimarchi
> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; 
> Ashish Karkare
> Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> controller driver
> 
> Hello Prafulla,
> 
> > As stated in other email thread too.
> > Now all dependencies for Sheevaplug board support are in accepted 
> > state except this patch 
> > http://lists.denx.de/pipermail/u-boot/2009-June/055112.html
> 
> I know that but I cannot test it because I do not have the 
> hardware, so I depend on others here. (it might be even you). 
> I already mentioned that I would prefer the cleanup patch 
> from Michael Trimarchi, if it is correct.
> 
> At least there is 1 significant difference between your patch 
> and the patch of Michael
> 
> Your patch contains this:
> --------------------------------------------------------
> -	typeReq = req->request << 8 | req->requesttype;
> +	typeReq = req->request | req->requesttype << 8;
> 
>  	switch (le16_to_cpu(typeReq)) {
> --------------------------------------------------------
> 
> and Michael patch contains this:
> --------------------------------------------------------
> -	typeReq = req->request << 8 | req->requesttype;
> +	typeReq = req->request | req->requesttype << 8;
> 
> -	switch (le16_to_cpu(typeReq)) {
> +	switch (typeReq) {
Dear Remy
These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug)
Well.. for big endian machines someone need to check since it swaps bytes.

I think we should not remove this macro since it provides arch specific abstraction.

Regards..
Prafulla . .

> --------------------------------------------------------
> 
> So, at least one of them is wrong.
> This difference is reason enough for me to not pull either 
> patch in until this is clear.
> 
> Kind Regards,
> 
> Remy
> 

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Remy Bohmer]

Hi,

>> At least there is 1 significant difference between your patch
>> and the patch of Michael
>>
>> Your patch contains this:
>> --------------------------------------------------------
>> - ? ? typeReq = req->request << 8 | req->requesttype;
>> + ? ? typeReq = req->request | req->requesttype << 8;
>>
>> ? ? ? switch (le16_to_cpu(typeReq)) {
>> --------------------------------------------------------
>>
>> and Michael patch contains this:
>> --------------------------------------------------------
>> - ? ? typeReq = req->request << 8 | req->requesttype;
>> + ? ? typeReq = req->request | req->requesttype << 8;
>>
>> - ? ? switch (le16_to_cpu(typeReq)) {
>> + ? ? switch (typeReq) {
> Dear Remy
> These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug)
> Well.. for big endian machines someone need to check since it swaps bytes.

Exactly!

> I think we should not remove this macro since it provides arch specific abstraction.

Well, that depends, if it is not needed it should be removed...
So, still I would not prefer to apply patches from which it is obvious
that there is something wrong with it.

Kind Regards,

Remy

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Michael Trimarchi]

Prafulla Wadaskar wrote:
>  
>
>   
>> -----Original Message-----
>> From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On 
>> Behalf Of Remy Bohmer
>> Sent: Thursday, July 09, 2009 1:00 PM
>> To: Prafulla Wadaskar; Michael Trimarchi
>> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; 
>> Ashish Karkare
>> Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
>> controller driver
>>
>> Hello Prafulla,
>>
>>     
>>> As stated in other email thread too.
>>> Now all dependencies for Sheevaplug board support are in accepted 
>>> state except this patch 
>>> http://lists.denx.de/pipermail/u-boot/2009-June/055112.html
>>>       
>> I know that but I cannot test it because I do not have the 
>> hardware, so I depend on others here. (it might be even you). 
>> I already mentioned that I would prefer the cleanup patch 
>> from Michael Trimarchi, if it is correct.
>>
>> At least there is 1 significant difference between your patch 
>> and the patch of Michael
>>
>> Your patch contains this:
>> --------------------------------------------------------
>> -	typeReq = req->request << 8 | req->requesttype;
>> +	typeReq = req->request | req->requesttype << 8;
>>
>>  	switch (le16_to_cpu(typeReq)) {
>> --------------------------------------------------------
>>
>> and Michael patch contains this:
>> --------------------------------------------------------
>> -	typeReq = req->request << 8 | req->requesttype;
>> +	typeReq = req->request | req->requesttype << 8;
>>
>> -	switch (le16_to_cpu(typeReq)) {
>> +	switch (typeReq) {
>>     
> Dear Remy
> These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug)
> Well.. for big endian machines someone need to check since it swaps bytes.
>
> I think we should not remove this macro since it provides arch specific abstraction.
>   
If you don't remove the macro I think that you have trouble with big endian
machines.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/usb/core/hcd.c;h=95ccfa0b9fc52876f5166b3edea039409adf9a33;hb=HEAD

line 442

Michael
> Regards..
> Prafulla . .
>
>   
>> --------------------------------------------------------
>>
>> So, at least one of them is wrong.
>> This difference is reason enough for me to not pull either 
>> patch in until this is clear.
>>
>> Kind Regards,
>>
>> Remy
>>
>>     

[U-Boot] [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it] 
> Sent: Thursday, July 09, 2009 9:54 PM
> To: Prafulla Wadaskar
> Cc: Remy Bohmer; u-boot at lists.denx.de; Prabhanjan Sarnaik; 
> Ronen Shitrit; Ashish Karkare
> Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> controller driver
> 
> Prafulla Wadaskar wrote:
> >  
> >
> >   
> >> -----Original Message-----
> >> From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On 
> Behalf Of 
> >> Remy Bohmer
> >> Sent: Thursday, July 09, 2009 1:00 PM
> >> To: Prafulla Wadaskar; Michael Trimarchi
> >> Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen 
> Shitrit; Ashish 
> >> Karkare
> >> Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host 
> >> controller driver
> >>
> >> Hello Prafulla,
> >>
> >>     
> >>> As stated in other email thread too.
> >>> Now all dependencies for Sheevaplug board support are in accepted 
> >>> state except this patch 
> >>> http://lists.denx.de/pipermail/u-boot/2009-June/055112.html
> >>>       
> >> I know that but I cannot test it because I do not have the 
> hardware, 
> >> so I depend on others here. (it might be even you).
> >> I already mentioned that I would prefer the cleanup patch from 
> >> Michael Trimarchi, if it is correct.
> >>
> >> At least there is 1 significant difference between your 
> patch and the 
> >> patch of Michael
> >>
> >> Your patch contains this:
> >> --------------------------------------------------------
> >> -	typeReq = req->request << 8 | req->requesttype;
> >> +	typeReq = req->request | req->requesttype << 8;
> >>
> >>  	switch (le16_to_cpu(typeReq)) {
> >> --------------------------------------------------------
> >>
> >> and Michael patch contains this:
> >> --------------------------------------------------------
> >> -	typeReq = req->request << 8 | req->requesttype;
> >> +	typeReq = req->request | req->requesttype << 8;
> >>
> >> -	switch (le16_to_cpu(typeReq)) {
> >> +	switch (typeReq) {
> >>     
> > Dear Remy
> > These two lines makes no difference for me since le16_to_cpu macro 
> > doesn't change anything for arm little-endian machines 
> (i.e. Sheevaplug) Well.. for big endian machines someone need 
> to check since it swaps bytes.
> >
> > I think we should not remove this macro since it provides 
> arch specific abstraction.
> >   
> If you don't remove the macro I think that you have trouble 
> with big endian machines.
Dear Michael
At least common change in both the patch can be applied, this will at least resolve fix for little endian machines. We can defer second change until somebody tests it

Regards..
Prafulla . .

> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.g
it;a=blob;f=drivers/usb/core/hcd.c;h=95ccfa0b9fc52876f5166b3edea039409adf9a33;hb=HEAD
> 
> line 442
> 
> Michael
> > Regards..
> > Prafulla . .
> >
> >   
> >> --------------------------------------------------------
> >>
> >> So, at least one of them is wrong.
> >> This difference is reason enough for me to not pull either 
> patch in 
> >> until this is clear.
> >>
> >> Kind Regards,
> >>
> >> Remy
> >>
> >>     
> 
>