public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Pull request: nand flash
Date: Wed, 08 Jul 2009 21:51:22 +0200	[thread overview]
Message-ID: <20090708195122.3003C832E416@gemini.denx.de> (raw)
In-Reply-To: <20090707230448.GA31160@b07421-ec1.am.freescale.net>

Dear Scott Wood,

In message <20090707230448.GA31160@b07421-ec1.am.freescale.net> you wrote:
> The following changes since commit 59869ca72df8bc4e4ffa9dd17cb6673bbe010272:
>   Wolfgang Denk (1):
>         Merge branch 'master' of git://git.denx.de/u-boot-video
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-nand-flash.git master
> 
> I fixed the obvious merge conflict (missing #endif) in "davinci_nand:
> cleanup I (minor)", but I'm a little confused since the symbol it refers
> to (CONFIG_SOC_DM6446) doesn't seem to be defined anywhere.  At first I
> thought it had been replaced with CONFIG_SOC_DM644X, but that doesn't
> seem to be the case -- AFAICT, there never was a definition of
> CONFIG_SOC_DM6446 in the tree.  There is one other place in the tree
> that ifdefs based on it, though (cpu/arm926ejs/davinci/cpu.c).
> 
> David, any thoughts?  If this is in error, could you send a followup
> patch?
> 
> David Brownell (3):
>       davinci_nand: cleanup I (minor)
>       davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC)
>       davinci_nand chipselect/init cleanup
> 
> Guennadi Liakhovetski (2):
>       env_nand: remove unused variable.
>       nand_spl: read environment early, when booting from NAND using nand_spl
> 
> HeungJun Kim (1):
>       env_onenand: change env_address type from unsigned long to loff_t

I have serious problems with your renaming of the patch subjects. For
exampole, this was submitted as

	MTD: change env_address type from unsigned long to loff_t

My matching of commits against patches submitted on the list is based
on the idea that these get checked in (mostly) unchanged. Please make
my life a bit easier! [I will probably reject the next  pull  request
when there are so many changed subject lines like this time :-( ]

If you don't like the Subject, then please reject the patch and ask
the submitter to fix and repost it.

> Jean-Christophe PLAGNIOL-VILLARD (1):
>       mtd: nand: use loff_t for offset

And this was:

	nand_init: use loff_t for offset

> Mike Frysinger (1):
>       mtd: nand: new base driver for memory mapped nand devices
> 
> Mingkai Hu (1):
>       fsl_elbc_nand: redirect the pointer of bbt pattern to RAM

This was:

	NAND: redirect the pointer of bbt pattern to RAM

> Sandeep Paulraj (2):
>       ARM DaVinci: Changing ALE Mask Value
>       NAND DaVinci: Update to ALE/CLE Mask values
> 
> Scott Wood (1):
>       nand_spl: Fix cmd_ctrl usage in nand_boot.c.
> 
> Wolfgang Denk (1):
>       nand/onenand: Fix missing argument checking for "markbad" command
> 
> kevin.morfitt at fearnside-systems.co.uk (1):
>       Bug-fix in drivers mtd nand Makefile
> 
>  README                                   |    6 +
>  board/bf537-stamp/Makefile               |    1 -
>  board/bf537-stamp/nand.c                 |  100 ----------
>  board/davinci/sonata/sonata.c            |   28 +++
>  common/cmd_nand.c                        |   31 +++-
>  common/cmd_onenand.c                     |   35 +++--
>  common/env_nand.c                        |   51 +++---
>  common/env_onenand.c                     |    2 +-
>  doc/README.nand                          |    9 -
>  drivers/mtd/nand/Makefile                |    3 +-
>  drivers/mtd/nand/davinci_nand.c          |  289 ++++--------------------------
>  drivers/mtd/nand/fsl_elbc_nand.c         |    4 +
>  drivers/mtd/nand/nand_plat.c             |   53 ++++++
>  drivers/mtd/nand/nand_util.c             |   20 +-
>  include/asm-arm/arch-davinci/nand_defs.h |  130 +-------------
>  include/configs/bf537-stamp.h            |   44 ++---
>  include/configs/bfin_adi_common.h        |    3 +
>  include/configs/smdk6400.h               |    3 +
>  include/nand.h                           |   14 +-
>  nand_spl/nand_boot.c                     |   28 +++-
>  20 files changed, 273 insertions(+), 581 deletions(-)
>  delete mode 100644 board/bf537-stamp/nand.c
>  create mode 100644 drivers/mtd/nand/nand_plat.c

Applied, thanks. But please see above.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of programmers carrying screwdrivers."      - Chip Salzenberg

  reply	other threads:[~2009-07-08 19:51 UTC|newest]

Thread overview: 166+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 23:04 [U-Boot] Pull request: nand flash Scott Wood
2009-07-08 19:51 ` Wolfgang Denk [this message]
2009-07-08 19:55   ` Scott Wood
2009-07-13 23:29 ` David Brownell
2009-07-16 19:47   ` [U-Boot] Typo fix: use CONFIG_SOC_DM644X, not CONFIG_SOC_DM646 Scott Wood
2009-07-16 22:02     ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2016-09-02 16:31 [U-Boot] Pull request: nand flash Scott Wood
2016-09-06 16:58 ` Tom Rini
2016-07-25 18:44 Scott Wood
2016-07-26  2:33 ` Tom Rini
2016-06-20  8:11 Scott Wood
2016-06-20 12:45 ` Tom Rini
2016-06-04  4:35 Scott Wood
2016-06-06 11:16 ` Tom Rini
2016-02-13  6:14 Scott Wood
2016-02-14 18:56 ` Tom Rini
2015-05-25  0:25 Scott Wood
2015-05-25 12:36 ` Tom Rini
2015-03-31 20:59 Scott Wood
2015-04-01  0:56 ` Tom Rini
2015-03-31 20:55 Scott Wood
2015-01-09 20:12 Scott Wood
2015-01-10 19:10 ` Tom Rini
2014-11-27  7:25 Scott Wood
2014-11-27 18:09 ` Tom Rini
2014-10-10  1:08 Scott Wood
2014-10-10 14:39 ` Tom Rini
2014-09-25 20:28 Scott Wood
2014-09-26  0:15 ` Tom Rini
2014-03-05  2:09 Scott Wood
2014-03-05 21:08 ` Tom Rini
2014-03-12 12:34   ` Gupta, Pekon
2013-12-18 23:10 Scott Wood
2013-12-19 17:45 ` Tom Rini
2013-11-22 20:32 Scott Wood
2013-11-25 21:56 ` Tom Rini
2013-10-09 18:29 Scott Wood
2013-10-10  1:45 ` Tom Rini
2013-10-10  8:12   ` Albert ARIBAUD
2013-10-10 11:45     ` Tom Rini
2013-10-10 15:52       ` Albert ARIBAUD
2013-10-10 19:00         ` Albert ARIBAUD
2013-10-10 19:18           ` Tom Rini
2013-10-10 22:10             ` Scott Wood
2013-10-10 22:52               ` Tom Rini
2013-10-11  7:11                 ` Albert ARIBAUD
2013-10-11 12:36                   ` Albert ARIBAUD
2013-10-11  0:11 ` Otavio Salvador
2013-10-14 15:17 ` Tom Rini
2013-08-23 15:48 Scott Wood
2013-08-23 19:28 ` Tom Rini
2013-07-12 21:13 Scott Wood
2013-07-12 21:23 ` Tom Rini
2013-06-28 16:46 Scott Wood
2013-07-01 19:28 ` Tom Rini
2013-06-06 16:33 Scott Wood
2013-06-07 18:19 ` Tom Rini
2013-05-31 19:52 Scott Wood
2013-05-31 21:28 ` Tom Rini
2013-05-31 21:44   ` Scott Wood
2013-05-31 22:08     ` Tom Rini
2013-02-26 21:44 Scott Wood
2013-02-28 20:25 ` Tom Rini
2012-12-21 21:37 Scott Wood
2012-12-22 12:53 ` Tom Rini
2012-12-14 22:06 Scott Wood
2012-12-18 19:58 ` Tom Rini
2012-11-26 21:49 Scott Wood
2012-11-27 16:45 ` Tom Rini
2012-09-18  1:21 Scott Wood
2012-09-18 16:26 ` Tom Rini
2012-06-08 19:59 Scott Wood
2012-06-19 20:12 ` Wolfgang Denk
2012-05-18 23:23 Scott Wood
2012-05-20 20:49 ` Wolfgang Denk
2012-02-28 20:57 Scott Wood
2012-03-03 14:18 ` Wolfgang Denk
2012-01-26 22:12 Scott Wood
2012-02-11 21:15 ` Wolfgang Denk
2011-12-07 22:11 Scott Wood
2011-10-10 22:12 Scott Wood
2011-10-12 20:44 ` Wolfgang Denk
2011-10-03 23:57 Scott Wood
2011-10-04 20:42 ` Wolfgang Denk
2011-07-01 22:02 Scott Wood
2011-07-04  7:34 ` Wolfgang Denk
2011-05-24 21:09 Scott Wood
2011-06-01 20:00 ` Wolfgang Denk
2011-05-17 18:20 Scott Wood
2011-05-18 12:31 ` Wolfgang Denk
2011-05-13 16:16 Scott Wood
2011-05-15 21:24 ` Wolfgang Denk
2011-04-15 21:28 Scott Wood
2011-04-20 20:52 ` Wolfgang Denk
2011-04-01 19:58 Scott Wood
2011-04-01 20:18 ` Wolfgang Denk
2011-02-09 19:59 Scott Wood
2011-02-09 20:25 ` Wolfgang Denk
2011-02-02 22:16 Scott Wood
2011-02-04 19:37 ` Wolfgang Denk
2011-02-04 19:46   ` Scott Wood
2011-02-04 20:45 ` Wolfgang Denk
2011-01-12 23:15 Scott Wood
2011-01-17 19:08 ` Wolfgang Denk
2010-12-16 21:36 Scott Wood
2010-12-16 22:20 ` Wolfgang Denk
2010-12-07 22:05 Scott Wood
2010-12-08 22:17 ` Wolfgang Denk
2010-10-18 20:14 Scott Wood
2010-10-18 20:24 ` Wolfgang Denk
2010-10-11 20:34 Scott Wood
2010-10-12 18:29 ` Wolfgang Denk
2010-09-13 19:44 Scott Wood
2010-09-15 20:06 ` Wolfgang Denk
2010-08-16 22:01 Scott Wood
2010-08-17 21:54 ` Wolfgang Denk
2010-07-09 19:41 Scott Wood
2010-07-14 19:44 ` Wolfgang Denk
2010-05-26 23:00 Scott Wood
2010-05-28 17:46 ` Wolfgang Denk
2010-01-27 21:13 Scott Wood
2010-02-03 19:08 ` Wolfgang Denk
2010-01-19 23:22 Scott Wood
2010-01-21 21:02 ` Wolfgang Denk
2010-01-19 23:11 Scott Wood
2010-01-11 18:03 Scott Wood
2010-01-12 22:43 ` Wolfgang Denk
2009-12-11 19:14 Scott Wood
2009-12-14 20:29 ` Wolfgang Denk
2009-09-29 16:12 Scott Wood
2009-09-30 21:34 ` Wolfgang Denk
2009-08-18 15:47 Scott Wood
2009-08-21 20:56 ` Wolfgang Denk
2009-08-21 21:11   ` Scott Wood
2009-07-18 17:40 Scott Wood
2009-07-18 22:59 ` Wolfgang Denk
2009-07-07 22:35 Scott Wood
2009-07-07 22:38 ` Scott Wood
2009-04-03 20:33 Scott Wood
2009-04-03 20:49 ` Wolfgang Denk
2009-03-23 22:08 Scott Wood
2009-03-25 21:39 ` Wolfgang Denk
2009-03-17 17:10 Scott Wood
2009-03-17 23:39 ` Wolfgang Denk
2009-02-06 23:31 Scott Wood
2009-02-07 22:43 ` Wolfgang Denk
2009-01-23 17:08 Scott Wood
2009-01-23 21:51 ` Wolfgang Denk
2009-01-28  8:23 ` Wolfgang Denk
2009-01-28  8:42   ` Liu Dave
2009-01-28  9:00     ` Wolfgang Denk
2009-01-28 16:55       ` Scott Wood
2008-12-16 21:16 Scott Wood
2008-12-16 23:32 ` Liu Dave
2008-12-17 17:41   ` Scott Wood
2008-12-18  7:25     ` Liu Dave
2008-12-30 22:25 ` Wolfgang Denk
2008-12-03 18:50 Scott Wood
2008-12-04 23:16 ` Wolfgang Denk
2008-11-25 16:50 Scott Wood
2008-10-31 21:40 Scott Wood
2008-11-01 15:21 ` Wolfgang Denk
2008-10-31 21:16 Scott Wood
2008-11-01 15:20 ` Wolfgang Denk
2008-10-29 21:31 Scott Wood
2008-10-30 19:57 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090708195122.3003C832E416@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox