From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pxa: fix CKEN_B register bits
Date: Thu, 9 Jul 2009 10:11:47 +0200 [thread overview]
Message-ID: <20090709081147.GT19257@buzzloop.caiaq.de> (raw)
In-Reply-To: <1245771005-23299-2-git-send-email-daniel@caiaq.de>
ping?
On Tue, Jun 23, 2009 at 05:30:05PM +0200, Daniel Mack wrote:
> From: Daniel Mack <daniel@caiaq.de>
> To: u-boot at lists.denx.de
> Cc: Daniel Mack <daniel@caiaq.de>
> Subject: [PATCH 2/2] pxa: fix CKEN_B register bits
> Date: Tue, 23 Jun 2009 17:30:05 +0200
> Message-Id: <1245771005-23299-2-git-send-email-daniel@caiaq.de>
> X-Mailer: git-send-email 1.6.3.1
>
> The current defition for CKEN_B register bits is nonsense. Adding 32 to
> the shifted value is equal to '| (1 << 5)', and this bit is marked
> 'reserved' in the PXA docs.
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> ---
> include/asm-arm/arch-pxa/pxa-regs.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/asm-arm/arch-pxa/pxa-regs.h b/include/asm-arm/arch-pxa/pxa-regs.h
> index 1f81e11..2a723dc 100644
> --- a/include/asm-arm/arch-pxa/pxa-regs.h
> +++ b/include/asm-arm/arch-pxa/pxa-regs.h
> @@ -1953,12 +1953,12 @@ typedef void (*ExcpHndlr) (void) ;
> #define CKENA_1_LCD (1 << 1) /* LCD Unit Clock Enable */
>
> #define CKENB_9_SYSBUS2 (1 << 9) /* System bus 2 */
> -#define CKENB_8_1WIRE ((1 << 8) + 32) /* One Wire Interface Unit Clock Enable */
> -#define CKENB_7_GPIO ((1 << 7) + 32) /* GPIO Clock Enable */
> -#define CKENB_6_IRQ ((1 << 6) + 32) /* Interrupt Controller Clock Enable */
> -#define CKENB_4_I2C ((1 << 4) + 32) /* I2C Unit Clock Enable */
> -#define CKENB_1_PWM1 ((1 << 1) + 32) /* PWM2 & PWM3 Clock Enable */
> -#define CKENB_0_PWM0 ((1 << 0) + 32) /* PWM0 & PWM1 Clock Enable */
> +#define CKENB_8_1WIRE (1 << 8) /* One Wire Interface Unit Clock Enable */
> +#define CKENB_7_GPIO (1 << 7) /* GPIO Clock Enable */
> +#define CKENB_6_IRQ (1 << 6) /* Interrupt Controller Clock Enable */
> +#define CKENB_4_I2C (1 << 4) /* I2C Unit Clock Enable */
> +#define CKENB_1_PWM1 (1 << 1) /* PWM2 & PWM3 Clock Enable */
> +#define CKENB_0_PWM0 (1 << 0) /* PWM0 & PWM1 Clock Enable */
>
> #else /* if defined CONFIG_CPU_MONAHANS */
>
> --
> 1.6.3.1
>
next prev parent reply other threads:[~2009-07-09 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 15:30 [U-Boot] [PATCH 1/2] pxa: add clock for system bus 2 arbiter Daniel Mack
2009-06-23 15:30 ` [U-Boot] [PATCH 2/2] pxa: fix CKEN_B register bits Daniel Mack
2009-07-09 8:11 ` Daniel Mack [this message]
2009-07-09 8:11 ` [U-Boot] [PATCH 1/2] pxa: add clock for system bus 2 arbiter Daniel Mack
2009-07-09 11:37 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709081147.GT19257@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox