[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[Dieter Kiermaier]

Hi again,

Here is my first out of 2 patches which adds gpio support to arch/kirkwood.
Any suggestions?

Cheers,
Dieter

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Dieter Kiermaier]

Hi,

patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
Any comments are welcome!

Dieter

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> Hi,
> 
> patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> Any comments are welcome!
> 
> Dieter
> 
> 
> >From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001
> From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> Date: Mon, 29 Jun 2009 14:29:15 +0200
> Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug
> 
> 
> Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> ---
>  board/Marvell/sheevaplug/sheevaplug.c |    1 +
>  include/configs/sheevaplug.h          |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/board/Marvell/sheevaplug/sheevaplug.c b/board/Marvell/sheevaplug/sheevaplug.c
> index 547126a..fa28fea 100644
> --- a/board/Marvell/sheevaplug/sheevaplug.c
> +++ b/board/Marvell/sheevaplug/sheevaplug.c
> @@ -26,6 +26,7 @@
>  #include <miiphy.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
> +#include <asm/arch/gpio.h>
>  #include "sheevaplug.h"
>  
>  DECLARE_GLOBAL_DATA_PTR;
> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> index e62353c..7455c29 100644
> --- a/include/configs/sheevaplug.h
> +++ b/include/configs/sheevaplug.h
> @@ -43,6 +43,7 @@
>  #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
>  #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
>  #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
> +#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
>  #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
>  #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
why do you need it??

Best Regards,
J.

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Dieter Kiermaier]

Jean,

> On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> > Hi,
> > 
> > patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> > Any comments are welcome!
> > 
> > Dieter
> > 
> > 
> > >From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001
> > From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> > Date: Mon, 29 Jun 2009 14:29:15 +0200
> > Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug
> > 
> > 
> > Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> > ---
> >  board/Marvell/sheevaplug/sheevaplug.c |    1 +
> >  include/configs/sheevaplug.h          |    1 +
> >  2 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/board/Marvell/sheevaplug/sheevaplug.c b/board/Marvell/sheevaplug/sheevaplug.c
> > index 547126a..fa28fea 100644
> > --- a/board/Marvell/sheevaplug/sheevaplug.c
> > +++ b/board/Marvell/sheevaplug/sheevaplug.c
> > @@ -26,6 +26,7 @@
> >  #include <miiphy.h>
> >  #include <asm/arch/kirkwood.h>
> >  #include <asm/arch/mpp.h>
> > +#include <asm/arch/gpio.h>
> >  #include "sheevaplug.h"
> >  
> >  DECLARE_GLOBAL_DATA_PTR;
> > diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> > index e62353c..7455c29 100644
> > --- a/include/configs/sheevaplug.h
> > +++ b/include/configs/sheevaplug.h
> > @@ -43,6 +43,7 @@
> >  #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
> >  #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
> >  #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
> > +#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
> >  #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
> >  #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
> why do you need it??
I fear it is of no need - it seems it is left from some earlier testing :(
Should i repost the patch?

Thanks,
Dieter

> 
> Best Regards,
> J.
> 

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Dieter Kiermaier]

Hi Jean, hi Prafulla,

here the corrected version.

Many thanks,
Dieter

> On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> > Hi,
> > 
> > patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> > Any comments are welcome!
> > 
> > Dieter
> > 
> > 
> > >From 528b24be54256cee20f965bc772390034eaeb232 Mon Sep 17 00:00:00 2001
> > From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> > Date: Mon, 29 Jun 2009 14:29:15 +0200
> > Subject: [PATCH] Sheevaplug: Add Kirkwood gpio support to Sheevaplug
> > 
> > 
> > Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> > ---
> >  board/Marvell/sheevaplug/sheevaplug.c |    1 +
> >  include/configs/sheevaplug.h          |    1 +
> >  2 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/board/Marvell/sheevaplug/sheevaplug.c b/board/Marvell/sheevaplug/sheevaplug.c
> > index 547126a..fa28fea 100644
> > --- a/board/Marvell/sheevaplug/sheevaplug.c
> > +++ b/board/Marvell/sheevaplug/sheevaplug.c
> > @@ -26,6 +26,7 @@
> >  #include <miiphy.h>
> >  #include <asm/arch/kirkwood.h>
> >  #include <asm/arch/mpp.h>
> > +#include <asm/arch/gpio.h>
> >  #include "sheevaplug.h"
> >  
> >  DECLARE_GLOBAL_DATA_PTR;
> > diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> > index e62353c..7455c29 100644
> > --- a/include/configs/sheevaplug.h
> > +++ b/include/configs/sheevaplug.h
> > @@ -43,6 +43,7 @@
> >  #define CONFIG_MD5	/* get_random_hex on krikwood needs MD5 support */
> >  #define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
> >  #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
> > +#define CONFIG_KIRKWOOD_GPIO		/* Enable GPIO Support */
> >  #define CONFIG_KIRKWOOD_USBPHY_INIT	/* Enable USB PHY init for kernel */
> >  #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
> why do you need it??
> 
> Best Regards,
> J.
> 

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de] 
> Sent: Thursday, July 09, 2009 12:25 PM
> To: Jean-Christophe PLAGNIOL-VILLARD
> Cc: u-boot at lists.denx.de; Prafulla Wadaskar
> Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood 
> gpio support to Sheevaplug
> 
> Hi Jean, hi Prafulla,
> 
> here the corrected version.
> 
> Many thanks,
> Dieter
> 
> > On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> > > Hi,
> > > 
> > > patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> > > Any comments are welcome!
Hi Dieter
Thanks for your efforts
That's good, gpio driver is supported for Kirkwood but,
Again question remains the same- Why do you need gpio support on Sheevaplug? Whereas you have no evidence to use it.

Regards..
Prafulla . .

[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> Hi again,
> 
> Here is my first out of 2 patches which adds gpio support to arch/kirkwood.
> Any suggestions?
> 
> Cheers,
> Dieter
> 
> 
> >From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001
> From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> Date: Mon, 29 Jun 2009 14:22:13 +0200
> Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver
> 
> 
> Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
looks fine
Prafulla & nico for you?

Best Regards,
J.

[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[Heiko Schocher]

Hello Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
>> Hi again,
>>
>> Here is my first out of 2 patches which adds gpio support to arch/kirkwood.
>> Any suggestions?
>>
>> Cheers,
>> Dieter
>>
>>
>> >From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001
>> From: Dieter Kiermaier <dk-arm-linux@gmx.de>
>> Date: Mon, 29 Jun 2009 14:22:13 +0200
>> Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver
>>
>>
>> Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> looks fine
> Prafulla & nico for you?

I actually tested this driver on the suen3 board with the i2c
bitbang driver and it works fine :-), so I do a:

Tested-by: Heiko Schocher <hs@denx.de>

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Heiko Schocher
> Sent: Thursday, July 09, 2009 11:11 AM
> To: Jean-Christophe PLAGNIOL-VILLARD
> Cc: Nicolas Pitre; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH1/2] Kirkwood: add Marvell 
> Kirkwood gpio driver
> 
> Hello Jean-Christophe,
> 
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> >> Hi again,
> >>
> >> Here is my first out of 2 patches which adds gpio support 
> to arch/kirkwood.
> >> Any suggestions?
> >>
> >> Cheers,
> >> Dieter
> >>
> >>
> >> >From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 
> >> >2001
> >> From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> >> Date: Mon, 29 Jun 2009 14:22:13 +0200
> >> Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver
> >>
> >>
> >> Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> > looks fine
> > Prafulla & nico for you?
Okay, Ack, mostly code coming from Linux :-)

Regards..
Prafulla . .

> 
> I actually tested this driver on the suen3 board with the i2c 
> bitbang driver and it works fine :-), so I do a:
> 
> Tested-by: Heiko Schocher <hs@denx.de>
> 
> bye
> Heiko
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, 
> Germany _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

[U-Boot] [PATCH1/2] Kirkwood: add Marvell Kirkwood gpio driver

[Jean-Christophe PLAGNIOL-VILLARD]

> >From fcdea0c7bba3c25a1fb183bbcaf6d1a4ec32a157 Mon Sep 17 00:00:00 2001
> From: Dieter Kiermaier <dk-arm-linux@gmx.de>
> Date: Mon, 29 Jun 2009 14:22:13 +0200
> Subject: [PATCH] Kirkwood: add Marvell Kirkwood gpio driver
> 
> 
> Signed-off-by: Dieter Kiermaier <dk-arm-linux@gmx.de>
> ---
>  drivers/gpio/Makefile                |    1 +
>  drivers/gpio/kw_gpio.c               |  151 ++++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-kirkwood/gpio.h |   51 ++++++++++++
>  3 files changed, 203 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/gpio/kw_gpio.c
>  create mode 100644 include/asm-arm/arch-kirkwood/gpio.h
applied to u-boot-arm

Best Regards,
J.

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de] 
> Sent: Thursday, July 09, 2009 12:50 PM
> To: Prafulla Wadaskar
> Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood 
> gpio support to Sheevaplug
> 
> Hi Prafulla,
> 
> > 
> > > -----Original Message-----
> > > From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
> > > Sent: Thursday, July 09, 2009 12:25 PM
> > > To: Jean-Christophe PLAGNIOL-VILLARD
> > > Cc: u-boot at lists.denx.de; Prafulla Wadaskar
> > > Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio 
> > > support to Sheevaplug
> > > 
> > > Hi Jean, hi Prafulla,
> > > 
> > > here the corrected version.
> > > 
> > > Many thanks,
> > > Dieter
> > > 
> > > > On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> > > > > Hi,
> > > > > 
> > > > > patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> > > > > Any comments are welcome!
> > Hi Dieter
> > Thanks for your efforts
> > That's good, gpio driver is supported for Kirkwood but, 
> Again question 
> > remains the same- Why do you need gpio support on 
> Sheevaplug? Whereas you have no evidence to use it.
> 
> That's a good question :)
> I need gpio support for my own board which will come up the 
> next 2 months.
> So maybe you're right. There is no need for GPIO support on 
> SheevaPlug.
Well.. you better post separate patch for your board that needs to use gpio support.

> On the other hand there are maybe some hackers out there 
> using sheevaplug not only as it is. So maybe there is a need 
> for some GPIO bitbanging?
> At least if you open the case :)
I will post this information on plug forum (http://plugcomputer.org/plugforum/index.php).
Also a small how-to doc to uses gpio support for bit bang interface.

> 
> Also many thanks to all of you out there for such a nice boot 
> loader :) Dieter
Thanks to yourself too :-) let's make it further better.

Regards.
Prafulla . .

[U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio support to Sheevaplug

[Dieter Kiermaier]

Hi,
> 
> > -----Original Message-----
> > From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de] 
> > Sent: Thursday, July 09, 2009 12:50 PM
> > To: Prafulla Wadaskar
> > Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood 
> > gpio support to Sheevaplug
> > 
> > Hi Prafulla,
> > 
> > > 
> > > > -----Original Message-----
> > > > From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
> > > > Sent: Thursday, July 09, 2009 12:25 PM
> > > > To: Jean-Christophe PLAGNIOL-VILLARD
> > > > Cc: u-boot at lists.denx.de; Prafulla Wadaskar
> > > > Subject: Re: [U-Boot] [PATCH2/2] Sheevaplug: Add Kirkwood gpio 
> > > > support to Sheevaplug
> > > > 
> > > > Hi Jean, hi Prafulla,
> > > > 
> > > > here the corrected version.
> > > > 
> > > > Many thanks,
> > > > Dieter
> > > > 
> > > > > On 14:45 Mon 29 Jun     , Dieter Kiermaier wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > patch 2 of 2 which adds Kirkwood GPIO support to Sheevaplug.
> > > > > > Any comments are welcome!
> > > Hi Dieter
> > > Thanks for your efforts
> > > That's good, gpio driver is supported for Kirkwood but, 
> > Again question 
> > > remains the same- Why do you need gpio support on 
> > Sheevaplug? Whereas you have no evidence to use it.
> > 
> > That's a good question :)
> > I need gpio support for my own board which will come up the 
> > next 2 months.
> > So maybe you're right. There is no need for GPIO support on 
> > SheevaPlug.
> Well.. you better post separate patch for your board that needs to use gpio support.
> 
Would be the best solution.
Is there anything I have to know if I want u-boot to support my own board?

> > On the other hand there are maybe some hackers out there 
> > using sheevaplug not only as it is. So maybe there is a need 
> > for some GPIO bitbanging?
> > At least if you open the case :)
> I will post this information on plug forum (http://plugcomputer.org/plugforum/index.php).
> Also a small how-to doc to uses gpio support for bit bang interface.
> 
Good idea.
> > 
> > Also many thanks to all of you out there for such a nice boot 
> > loader :) Dieter
> Thanks to yourself too :-) let's make it further better.
> 
Yep.

Dieter

> Regards.
> Prafulla . .
>