From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants
Date: Thu, 9 Jul 2009 14:48:14 +0200 [thread overview]
Message-ID: <200907091448.14376.sr@denx.de> (raw)
In-Reply-To: <4A55E191.9090402@ge.com>
On Thursday 09 July 2009 14:24:49 Jerry Van Baren wrote:
> > All this would increase the code size for those boards not supporting the
> > 64bit printf format. Not sure by how much, but I suggest to just fix the
> > problem by supporting this format correctly instead of adding new code to
> > print some warnings here.
> >
> > Best regards,
> > Stefan
>
> That is what Scott is trying to do, but fixing 64bit printf causes a
> 2K++ increase in size to the boards that don't currently support 64bit
> printf (some of which are broken due to the error). Wolfgang is
> resisting that.
>
> Adding code to print a warning and handle the varargs properly will
> probably be less than 100 bytes. It looks like this is the compromise
> Wolfgang favors.
I doubt that this could be done in less than 100 bytes. A descriptive error
message string alone will probably be around >= 60 chars. But I know this is
nitpicking.
I'm still voting for adding this 2k and doing it correctly on all boards. With
the option to disable this 64bit support (as Scott suggested) on boards with
very tight resources.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-07-09 12:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 9:48 [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants Stefan Roese
2009-07-06 11:17 ` Wolfgang Denk
2009-07-06 15:39 ` Stefan Roese
2009-07-08 20:01 ` Wolfgang Denk
2009-07-08 21:11 ` Scott Wood
2009-07-08 21:24 ` Wolfgang Denk
2009-07-08 21:29 ` Scott Wood
2009-07-08 21:57 ` Wolfgang Denk
2009-07-08 22:27 ` Scott Wood
2009-07-09 4:57 ` Stefan Roese
2009-07-09 7:41 ` Wolfgang Denk
2009-07-08 22:18 ` Jerry Van Baren
2009-07-08 22:27 ` Scott Wood
2009-07-09 5:00 ` Stefan Roese
2009-07-09 12:24 ` Jerry Van Baren
2009-07-09 12:48 ` Stefan Roese [this message]
2009-07-09 13:02 ` Jerry Van Baren
2009-07-09 4:54 ` Stefan Roese
2009-07-17 18:44 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907091448.14376.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox