From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 9 Jul 2009 17:02:10 +0200 Subject: [U-Boot] [PATCH 3/3] 83xx, kmeter1: added NAND support In-Reply-To: <4A5605B6.7010908@denx.de> References: <4A55C0B9.6050809@denx.de> <200907091208.51036.sr@denx.de> <4A5605B6.7010908@denx.de> Message-ID: <200907091702.10529.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 09 July 2009 16:59:02 Heiko Schocher wrote: > >> board/keymile/kmeter1/Makefile | 2 +- > >> board/keymile/kmeter1/nand.c > > > > I suggest to move this NAND driver into the drivers/mtd/nand directory > > (e.g. drivers/mtd/nand/kmeter1_nand.c). We try to collect all drivers > > here. This makes maintenance easier. > > Hmm... this is not a "nand driver", just some board specific > functions. Yes, it's still a NAND driver. Please take a look at a few of the other "drivers" in this directory. E.g. drivers/mtd/nand/atmel_nand.c. You will see that those are similar to your board specific driver. Implementing the HW- interface for the NAND infrastructure. > Should this go really in "drivers/mtd/nand"? Yes, please. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================