public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 5/7
Date: Thu, 9 Jul 2009 22:31:08 +0200	[thread overview]
Message-ID: <20090709203108.GN28344@game.jcrosoft.org> (raw)
In-Reply-To: <4A5639B3.1090604@fearnside-systems.co.uk>

> >> +	/*
> >> +	 * mask all IRQs by setting all bits in the INTMR - default
> >> +	 */
> >> +	mov	r1, #0xffffffff
> >> +	ldr	r0, =INTMSK
> >> +	str	r1, [r0]
> >> +# if defined(CONFIG_S3C2410) || defined(CONFIG_S3C2440)
> >> +	ldr	r1, =INTSMASK
> >> +	ldr	r0, =INTSUBMSK
> >> +	str	r1, [r0]
> >> +# endif
> >> +
> >> +	/* FCLK:HCLK:PCLK = 1:2:4 */
> >> +	/* default FCLK is 120 MHz ! */
> >> +	ldr	r0, =CLKDIVN
> >> +	mov	r1, #CLKDIVVAL
> >> +	str	r1, [r0]
> >> +
> >> +#ifdef CONFIG_S3C2440
> >> +	/* Set asynchronous bus mode */
> >> +	mrc	p15, 0, r1, c1, c0, 0   /* read ctrl register */
> > whitespace please fix
> >> +	orr	r1, r1, #0xc0000000     /* Asynchronous */
> > whitespace please fix
> >> +	mcr	p15, 0, r1, c1, c0, 0   /* write ctrl register */
> > whitespace please fix
> >> +#endif  /* CONFIG_S3C2440 */
> > whitespace please fix
> 
> I'm not sure what the problem is - should the comments be indented with
> a tab?
no with space here
> 
> By the way, I'm on vacation for the next 2 weeks so I won't be able to
> make the changes before the merge window closes. Do I need to wait until
> v2009.08 is released and re-base my changes to that?
after the merge will be close I'll open the next branch and depending on the
time I may ask to have it for this release to wd
> 
> >> +
> >> +	mov	pc, lr
> >> +
> >> +#endif  /* CONFIG_S3C24X0 */
Best Regards,
J.

      reply	other threads:[~2009-07-09 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25  0:35 [U-Boot] [PATCH-ARM, MTD] Add support for Embest SBC2440-II Board 4/7 kevin.morfitt at fearnside-systems.co.uk
2009-06-25  0:36 ` [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 5/7 kevin.morfitt at fearnside-systems.co.uk
2009-07-08 20:54   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-09 18:40     ` kevin.morfitt at fearnside-systems.co.uk
2009-07-09 20:31       ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090709203108.GN28344@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox