From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Move 405EP pci code from cpu_init_f() to __pci_pre_init()
Date: Fri, 10 Jul 2009 09:01:08 +0200 [thread overview]
Message-ID: <200907100901.08120.sr@denx.de> (raw)
In-Reply-To: <200907081343.55798.matthias.fuchs@esd.eu>
On Wednesday 08 July 2009 13:43:55 Matthias Fuchs wrote:
> This patch moves some basic PCI initialisation from the 4xx cpu_init_f()
> to cpu/ppc4xx/4xx_pci.c.
>
> The original cpu_init_f() function enabled the 405EP's internal arbiter
> in all situations. Also the HCE bit in cpc0_pci is always set.
> The first is not really wanted for PCI adapter designs and the latter
> is a general bug for PCI adapter U-Boots. Because it enables
> PCI configuration by the system CPU even when the PCI configuration has
> not been setup by the 405EP. The one and only correct place is
> in pci_405gp_init() (see "Set HCE bit" comment).
>
> So for compatibility reasons the arbiter is still enabled in any case,
> but from weak pci_pre_init() so that it can be replaced by board specific
> code.
>
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
Applied to u-boot-ppc4xx. Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2009-07-10 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 11:43 [U-Boot] [PATCH] ppc4xx: Move 405EP pci code from cpu_init_f() to __pci_pre_init() Matthias Fuchs
2009-07-10 7:01 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907100901.08120.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox