* [U-Boot] [PATCH] ppc4xx: Set default PCI device ID for 405EP boards
@ 2009-07-08 13:31 Matthias Fuchs
2009-07-10 7:01 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Fuchs @ 2009-07-08 13:31 UTC (permalink / raw)
To: u-boot
Current code only sets the PCI vendor id to 0x1014 and
leaved device id to 0x0000.
Ths patch ....
a) uses the correct PCI_VENDOR_ID_IBM macro for this
b) sets the default device ID as stated in the UM to 0x0156
by using PCI_DEVICE_ID_IBM_405GP for this.
Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
---
cpu/ppc4xx/4xx_pci.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/cpu/ppc4xx/4xx_pci.c b/cpu/ppc4xx/4xx_pci.c
index 33dd743..4b5d636 100644
--- a/cpu/ppc4xx/4xx_pci.c
+++ b/cpu/ppc4xx/4xx_pci.c
@@ -337,8 +337,15 @@ void pci_405gp_init(struct pci_controller *hose)
}
#endif
-#if defined(CONFIG_405EP) /* on ppc405ep vendor id is not set */
- pci_write_config_word(PCIDEVID_405GP, PCI_VENDOR_ID, 0x1014); /* IBM */
+#if defined(CONFIG_405EP)
+ /*
+ * on ppc405ep vendor/device id is not set
+ * The user manual says 0x1014 (IBM) / 0x0156 (405GP!)
+ * are the correct values.
+ */
+ pci_write_config_word(PCIDEVID_405GP, PCI_VENDOR_ID, PCI_VENDOR_ID_IBM);
+ pci_write_config_word(PCIDEVID_405GP,
+ PCI_DEVICE_ID, PCI_DEVICE_ID_IBM_405GP);
#endif
/*
--
1.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] ppc4xx: Set default PCI device ID for 405EP boards
2009-07-08 13:31 [U-Boot] [PATCH] ppc4xx: Set default PCI device ID for 405EP boards Matthias Fuchs
@ 2009-07-10 7:01 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2009-07-10 7:01 UTC (permalink / raw)
To: u-boot
On Wednesday 08 July 2009 15:31:57 Matthias Fuchs wrote:
> Current code only sets the PCI vendor id to 0x1014 and
> leaved device id to 0x0000.
>
> Ths patch ....
> a) uses the correct PCI_VENDOR_ID_IBM macro for this
> b) sets the default device ID as stated in the UM to 0x0156
> by using PCI_DEVICE_ID_IBM_405GP for this.
>
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
Applied to u-boot-ppc4xx. Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-10 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-08 13:31 [U-Boot] [PATCH] ppc4xx: Set default PCI device ID for 405EP boards Matthias Fuchs
2009-07-10 7:01 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox