* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
@ 2009-07-11 8:10 Kyungmin Park
2009-07-11 8:11 ` [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker Kyungmin Park
2009-07-12 12:58 ` [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 11+ messages in thread
From: Kyungmin Park @ 2009-07-11 8:10 UTC (permalink / raw)
To: u-boot
Use the common OneNAND linker script.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/onenand_ipl/board/apollon/u-boot.onenand.lds b/onenand_ipl/u-boot-onenand.lds
similarity index 100%
rename from onenand_ipl/board/apollon/u-boot.onenand.lds
rename to onenand_ipl/u-boot-onenand.lds
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker
@ 2009-07-11 8:11 ` Kyungmin Park
2009-07-12 12:59 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 11+ messages in thread
From: Kyungmin Park @ 2009-07-11 8:11 UTC (permalink / raw)
To: u-boot
Use common OneNAND IPL linker script.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/onenand_ipl/board/apollon/Makefile b/onenand_ipl/board/apollon/Makefile
index 49a8e90..f0744f6 100644
--- a/onenand_ipl/board/apollon/Makefile
+++ b/onenand_ipl/board/apollon/Makefile
@@ -2,7 +2,7 @@
include $(TOPDIR)/config.mk
include $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/config.mk
-LDSCRIPT= $(TOPDIR)/onenand_ipl/board/$(BOARDDIR)/u-boot.onenand.lds
+LDSCRIPT= $(TOPDIR)/onenand_ipl/u-boot-onenand.lds
LDFLAGS = -Bstatic -T $(LDSCRIPT) -Ttext $(TEXT_BASE) $(PLATFORM_LDFLAGS)
AFLAGS += -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL
CFLAGS += -DCONFIG_PRELOADER -DCONFIG_ONENAND_IPL
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-11 8:10 [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Kyungmin Park
2009-07-11 8:11 ` [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker Kyungmin Park
@ 2009-07-12 12:58 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-13 0:48 ` Kyungmin Park
2009-07-20 6:11 ` Kyungmin Park
1 sibling, 2 replies; 11+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-07-12 12:58 UTC (permalink / raw)
To: u-boot
On 17:10 Sat 11 Jul , Kyungmin Park wrote:
> Use the common OneNAND linker script.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/onenand_ipl/board/apollon/u-boot.onenand.lds b/onenand_ipl/u-boot-onenand.lds
> similarity index 100%
> rename from onenand_ipl/board/apollon/u-boot.onenand.lds
> rename to onenand_ipl/u-boot-onenand.lds
this is arch specific
please move it to lib_arm/
Best Regards,
J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker
2009-07-11 8:11 ` [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker Kyungmin Park
@ 2009-07-12 12:59 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-16 19:21 ` Scott Wood
0 siblings, 1 reply; 11+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-07-12 12:59 UTC (permalink / raw)
To: u-boot
On 17:11 Sat 11 Jul , Kyungmin Park wrote:
> Use common OneNAND IPL linker script.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
please number the patch to known the apply order
Best Regards,
J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-12 12:58 ` [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Jean-Christophe PLAGNIOL-VILLARD
@ 2009-07-13 0:48 ` Kyungmin Park
2009-07-16 19:20 ` Scott Wood
2009-07-20 6:11 ` Kyungmin Park
1 sibling, 1 reply; 11+ messages in thread
From: Kyungmin Park @ 2009-07-13 0:48 UTC (permalink / raw)
To: u-boot
Hi,
On Sun, Jul 12, 2009 at 9:58 PM, Jean-Christophe
PLAGNIOL-VILLARD<plagnioj@jcrosoft.com> wrote:
> On 17:10 Sat 11 Jul ? ? , Kyungmin Park wrote:
>> Use the common OneNAND linker script.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> diff --git a/onenand_ipl/board/apollon/u-boot.onenand.lds b/onenand_ipl/u-boot-onenand.lds
>> similarity index 100%
>> rename from onenand_ipl/board/apollon/u-boot.onenand.lds
>> rename to onenand_ipl/u-boot-onenand.lds
> this is arch specific
> please move it to lib_arm/
Basically I agree your opinion, however do see the other arch OneNAND
usage? I mean I can't see the other arch patches.
I think until other arch uses it, I want to place it at onenand_ipl directory.
How do you think?
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-13 0:48 ` Kyungmin Park
@ 2009-07-16 19:20 ` Scott Wood
2009-07-17 0:08 ` Shinya Kuribayashi
0 siblings, 1 reply; 11+ messages in thread
From: Scott Wood @ 2009-07-16 19:20 UTC (permalink / raw)
To: u-boot
On Mon, Jul 13, 2009 at 09:48:30AM +0900, Kyungmin Park wrote:
> Basically I agree your opinion, however do see the other arch OneNAND
> usage? I mean I can't see the other arch patches.
There was nothing but powerpc in nand_spl at first, but I don't think ARM
developers would have appreciated finding hardcoded powerpc assumptions
when they tried to add their boards.
-Scott
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker
2009-07-12 12:59 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-07-16 19:21 ` Scott Wood
0 siblings, 0 replies; 11+ messages in thread
From: Scott Wood @ 2009-07-16 19:21 UTC (permalink / raw)
To: u-boot
On Sun, Jul 12, 2009 at 02:59:26PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:11 Sat 11 Jul , Kyungmin Park wrote:
> > Use common OneNAND IPL linker script.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> please number the patch to known the apply order
Numbering won't help here -- they have to go in the same patch
atomically, or else bisect will break.
-Scott
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-16 19:20 ` Scott Wood
@ 2009-07-17 0:08 ` Shinya Kuribayashi
2009-07-22 21:47 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 11+ messages in thread
From: Shinya Kuribayashi @ 2009-07-17 0:08 UTC (permalink / raw)
To: u-boot
Scott Wood wrote:
> On Mon, Jul 13, 2009 at 09:48:30AM +0900, Kyungmin Park wrote:
>> Basically I agree your opinion, however do see the other arch OneNAND
>> usage? I mean I can't see the other arch patches.
>
> There was nothing but powerpc in nand_spl at first, but I don't think ARM
> developers would have appreciated finding hardcoded powerpc assumptions
> when they tried to add their boards.
Heh, we're already using onenand_ipl on our MIPS machines ;-)
--
Shinya Kuribayashi
NEC Electronics
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-12 12:58 ` [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Jean-Christophe PLAGNIOL-VILLARD
2009-07-13 0:48 ` Kyungmin Park
@ 2009-07-20 6:11 ` Kyungmin Park
2009-07-22 21:49 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 11+ messages in thread
From: Kyungmin Park @ 2009-07-20 6:11 UTC (permalink / raw)
To: u-boot
Hi,
On Sun, Jul 12, 2009 at 9:58 PM, Jean-Christophe
PLAGNIOL-VILLARD<plagnioj@jcrosoft.com> wrote:
> On 17:10 Sat 11 Jul ? ? , Kyungmin Park wrote:
>> Use the common OneNAND linker script.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> diff --git a/onenand_ipl/board/apollon/u-boot.onenand.lds b/onenand_ipl/u-boot-onenand.lds
>> similarity index 100%
>> rename from onenand_ipl/board/apollon/u-boot.onenand.lds
>> rename to onenand_ipl/u-boot-onenand.lds
> this is arch specific
> please move it to lib_arm/
>
I want to make a conclusion. Don't you change your mind? Please give
your opinion.
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-17 0:08 ` Shinya Kuribayashi
@ 2009-07-22 21:47 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 11+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-07-22 21:47 UTC (permalink / raw)
To: u-boot
On 09:08 Fri 17 Jul , Shinya Kuribayashi wrote:
> Scott Wood wrote:
> > On Mon, Jul 13, 2009 at 09:48:30AM +0900, Kyungmin Park wrote:
> >> Basically I agree your opinion, however do see the other arch OneNAND
> >> usage? I mean I can't see the other arch patches.
> >
> > There was nothing but powerpc in nand_spl at first, but I don't think ARM
> > developers would have appreciated finding hardcoded powerpc assumptions
> > when they tried to add their boards.
>
> Heh, we're already using onenand_ipl on our MIPS machines ;-)
maybe mainline soon. ;-)
Best Regards,
J.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use
2009-07-20 6:11 ` Kyungmin Park
@ 2009-07-22 21:49 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 11+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-07-22 21:49 UTC (permalink / raw)
To: u-boot
On 15:11 Mon 20 Jul , Kyungmin Park wrote:
> Hi,
>
> On Sun, Jul 12, 2009 at 9:58 PM, Jean-Christophe
> PLAGNIOL-VILLARD<plagnioj@jcrosoft.com> wrote:
> > On 17:10 Sat 11 Jul ? ? , Kyungmin Park wrote:
> >> Use the common OneNAND linker script.
> >>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> diff --git a/onenand_ipl/board/apollon/u-boot.onenand.lds b/onenand_ipl/u-boot-onenand.lds
> >> similarity index 100%
> >> rename from onenand_ipl/board/apollon/u-boot.onenand.lds
> >> rename to onenand_ipl/u-boot-onenand.lds
> > this is arch specific
> > please move it to lib_arm/
> >
>
> I want to make a conclusion. Don't you change your mind? Please give
> your opinion.
as point out by Shinya-san & Scott too other can use it and use it today so please
make it generic
Best Regards,
J.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-07-22 21:49 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-11 8:10 [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Kyungmin Park
2009-07-11 8:11 ` [U-Boot] [PATCH] Apollon board use common OneNAND IPL linker Kyungmin Park
2009-07-12 12:59 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-16 19:21 ` Scott Wood
2009-07-12 12:58 ` [U-Boot] [PATCH] OneNAND IPL: Move u-boot-onenand linker script to common use Jean-Christophe PLAGNIOL-VILLARD
2009-07-13 0:48 ` Kyungmin Park
2009-07-16 19:20 ` Scott Wood
2009-07-17 0:08 ` Shinya Kuribayashi
2009-07-22 21:47 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-20 6:11 ` Kyungmin Park
2009-07-22 21:49 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox