From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] macb: get mac address from environment
Date: Sat, 11 Jul 2009 23:23:20 -0400 [thread overview]
Message-ID: <200907112323.21063.vapier@gentoo.org> (raw)
In-Reply-To: <h3bhmk$l6g$2@ger.gmane.org>
On Saturday 11 July 2009 22:27:36 Andrzej Wolski wrote:
> > On Saturday 11 July 2009 19:05:40 Andrzej Wolski wrote:
> >> This fix macb driver broken by commit
> >> 56b555a644f3cbb1b3929cb52b61d3ce483885f5
> >
> > what exactly broke ? drivers that are ported to NET_MULTI should *not*
> > be getting the mac from the environment. and from what i can see, the
> > macb driver is properly supporting the NET_MULTI setup.
> >
> > looks to me like the existing code is correct and your new proposed code
> > is not
>
> Hmm. Since pointed commit Ethernet just stopped to work, at least on my
> board similar to SAM9260EK. Maybe someone else can confirm it?
>
> Moreover, since that patch, when ethaddr is not set in the environment,
> and I set it from command line, I get this while trying to ping:
>
> U-Boot> ping 192.168.2.1
> macb0: link up, 100Mbps full-duplex (lpa: 0x45e1)
> *** ERROR: `ethaddr' not set
> macb0: link up, 100Mbps full-duplex (lpa: 0x45e1)
> ping failed; host 192.168.2.1 is not alive
do you have CONFIG_NET_MULTI defined ? if not, your board needs to switch
over to it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090711/2b70f245/attachment.pgp
next prev parent reply other threads:[~2009-07-12 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 23:05 [U-Boot] macb: get mac address from environment Andrzej Wolski
2009-07-12 1:09 ` Mike Frysinger
2009-07-12 2:27 ` Andrzej Wolski
2009-07-12 3:23 ` Mike Frysinger [this message]
2009-07-12 12:05 ` Andrzej Wolski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907112323.21063.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox