From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support
Date: Sun, 12 Jul 2009 18:07:27 +0200 [thread overview]
Message-ID: <20090712160727.GC21651@game.jcrosoft.org> (raw)
In-Reply-To: <20090712155407.70461832E416@gemini.denx.de>
On 17:54 Sun 12 Jul , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090712151534.GF7218@game.jcrosoft.org> you wrote:
> >
> > > > > +#undef CONFIG_CMD_FLASH
> > > > > +#define CONFIG_SYS_NO_FLASH /* Declare no flash (NOR/SPI) */
> > > > please move this 2
> > > > > +
> > > > > +#include <config_cmd_default.h>
> > > > > +#define CONFIG_CMD_AUTOSCRIPT
> > > > > +#define CONFIG_CMD_DHCP
> > > > > +#define CONFIG_CMD_ENV
> > > > > +#define CONFIG_CMD_FAT
> > > > > +#define CONFIG_CMD_NAND
> > > > > +#define CONFIG_CMD_PING
> > > > > +#define CONFIG_CMD_USB
> > > > here
> > >
> > > Why?
> > how this suppose to work?
> > you undef the CMD_FLASH et redefine it from the default?
>
> Good. It would be nice if you added such an explanation to your
> comment, so people understand why you are making such requests.
> Otherwise they might assume you just had to make any comment.
ok it was too obvious for me
Best Regards,
J.
next prev parent reply other threads:[~2009-07-12 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 15:50 [U-Boot] [PATCH 1/2][repost] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root Prafulla Wadaskar
2009-07-10 11:15 ` Michael Trimarchi
2009-07-11 9:39 ` Remy Bohmer
2009-07-11 13:24 ` Michael Trimarchi
2009-07-10 15:50 ` [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support Prafulla Wadaskar
2009-07-12 12:51 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-12 14:37 ` Wolfgang Denk
2009-07-12 15:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-12 15:54 ` Wolfgang Denk
2009-07-12 16:07 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-13 6:06 ` Prafulla Wadaskar
2009-07-13 7:54 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090712160727.GC21651@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox