From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 13 Jul 2009 09:54:34 +0200 Subject: [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DDF268D0@SC-VEXCH1.marvell.com> References: <73173D32E9439E4ABB5151606C3E19E202DDF268D0@SC-VEXCH1.marvell.com> Message-ID: <200907130954.34646.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 13 July 2009 08:06:00 Prafulla Wadaskar wrote: > > On 17:54 Sun 12 Jul , Wolfgang Denk wrote: > > > Dear Jean-Christophe PLAGNIOL-VILLARD, > > > > > > In message <20090712151534.GF7218@game.jcrosoft.org> you wrote: > > > > > > > +#undef CONFIG_CMD_FLASH > > Dear Jean > I can define this line below > > > > > > > > +#define CONFIG_SYS_NO_FLASH /* > > But I can't define this line below since CONFIG_CMD_IMLS is defined in > config_cmd_default.h under ifndef condition, then I will have to undef it > again. Pls suggest?? Yes, it seems that config_cmd_default needs some cleanup here. It originates to a time where NOR-FLASH was present on all boards. This is not the case any more. Something like this would be a first step (yes I know, the list is now not alphabetically sorted any more): diff --git a/include/config_cmd_default.h b/include/config_cmd_default.h index 0376e44..4990839 100644 --- a/include/config_cmd_default.h +++ b/include/config_cmd_default.h @@ -21,10 +21,10 @@ #define CONFIG_CMD_CONSOLE /* coninfo */ #define CONFIG_CMD_ECHO /* echo arguments */ #define CONFIG_CMD_SAVEENV /* saveenv */ -#define CONFIG_CMD_FLASH /* flinfo, erase, protect */ #define CONFIG_CMD_FPGA /* FPGA configuration Support */ #define CONFIG_CMD_IMI /* iminfo */ #ifndef CONFIG_SYS_NO_FLASH +#define CONFIG_CMD_FLASH /* flinfo, erase, protect */ #define CONFIG_CMD_IMLS /* List all found images */ #endif #define CONFIG_CMD_ITEST /* Integer (and string) test */ > Secondly, > I think config_cmd_default.h need be tuned for its better usability. > FLASH/FPGA/NET/SETGETDCR/IMLS are board specific, should be removed. > I know the impact will be to update all other configs which are using it. Full Ack. > Thirdly, > On some of Embedded systems, where memory footprint is a very critical > issue, we need to bring down u-boot binary size as small as possible. With > this reference using config_cmd_default.h will be problematic. For this I > think- > we should add one more configuration like CONFIG_SMALL_IMAGE to generate > smallest image u-boot binary. This is my requirement for some of board. > What do you think to make it generic ? > > In brief, > I am not enjoying using this file :-( > I prefer it should be more generic. > I wish NOT to use this file, shall I ? Again, I don't think its mandatory to use this file. I know that Jean- Christophe asked you to include it, but I personally don't think it has to be done. Jean-Christophe is on vacation for 1 week. So unfortunately not much will happen in the ARM repository in the meantime. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================