From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 13 Jul 2009 10:57:43 +0200
Subject: [U-Boot] [PATCH v2] ppc4xx: Add GDsys CompactCenter board
	support.
In-Reply-To: <1247474158-21162-1-git-send-email-eibach@gdsys.de>
References: <1247474158-21162-1-git-send-email-eibach@gdsys.de>
Message-ID: <200907131057.43061.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dirk,

On Monday 13 July 2009 10:35:58 Dirk Eibach wrote:
> diff --git a/board/gdsys/compactcenter/compactcenter.c
> b/board/gdsys/compactcenter/compactcenter.c new file mode 100644
> index 0000000..9f1e49d
> --- /dev/null
> +++ b/board/gdsys/compactcenter/compactcenter.c

<snip>

> +int get_cpu_num(void)
> +{
> +	int cpu = NA_OR_UNKNOWN_CPU;
> +
> +	return cpu;
> +}

Do you really need this function?

<snip>

> +#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
> +void ft_board_setup(void *blob, bd_t *bd)
> +{

Please check the latest version of this code in canyonlands.c. It's now using 
the 4xx common __ft_board_setup() function. Please move to this version as 
well.

<snip>

> +++ b/include/configs/compactcenter.h
> @@ -0,0 +1,495 @@
> +/*
> + * (C) Copyright 2009
> + * Dirk Eibach,  Guntermann & Drunck GmbH, eibach at gdsys.de
> + *
> + * Based on include/configs/canyonlands.h
> + * (C) Copyright 2008
> + * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +/*
> + * compactcenter.h - configuration for CompactCenter (460EX)
> + */
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +/*
> + * High Level Configuration Options
> + */
> +/*
> + * This config file is used for Canyonlands and DevCon-Center

Canyonlands?

<snip>

> +/*
> + * PPC4xx GPIO Configuration
> + */
> +/* 460EX: Use USB configuration */
> +#define CONFIG_SYS_4xx_GPIO_TABLE { \
> +/* Out		Alternate1	Alternate2	Alternate3 */ \
> +{ \
> +/* GPIO Core 0 */ \
> +/* GPIO0	GMC1TxD(0)	USB2HostD(0) */ \
> +{GPIO0_BASE, GPIO_BI , GPIO_ALT1, GPIO_OUT_0}, \

I prefer to not split the too long lines in this CONFIG_SYS_4xx_GPIO_TABLE 
macro. I know that the resulting lines are > 80 chars, but it really is *much* 
better readable and maintainable this way.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================