From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 3/3] 83xx, kmeter1: added NAND support
Date: Mon, 13 Jul 2009 11:57:33 +0200 [thread overview]
Message-ID: <200907131157.34023.sr@denx.de> (raw)
In-Reply-To: <4A5B0483.3060407@denx.de>
On Monday 13 July 2009 11:55:15 Heiko Schocher wrote:
> >> +#include <common.h>
> >> +
> >> +#if defined(CONFIG_CMD_NAND)
> >
> > This #if shouldn't be necessary.
>
> Hmm.. keymile has per default deactivated NAND support on this board,
> so I think it is necessary (or I make this dependence in the board
> makefile ...)
If some board variants don't enable NAND support, this file should not be
compiled then. This should be done via the Makefile. So just set
CONFIG_NAND_KMETER1 in the board config header when NAND really is enabled.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-07-13 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 8:19 [U-Boot] [PATCHv2 3/3] 83xx, kmeter1: added NAND support Heiko Schocher
2009-07-13 9:20 ` Stefan Roese
2009-07-13 9:55 ` Heiko Schocher
2009-07-13 9:57 ` Stefan Roese [this message]
2009-07-13 10:15 ` [U-Boot] [PATCHv3 " Heiko Schocher
2009-07-16 19:35 ` Scott Wood
2009-07-17 5:05 ` Heiko Schocher
2009-07-17 15:36 ` Scott Wood
2009-07-18 8:43 ` Heiko Schocher
2009-07-21 15:13 ` [U-Boot] [PATCHv4 " Heiko Schocher
2009-08-06 22:08 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907131157.34023.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox