public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ppc4xx: Add GDsys CompactCenter board support.
Date: Wed, 15 Jul 2009 11:16:33 +0200	[thread overview]
Message-ID: <200907151116.33700.sr@denx.de> (raw)
In-Reply-To: <48D3D52125C49B43AE880038E2E5314B025D10@SRV101.gdsys.de>

On Wednesday 15 July 2009 09:28:58 Eibach, Dirk wrote:
> > Please check the latest version of this code in
> > canyonlands.c. It's now using the 4xx common
> > __ft_board_setup() function. Please move to this version as well.
>
> This code in canyonlands.c does not work for me:
>
> void ft_board_setup(void *blob, bd_t *bd)
> {
> 	u32 val[4];
> 	int rc;
>
> 	__ft_board_setup(blob, bd);
>
> 	/* Fixup NOR mapping */
> 	val[0] = CONFIG_SYS_NOR_CS;		/* chip select number */
> 	val[1] = 0;				/* always 0 */
> 	val[2] = CONFIG_SYS_FLASH_BASE_PHYS_L;		/* we fixed up
> this address */
> 	val[3] = gd->bd->bi_flashsize;
> 	rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
> 				  val, sizeof(val), 1);
>
> __ft_board_setup() sets the property "ranges", with an entry for every
> member of EBC_NUM_BANKS.
> Then the so called "fixup" happens and the property "ranges" is set
> again, this time with only one entry (for the nor flash). All other
> entries are lost.

I see. I didn't spot this problem in the original patch. Thanks for catching.

It shouldn't be too hard to fix this problem by reading the complete ranges 
array back and patching only the first entry and re-writing ranges again.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-07-15  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  8:35 [U-Boot] [PATCH v2] ppc4xx: Add GDsys CompactCenter board support Dirk Eibach
2009-07-13  8:57 ` Stefan Roese
2009-07-15  7:28   ` Eibach, Dirk
2009-07-15  9:16     ` Stefan Roese [this message]
2009-07-15  9:24       ` Felix Radensky
2009-07-15  9:28         ` Eibach, Dirk
2009-07-20  8:44         ` Stefan Roese
2009-07-21  8:05           ` Felix Radensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907151116.33700.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox