public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add "cpu_config" command for PPC4xx bootstrap configuration
Date: Fri, 17 Jul 2009 13:13:37 +0200	[thread overview]
Message-ID: <200907171313.37259.sr@denx.de> (raw)
In-Reply-To: <20090717104501.49573832E416@gemini.denx.de>

Hi Wolfgang,

On Friday 17 July 2009 12:45:01 Wolfgang Denk wrote:
> > => cpu_config
> > Available configurations:
> >  600-nor         - NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100
> >  600-nand        - NAND CPU: 600 PLB: 200 OPB: 100 EBC: 100
> >  800-nor         - NOR  CPU: 800 PLB: 200 OPB: 100 EBC: 100
> >  800-nand        - NAND CPU: 800 PLB: 200 OPB: 100 EBC: 100
> >  1000-nor        - NOR  CPU:1000 PLB: 200 OPB: 100 EBC: 100
> >  1000-nand       - NAND CPU:1000 PLB: 200 OPB: 100 EBC: 100
> >  1066-nor        - NOR  CPU:1066 PLB: 266 OPB:  88 EBC:  88
> >  1066-nand       - NAND CPU:1066 PLB: 266 OPB:  88 EBC:  88
>
> Why are the lines indented by one space?

It was this way in the original bootstrap version. I can remove it if you 
prefer.

> Would it be possible to also mark the current setting in this output?
> Like printing an asterisk befor or after it?

No. Currently the implementation only checks strings and has no idea of 
frequencies. Also, not only PLL frequencies are configured in this I2C 
bootstrap EEPROM but also boot-location (NOR, NAND, PCI) and other things. So 
it's really not trivial to find/search the current configuration in this 
table.

Since 4xx prints the speed's in the bootlog, it shouldn't be too hard to find 
the current setting there (if necessary).

> > +struct ppc4xx_config ppc4xx_config_val[] = {
> > +	{ "600-nor", "NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100",
> > +	  {
> > +		  0x86, 0x80, 0xce, 0x1f, 0x79, 0x80, 0x00, 0xa0,
> > +		  0x40, 0x08, 0x23, 0x50, 0x0d, 0x05, 0x00, 0x00
> > +	  } },
>
> Indentation by TAB, please.

Ups. Will fix. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-07-17 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17  9:26 [U-Boot] [PATCH] Add "cpu_config" command for PPC4xx bootstrap configuration Stefan Roese
2009-07-17  9:32 ` Stefan Roese
2009-07-17  9:51   ` Eibach, Dirk
2009-07-17 10:45 ` Wolfgang Denk
2009-07-17 11:13   ` Stefan Roese [this message]
2009-07-17 11:20     ` Wolfgang Denk
2009-07-17 11:26       ` Stefan Roese
2009-07-17 11:40         ` Wolfgang Denk
2009-07-17 11:46           ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907171313.37259.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox