public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot][PATCH][1 of 2] AMCC ppc4xx /PLLOUTB/CPU clock/ Default bootstrap options A, B, C, D
Date: Fri, 17 Jul 2009 15:10:37 +0200	[thread overview]
Message-ID: <200907171510.37590.sr@denx.de> (raw)
In-Reply-To: <89f945070907170541q507eca3cq4d4835bfb0a1c56f@mail.gmail.com>

Hi Rupjyoti Sarmah,

On Friday 17 July 2009 14:41:21 Rupjyoti Sarmah wrote:
> Unstable 440EPx operation due to default bootsrtap options settings.
> The 440EPx fixed bootstrap options A,B,C,D sets PLL FWDVA
> to a value 1 that results PLLOUTB being greater than the CPU clock
> frequency. This results unstable 440EPx operation causing hang
> conditions.
>
> This is a patch fixing this problem. The patch touches two files
> speed.c and cpu_init.c.
>
> Signed off by  Rupjyoti Sarmah < rsarmah@amcc.com > from Applied Micro

This patch is unusable, I'm afraid. First it can't be applied since most 
likely your mailer corrupted the output (see below) and 2nd you are removing 
the complete files and adding them back below. The patch should only include 
the real changes.

Please fix and resubmit. If possible use "git send-email" for this.

Thanks.

> ------------------------------
>
>
> diff -uNr u-boot-2009.06/cpu/ppc4xx/cpu_init.c
> u-boot-2009.06.1/cpu/ppc4xx/cpu_init.c
>
> --- u-boot-2009.06/cpu/ppc4xx/cpu_init.c 2009-06-14 12:30:39.000000000
> -0700
>
> +++ u-boot-2009.06.1/cpu/ppc4xx/cpu_init.c 2009-04-30 11:00:40.000000000
> -0700
>
> @@ -1,337 +1,462 @@
>
> -/*
>
> - * (C) Copyright 2000-2007
>
> - * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
>
> - *
>
> - * See file CREDITS for list of people who contributed to this
>

As you see, an empty line was added for each of your lines. Please fix.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-07-17 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 12:41 [U-Boot] [U-boot][PATCH][1 of 2] AMCC ppc4xx /PLLOUTB/CPU clock/ Default bootstrap options A, B, C, D Rupjyoti Sarmah
2009-07-17 13:10 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907171510.37590.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox