From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Fri, 17 Jul 2009 22:14:54 +0200 Subject: [U-Boot] [PATCH] cmd_mmc: make curr_device static In-Reply-To: <1245029722-14514-1-git-send-email-vapier@gentoo.org> References: <1245029722-14514-1-git-send-email-vapier@gentoo.org> Message-ID: <20090717201454.8FC21832E416@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1245029722-14514-1-git-send-email-vapier@gentoo.org> you wrote: > The curr_device variable isn't used outside of cmd_mmc, so mark it static > to avoid conflicts with other pieces of code (like sata which also exports > a curr_device). Otherwise we end up with stuff like: > common/libcommon.a(cmd_sata.o):(.data.curr_device+0x0): > multiple definition of `curr_device' > common/libcommon.a(cmd_mmc.o):(.data.curr_device+0x0): first defined here > > Signed-off-by: Mike Frysinger > --- > common/cmd_mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You're dead, Jim. -- McCoy, "Amok Time", stardate 3372.7