public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add inverted clock polarity support for Atmel LCD driver
Date: Sat, 18 Jul 2009 22:58:16 +0200	[thread overview]
Message-ID: <20090718205816.GC16951@game.jcrosoft.org> (raw)
In-Reply-To: <200907151856.24888.dinuxbg@gmail.com>

On 18:56 Wed 15 Jul     , Dimitar Dimitrov wrote:
> This is my third try for Olimex SAM9-L9260/61 board support patches. 
> 
> Here follows the first patch.
> ---
> 
> Boards utilizing the Atmel LCD driver can now specify that the LCD clock must
> be inverted by defining the macro CONFIG_LCD_INVERTED_CLOCK.
> ---
>  README                      |    5 +++++
>  drivers/video/atmel_lcdfb.c |    3 +++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/README b/README
> index de700bd..d7c0afe 100644
> --- a/README
> +++ b/README
> @@ -1063,6 +1063,11 @@ The following options need to be configured:
>  		Normally display is black on white background; define
>  		CONFIG_SYS_WHITE_ON_BLACK to get it inverted.
>  
> +		CONFIG_LCD_INVERTED_CLOCK
> +		Define this if your LCD needs inverted clock polarity. Note
> +		that this feature will work only if the selected LCD driver 
> +		and hardware controller support it.
> +
>  - Splash Screen Support: CONFIG_SPLASH_SCREEN
>  
>  		If this option is set, the environment is checked for
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index db86763..d3e988e 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -112,6 +112,9 @@ void lcd_ctrl_init(void *lcdbase)
>  
>  	value |= panel_info.vl_sync;
>  	value |= (panel_info.vl_bpix << 5);
> +#if defined(CONFIG_LCD_INVERTED_CLOCK)
> +	value |= ATMEL_LCDC_INVCLK_INVERTED;
> +#endif
NACK
	do this throught the struct via vl_sync as in linux

Best Regards,
J.

  parent reply	other threads:[~2009-07-18 20:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 15:56 [U-Boot] [PATCH] Add inverted clock polarity support for Atmel LCD driver Dimitar Dimitrov
2009-07-15 15:58 ` [U-Boot] [PATCH 02/03 v3] Add support for Olimex SAM9-L9261 SBC Dimitar Dimitrov
2009-07-18 21:09   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-15 16:00 ` [U-Boot] [PATCH 03/03 v3] Add support for Olimex SAM9-L9260 SBC Dimitar Dimitrov
2009-07-18 21:13   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 19:18 ` [U-Boot] [PATCH] Add inverted clock polarity support for Atmel LCD driver Anatolij Gustschin
2009-07-25 20:28   ` Anatolij Gustschin
2009-07-18 20:58 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-07-18 23:34   ` Anatolij Gustschin
2009-07-19  9:34     ` Jean-Christophe PLAGNIOL-VILLARD
2009-11-22 21:01 ` Wolfgang Denk
2009-11-24 19:47   ` Dimitar Dimitrov
2009-12-05  0:10     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090718205816.GC16951@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox