From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] CONFIG naming convetion
Date: Mon, 20 Jul 2009 10:02:26 +0200 [thread overview]
Message-ID: <20090720080226.GA2463@mail.gnudd.com> (raw)
In-Reply-To: <20090718222523.D4177832E416@gemini.denx.de>
>> > > I would think should be CONFIG_DRIVERS_PATA_BFIN
>> >
>> > I dosagree, the "DRIVERS" part is just added line noise.
>>
>> It's a name space - making sure it is differentiated from an option.
>
> Yeah, and we end up with variable names that cannot be used any more
> because they exceed the maximum line length.
What about "DRV" or even "D" if you insist? CONFIG_D_I2C_SOFT ?
I personally find the config files pretty unreadable. Options that
enable a driver should be different from those that select a
behaviour, in my opinion.
While people responsible for their board know all the stuff they
wrote, but when someone undergoes a more general code change several or
all config files must be checked. A driver namespace would help, in my
opionion.
/alessandro
next prev parent reply other threads:[~2009-07-20 8:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 11:03 [U-Boot] [RFC] CONFIG naming convetion Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 12:50 ` Wolfgang Denk
2009-07-18 13:05 ` Heiko Schocher
2009-07-18 14:48 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 17:33 ` Wolfgang Denk
2009-07-18 15:15 ` Robin Getz
2009-07-18 15:52 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 21:30 ` Robin Getz
2009-07-18 17:50 ` Wolfgang Denk
2009-07-18 21:13 ` Robin Getz
2009-07-18 22:25 ` Wolfgang Denk
2009-07-20 3:55 ` Robin Getz
2009-07-20 20:33 ` Wolfgang Denk
2009-07-21 15:59 ` Robin Getz
2009-07-20 8:02 ` Alessandro Rubini [this message]
2009-07-20 14:27 ` Wolfgang Denk
2009-07-19 5:54 ` Heiko Schocher
2009-07-18 18:56 ` Mike Frysinger
2009-07-18 19:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720080226.GA2463@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox