From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] arm nomadik: gpio and i2c
Date: Mon, 20 Jul 2009 10:09:55 +0200 [thread overview]
Message-ID: <20090720080955.GA2640@mail.gnudd.com> (raw)
In-Reply-To: <4A6422FC.6030508@invitel.hu>
> Agreed. So we need an gpio_core.c / .h which defines the following
> functions (just a proposal):
Yes.
> typedef struct gpio_adapter {
> int (*init_pin)(int pin);
> int (*set)(int pin, value);
> int (*get)(int pin);
> int (*dir)(int pin, int direction);
> int (*level)(int pin, int level);
> }
I don't understand the init_pin function, nor what "level" is.
Actually, even "dir" can be dropped: a get configures as input, a set
configures as output, the extra instruction is very little overhead.
But an alternate function configuration is definitely needed: everybody
has alternate functions associated to the pins. Just say "0" is gpio
and 1...n is SoC-specific.
So, are you going to write it? Or should someone else do that?
thanks
/alessandro
next prev parent reply other threads:[~2009-07-20 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 11:01 [U-Boot] [PATCH 0/2] arm nomadik: gpio and i2c Alessandro Rubini
2009-07-19 17:13 ` Wolfgang Denk
2009-07-20 7:55 ` Heiko Schocher
2009-07-20 8:09 ` Alessandro Rubini [this message]
2009-07-20 9:23 ` Heiko Schocher
2009-07-20 9:31 ` Alessandro Rubini
2009-07-20 9:48 ` Heiko Schocher
2009-07-20 15:14 ` Wolfgang Denk
2009-07-21 6:31 ` Heiko Schocher
2009-07-20 15:12 ` Wolfgang Denk
2009-07-21 6:11 ` Heiko Schocher
2009-07-21 7:19 ` Wolfgang Denk
2009-07-20 7:40 ` Heiko Schocher
2009-07-28 7:16 ` Daniel Gorsulowski
2009-07-28 9:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-28 10:25 ` Heiko Schocher
2009-07-28 10:55 ` Wolfgang Denk
2009-07-28 13:02 ` Heiko Schocher
2009-07-28 13:22 ` Wolfgang Denk
2009-07-28 13:49 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720080955.GA2640@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox