[U-Boot] [PATCH] ubi: help message correction

[U-Boot] [PATCH] ubi: help message correction

[Andrzej Wolski]

Fix incorrect information about size units.

Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
---
diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
index bbca389..d1653b1 100644
--- a/common/cmd_ubi.c
+++ b/common/cmd_ubi.c
@@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
  		" - Remove volume\n"
  	"[Legends]\n"
  	" volume: charater name\n"
-	" size: KiB, MiB, GiB, and bytes\n"
+	" size: hex value\n"
  	" type: s[tatic] or d[ynamic] (default=dynamic)"
  );

[U-Boot] [PATCH] ubi: help message correction

[Wolfgang Denk]

Dear Andrzej Wolski,

In message <h3bhhv$l6g$1@ger.gmane.org> you wrote:
> Fix incorrect information about size units.
> 
> Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
> ---
> diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
> index bbca389..d1653b1 100644
> --- a/common/cmd_ubi.c
> +++ b/common/cmd_ubi.c
> @@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
>   		" - Remove volume\n"
>   	"[Legends]\n"
>   	" volume: charater name\n"
> -	" size: KiB, MiB, GiB, and bytes\n"
> +	" size: hex value\n"
>   	" type: s[tatic] or d[ynamic] (default=dynamic)"
>   );

This is IMHO not a helpful help message.

First, it is reduncant, as all input in U-Boot is in hex  format.  So
why  repeat that information. And "size: value" - what does that tell
me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB,
bytes, blocks, or whatever?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt

[U-Boot] [PATCH] ubi: help message correction

[Andrzej Wolski]

> In message <h3bhhv$l6g$1@ger.gmane.org> you wrote:
>> Fix incorrect information about size units.
>>
>> Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
>> ---
>> diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
>> index bbca389..d1653b1 100644
>> --- a/common/cmd_ubi.c
>> +++ b/common/cmd_ubi.c
>> @@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
>>   		" - Remove volume\n"
>>   	"[Legends]\n"
>>   	" volume: charater name\n"
>> -	" size: KiB, MiB, GiB, and bytes\n"
>> +	" size: hex value\n"
>>   	" type: s[tatic] or d[ynamic] (default=dynamic)"
>>   );
> 
> This is IMHO not a helpful help message.
> 
> First, it is reduncant, as all input in U-Boot is in hex  format.  So
> why  repeat that information. And "size: value" - what does that tell
> me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB,
> bytes, blocks, or whatever?

This is size in bytes. Original message was probably based on Linux 
mtd-utils where size in KiB, MiB, etc. can be specified. This is not 
true in U-Boot where all input is in hex, so this message have to be 
corrected. If you think "hex value" is not helpful, can you suggest 
something better? Maybe just remove size entry?

Regards,
Andrzej Wolski

[U-Boot] [PATCH] ubi: help message correction

[Detlev Zundel]

Hi Andrzej,

>> In message <h3bhhv$l6g$1@ger.gmane.org> you wrote:
>>> Fix incorrect information about size units.
>>>
>>> Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
>>> ---
>>> diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
>>> index bbca389..d1653b1 100644
>>> --- a/common/cmd_ubi.c
>>> +++ b/common/cmd_ubi.c
>>> @@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
>>>   		" - Remove volume\n"
>>>   	"[Legends]\n"
>>>   	" volume: charater name\n"
>>> -	" size: KiB, MiB, GiB, and bytes\n"
>>> +	" size: hex value\n"
>>>   	" type: s[tatic] or d[ynamic] (default=dynamic)"
>>>   );
>> 
>> This is IMHO not a helpful help message.
>> 
>> First, it is reduncant, as all input in U-Boot is in hex  format.  So
>> why  repeat that information. And "size: value" - what does that tell
>> me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB,
>> bytes, blocks, or whatever?
>
> This is size in bytes. Original message was probably based on Linux 
> mtd-utils where size in KiB, MiB, etc. can be specified. This is not 
> true in U-Boot where all input is in hex, so this message have to be 
> corrected. If you think "hex value" is not helpful, can you suggest 
> something better? Maybe just remove size entry?

How about "size: specified in bytes"?

Cheers
  Detlev

-- 
I talk to planets baby
                                       -- Dave Wyndorf (Monstermagnet)
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

[U-Boot] [PATCH] ubi: help message correction

[Andrzej Wolski]

Fix incorrect information about size units and correct typo.

Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
---
diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
index 05893f5..54faac1 100644
--- a/common/cmd_ubi.c
+++ b/common/cmd_ubi.c
@@ -618,7 +618,7 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
  	"ubi remove[vol] volume"
  		" - Remove volume\n"
  	"[Legends]\n"
-	" volume: charater name\n"
-	" size: KiB, MiB, GiB, and bytes\n"
+	" volume: character name\n"
+	" size: specified in bytes\n"
  	" type: s[tatic] or d[ynamic] (default=dynamic)"
  );

----------------------------------------------------------------------
Bezp?atne konto? Otw?rz tutaj!
>> http://link.interia.pl/f225a

[U-Boot] [PATCH] ubi: help message correction

[Stefan Roese]

On Friday 17 July 2009 22:26:54 Andrzej Wolski wrote:
> Fix incorrect information about size units and correct typo.
>
> Signed-off-by: Andrzej Wolski <awolski@poczta.fm>

Patch didn't apply clean. I fixed this manually. So, applied to u-boot-ubi.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================