From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] arm nomadik: gpio and i2c
Date: Mon, 20 Jul 2009 11:31:02 +0200 [thread overview]
Message-ID: <20090720093102.GA4423@mail.gnudd.com> (raw)
In-Reply-To: <4A6437A7.40909@denx.de>
> what with deinit_pin(pin, function)? That would be in shape with init_pin()?
No, it's not clear what it is. I'd rename "init" to "setup", adding an AF
argument. So I can setup it as AF2, or as GPIO-OUT, or whatever.
> (There, we could also unset the marker, that this pin is no longer used
> for gpio ...)
No, I wouldn't like the marker. It's a boot loader, it shouldn't
overdo sanity checks. Most of the times it runs the same "bootcmd"
over and over. In the rare but important case it's a debugging tool, it
shouldn't force policy, in my opinion (I already have problems with the
kernel gpiolib, that doesn't let me fix mishaps at will).
> Also, a board can have more then one gpio adapter, how we address
> such a case?
As Wolfgang suggested, we don't. If atmel calls it PORTC-12 I have no
problem calling it gpio-76 by concatentating the ports as 0..31,
32..64, ... It's still better to have a gpio command than doing "mw
<addr> <val>" over and over.
In my old-fashioned way, it should be as simple as possible, but no simpler.
/alessandro
next prev parent reply other threads:[~2009-07-20 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 11:01 [U-Boot] [PATCH 0/2] arm nomadik: gpio and i2c Alessandro Rubini
2009-07-19 17:13 ` Wolfgang Denk
2009-07-20 7:55 ` Heiko Schocher
2009-07-20 8:09 ` Alessandro Rubini
2009-07-20 9:23 ` Heiko Schocher
2009-07-20 9:31 ` Alessandro Rubini [this message]
2009-07-20 9:48 ` Heiko Schocher
2009-07-20 15:14 ` Wolfgang Denk
2009-07-21 6:31 ` Heiko Schocher
2009-07-20 15:12 ` Wolfgang Denk
2009-07-21 6:11 ` Heiko Schocher
2009-07-21 7:19 ` Wolfgang Denk
2009-07-20 7:40 ` Heiko Schocher
2009-07-28 7:16 ` Daniel Gorsulowski
2009-07-28 9:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-28 10:25 ` Heiko Schocher
2009-07-28 10:55 ` Wolfgang Denk
2009-07-28 13:02 ` Heiko Schocher
2009-07-28 13:22 ` Wolfgang Denk
2009-07-28 13:49 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720093102.GA4423@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox