From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 20 Jul 2009 17:05:38 +0200 Subject: [U-Boot] [PATCH 2/3] tools: mkimage (type=kwbimage) kirkwood boot image support In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DE09CE02@SC-VEXCH1.marvell.com> References: <20090718220240.2D2DF832E416@gemini.denx.de>, <73173D32E9439E4ABB5151606C3E19E202DDF272E2@SC-VEXCH1.marvell.com> <73173D32E9439E4ABB5151606C3E19E202DE09CE02@SC-VEXCH1.marvell.com> Message-ID: <20090720150538.CB74A832E416@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Prafulla Wadaskar, In message <73173D32E9439E4ABB5151606C3E19E202DE09CE02@SC-VEXCH1.marvell.com> you wrote: > > > > diff --git a/tools/kwbimage.h b/tools/kwbimage.h new file > > mode 100644 > > > index 0000000..c54b701 > > > --- /dev/null > > > +++ b/tools/kwbimage.h > > > ... > > > +/* typedefs */ > > > +typedef char s8; > > > +typedef unsigned char u8; > > > + > > > +typedef int s32; > > > +typedef unsigned int u32; > > > + > > > +typedef short s16; > > > +typedef unsigned short u16; > > > + > > > +typedef long s64; > > > +typedef unsigned long u64; > > > > Please get rid of these. > > Hi Wolfgang > Any suggestions for this? > I could used or but these typedefs are ifdefe= > d > under __KERNEL_STRICT_NAMES and __KERNEL__. > I don't wish to redefine or disturb them for kwbimage support This is code running on the host, so please use ISO C99 standard types: #include and use int8_t, int16_t, int32_t, int64_t resp. uint8_t, uint16_t, uint32_t, uint64_t. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Ordnung ist die Lust der Vernunft, aber Unordnung die Wonne der Phantasie - Paul Claudel