From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU
Date: Mon, 20 Jul 2009 17:40:30 +0200 [thread overview]
Message-ID: <20090720174030.24e65e12@surf> (raw)
In-Reply-To: <1247755963.19222.811.camel@localhost.localdomain>
Le Thu, 16 Jul 2009 09:52:43 -0500,
Peter Tyser <ptyser@xes-inc.com> a ?crit :
> I don't have the final say here, I'm just giving my opinion. If it
> was possible to clean up, the best way in my would be to fix your
> board (ie this patch), then send a separate follow-up patch fixing
> other boards. I don't think its too big of a deal either way.
Including <common.h> in a include/configs/ configuration file doesn't
seem to work, unfortunately.
> > +#########################################################################
> > diff --git a/board/calao/usb-a9263/config.mk
> > b/board/calao/usb-a9263/config.mk new file mode 100644
> > index 0000000..ff2cfd1
> > --- /dev/null
> > +++ b/board/calao/usb-a9263/config.mk
> > @@ -0,0 +1 @@
> > +TEXT_BASE = 0x23f00000
>
> You should add a copyright header of some sort to config.mk.
In a one-line file, which just contains a factual definition ?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2009-07-20 15:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 12:07 [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU Thomas Petazzoni
2009-07-08 21:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-15 14:35 ` Thomas Petazzoni
2009-07-15 14:51 ` Peter Tyser
2009-07-16 11:39 ` Thomas Petazzoni
2009-07-16 14:52 ` Peter Tyser
2009-07-20 15:40 ` Thomas Petazzoni [this message]
2009-07-20 15:51 ` Peter Tyser
2009-07-17 19:41 ` Wolfgang Denk
2009-07-20 15:42 ` Thomas Petazzoni
2009-07-20 21:11 ` Wolfgang Denk
2009-07-22 15:30 ` Thomas Petazzoni
2009-07-22 15:57 ` Peter Tyser
2009-07-22 16:04 ` Thomas Petazzoni
2009-07-22 16:10 ` Peter Tyser
2009-07-22 16:05 ` Albin Tonnerre
2009-07-23 22:35 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:45 ` Wolfgang Denk
2009-07-23 22:53 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-24 5:38 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720174030.24e65e12@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox