From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 20 Jul 2009 17:40:30 +0200 Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU In-Reply-To: <1247755963.19222.811.camel@localhost.localdomain> References: <20090701140758.28d7438a@surf> <20090708214253.GD26464@game.jcrosoft.org> <20090715163557.08b58415@surf> <1247669487.16908.52.camel@localhost.localdomain> <20090716133929.33a9b77a@surf> <1247755963.19222.811.camel@localhost.localdomain> Message-ID: <20090720174030.24e65e12@surf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le Thu, 16 Jul 2009 09:52:43 -0500, Peter Tyser a ?crit : > I don't have the final say here, I'm just giving my opinion. If it > was possible to clean up, the best way in my would be to fix your > board (ie this patch), then send a separate follow-up patch fixing > other boards. I don't think its too big of a deal either way. Including in a include/configs/ configuration file doesn't seem to work, unfortunately. > > +######################################################################### > > diff --git a/board/calao/usb-a9263/config.mk > > b/board/calao/usb-a9263/config.mk new file mode 100644 > > index 0000000..ff2cfd1 > > --- /dev/null > > +++ b/board/calao/usb-a9263/config.mk > > @@ -0,0 +1 @@ > > +TEXT_BASE = 0x23f00000 > > You should add a copyright header of some sort to config.mk. In a one-line file, which just contains a factual definition ? Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com