From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 20 Jul 2009 17:42:20 +0200 Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU In-Reply-To: <20090717194143.083AC832E416@gemini.denx.de> References: <20090701140758.28d7438a@surf> <20090708214253.GD26464@game.jcrosoft.org> <20090715163557.08b58415@surf> <20090717194143.083AC832E416@gemini.denx.de> Message-ID: <20090720174220.1800dcaa@surf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le Fri, 17 Jul 2009 21:41:43 +0200, Wolfgang Denk a ?crit : > Entries to maintainers is missing. Yes, it was missing in the initial version of my patch, but further versions got it added, thanks to other people review. > > +int dram_init(void) > > +{ > > + gd->bd->bi_dram[0].start = PHYS_SDRAM; > > + gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE; > > + return 0; > > +} > > Any specific reason for not using autosizing and testing via > get_ram_size() ? The initial reason is that the code for this board is taken from the Atmel boards code, which doesn't use get_ram_size(). However, my board has a fixed RAM size, so in that case, is it still useful to use get_ram_size() ? > Line too long. Please fix globally. Thanks, will do. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com