[U-Boot] [PATCH] lcd.h: define extern vidinfo_t for all cases

[U-Boot] [PATCH] lcd.h: define extern vidinfo_t for all cases

[Alessandro Rubini]

From: Alessandro Rubini <rubini@gnudd.com>

include/lcd.h has different vidinfo for different platforms,
and several extern declaration, but one for the default case was
missing. This makes them a single extern declaration for everyone.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
---
 include/lcd.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/lcd.h b/include/lcd.h
index f054cac..8048419 100644
--- a/include/lcd.h
+++ b/include/lcd.h
@@ -75,8 +75,6 @@ typedef struct vidinfo {
 	u_char	vl_wbf;		/* Wait between frames */
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #elif defined CONFIG_PXA250
 /*
  * PXA LCD DMA descriptor
@@ -146,8 +144,6 @@ typedef struct vidinfo {
 	struct	pxafb_info pxa;
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #elif defined(CONFIG_ATMEL_LCD)
 
 typedef struct vidinfo {
@@ -173,8 +169,6 @@ typedef struct vidinfo {
 	u_long	mmio;		/* Memory mapped registers */
 } vidinfo_t;
 
-extern vidinfo_t panel_info;
-
 #else
 
 typedef struct vidinfo {
@@ -190,6 +184,8 @@ typedef struct vidinfo {
 
 #endif /* CONFIG_MPC823, CONFIG_PXA250 or CONFIG_MCC200 or CONFIG_ATMEL_LCD */
 
+extern vidinfo_t panel_info;
+
 /* Video functions */
 
 #if defined(CONFIG_RBC823)
-- 
1.6.0.2

[U-Boot] [PATCH] lcd.h: define extern vidinfo_t for all cases

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:09 Tue 21 Jul     , Alessandro Rubini wrote:
> From: Alessandro Rubini <rubini@gnudd.com>
> 
> include/lcd.h has different vidinfo for different platforms,
> and several extern declaration, but one for the default case was
> missing. This makes them a single extern declaration for everyone.
> 
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> ---
>  include/lcd.h |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

[U-Boot] [PATCH] lcd.h: define extern vidinfo_t for all cases

[Anatolij Gustschin]

Alessandro Rubini wrote:
> From: Alessandro Rubini <rubini@gnudd.com>
> 
> include/lcd.h has different vidinfo for different platforms,
> and several extern declaration, but one for the default case was
> missing. This makes them a single extern declaration for everyone.
> 
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> ---
>  include/lcd.h |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)

Applied to u-boot-video. Thanks!

Best regards,
Anatolij