From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 21 Jul 2009 17:11:05 +0200
Subject: [U-Boot] [PATCH] 86xx: Report which "bank" of NOR flash we are
	booting from on MPC8641HPCN
In-Reply-To: <20090721150556.DC74C832E416@gemini.denx.de>
References: <1248187311-5943-1-git-send-email-galak@kernel.crashing.org>
	<20090721150556.DC74C832E416@gemini.denx.de>
Message-ID: <200907211711.05122.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 21 July 2009 17:05:56 Wolfgang Denk wrote:
> >  int checkboard(void)
> >  {
> > -	printf ("Board: MPC8641HPCN, System ID: 0x%02x, "
> > -		"System Version: 0x%02x, FPGA Version: 0x%02x\n",
> > +	u8 vboot;
> > +
> > +	printf ("Board: MPC8641HPCN, Sys ID: 0x%02x, "
> > +		"Sys Ver: 0x%02x, FPGA Ver: 0x%02x, ",
> >  		in8(PIXIS_BASE + PIXIS_ID), in8(PIXIS_BASE + PIXIS_VER),
> >  		in8(PIXIS_BASE + PIXIS_PVER));
> > +
> > +	vboot = in8(PIXIS_BASE + 0x16);
>
> --------------------------------^^^^^^^
>
> Maybe you can use a symbolic name here, too?
>
> > +	if ((vboot >> 7) & 0x1)
>
> 	if (vboot & 0x80) ???
>
> > +		printf ("vBank: %d\n", ((vboot >> 6) & 0x1));
>
> 		printf ("vBank: %d\n", !!(vboot & 0x40)); ???
>
> And eventually you can even come up with symbolic names for the magic
> numbers 0x80 and 0x40 ?

And please switch from using in8() to in_8().

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================