public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lennert Buytenhek <buytenh@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support
Date: Tue, 21 Jul 2009 12:32:04 -0700	[thread overview]
Message-ID: <20090721193203.GW25486@server.marvell.com> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202DDF27694@SC-VEXCH1.marvell.com>

On Tue, Jul 21, 2009 at 12:01:49PM -0700, Prafulla Wadaskar wrote:

> > >>> By default Auto Negotiation is enabled for interface speed but on 
> > >>> some platforms like RD6281A it does not work.
> > >>> If you want to forced program it to desired speed, this 
> > patch helps-
> > >>>
> > >>> Through this patch Auto negotiation can be disabled and desired 
> > >>> interface speed can be configured
> > >>>
> > >>> This patch is tested on RD6281A Kirkwood board
> > >>>
> > >>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > >>> ---
> > >>>       
> > >> Applied to net repo.
> > >>     
> > >
> > > Please reconsider - see my previous comment. [Sorry it came 
> > so late.]
> > >
> > > Best regards,
> > >
> > > Wolfgang Denk
> > >
> > >   
> > No problem.  I assumed it was a chip erratum but should have 
> > looked closer.  Let's wait for Prafulla's response.
>
> Ideally auto negotiation must work, but :-(
> I don't think this is not for SoC/PHY erratum since both are working
> okay with other boards.
> Only the difference is on RD6281A the multichip mode is used,
> I am discovering why it is not working.

Isn't it just because on the RD6281A, the first ethernet MAC of the
CPU is connected to an ethernet switch chip instead of an ethernet PHY,
and therefore there is no negotiation to be done?  (The second MAC
is connected to a PHY directly, so that one should just use autoneg.)

Even on the RD6281Z, we should just force the ethernet MAC to a
fixed speed/duplex, since even though PHY polling might work there,
we'll be talking to the PHY corresponding to the first switch port,
which means that you might not be able to tftp from the second switch
port or so if there's nothing plugged into the first one.

FWIW, the linux kernel port also forces 1000/full on the CPU MACs where
a switch chip is connected.  On those CPU MACs where there is a switch
chip connected, the (R)(G)MII interface becomes purely a bus to
transport packets into and out of the crossbar, one that is always up.

  parent reply	other threads:[~2009-07-21 19:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 15:27 [U-Boot] [PATCH 1/6] include/config_cmd_default.h cleanup Prafulla Wadaskar
2009-07-16 15:28 ` [U-Boot] [PATCH v7 2/6] Marvell Sheevaplug Board support Prafulla Wadaskar
2009-07-16 15:28   ` [U-Boot] [PATCH v13 3/6] Marvell MV88F6281GTW_GE " Prafulla Wadaskar
2009-07-16 15:28     ` [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support Prafulla Wadaskar
2009-07-16 15:28       ` [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support Prafulla Wadaskar
2009-07-16 14:45         ` Dieter Kiermaier
2009-07-16 15:45           ` Prafulla Wadaskar
2009-07-16 15:28         ` [U-Boot] [PATCH 6/6] Marvell RD6281A Board support Prafulla Wadaskar
2009-07-18 18:48           ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-19  4:50             ` Prafulla Wadaskar
2009-07-18 18:43         ` [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support Jean-Christophe PLAGNIOL-VILLARD
2009-07-19  4:54           ` Prafulla Wadaskar
2009-07-21  6:22           ` Ben Warren
2009-07-21  7:39             ` Wolfgang Denk
2009-07-21 19:08             ` Prafulla Wadaskar
2009-07-21  6:51         ` Ben Warren
2009-07-21  7:41           ` Wolfgang Denk
2009-07-21  7:43             ` Ben Warren
2009-07-21 19:01               ` Prafulla Wadaskar
2009-07-21 19:20                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-21 19:32                 ` Lennert Buytenhek [this message]
2009-07-21  6:52       ` [U-Boot] [PATCH 4/6] net: phy: bugfixes: mv88E61xx multichip addressing support Ben Warren
2009-08-10  8:09       ` Wolfgang Denk
2009-08-10  8:25         ` Wolfgang Denk
2009-08-10  8:59           ` Prafulla Wadaskar
2009-08-10  8:31         ` Prafulla Wadaskar
2009-07-18 18:40     ` [U-Boot] [PATCH v13 3/6] Marvell MV88F6281GTW_GE Board support Jean-Christophe PLAGNIOL-VILLARD
2009-07-19  4:55       ` Prafulla Wadaskar
2009-07-16 15:32   ` [U-Boot] [PATCH 6/6][repost] Marvell RD6281A " Prafulla Wadaskar
2009-07-22 22:15     ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-18 17:41   ` [U-Boot] [PATCH v7 2/6] Marvell Sheevaplug " Jean-Christophe PLAGNIOL-VILLARD
2009-07-19  4:56     ` Prafulla Wadaskar
2009-07-17 21:26 ` [U-Boot] [PATCH 1/6] include/config_cmd_default.h cleanup Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721193203.GW25486@server.marvell.com \
    --to=buytenh@marvell.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox