public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
@ 2009-07-21 10:22 Matthias Fuchs
  2009-07-22  7:26 ` Wolfgang Denk
  0 siblings, 1 reply; 18+ messages in thread
From: Matthias Fuchs @ 2009-07-21 10:22 UTC (permalink / raw)
  To: u-boot

patch v2:
	- coding style cleanup
	- added CONFIG_PHY1_ADDR
patch v3:
	- refactor PLL reconfiguration code
	- beautify some one-line-functions
patch v4:
	- remove 'sbe' command
	- add CONFIG_CMD_CHIP_CONFIG support
	- use ppc4xx_gpio struct for GPIO access
	- use set/clrbits_be32 to modify GPIO registers
	- add CPLD register struct
patch v5:
	- add patch history to commit message

Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
---
 MAINTAINERS                      |    1 +
 MAKEALL                          |    1 +
 Makefile                         |    3 +
 board/esd/pmc405de/Makefile      |   53 ++++
 board/esd/pmc405de/chip_config.c |   47 ++++
 board/esd/pmc405de/config.mk     |   23 ++
 board/esd/pmc405de/pmc405de.c    |  521 ++++++++++++++++++++++++++++++++++++++
 board/esd/pmc405de/u-boot.lds    |  133 ++++++++++
 include/configs/PMC405DE.h       |  378 +++++++++++++++++++++++++++
 9 files changed, 1160 insertions(+), 0 deletions(-)
 create mode 100644 board/esd/pmc405de/Makefile
 create mode 100644 board/esd/pmc405de/chip_config.c
 create mode 100644 board/esd/pmc405de/config.mk
 create mode 100644 board/esd/pmc405de/pmc405de.c
 create mode 100644 board/esd/pmc405de/u-boot.lds
 create mode 100644 include/configs/PMC405DE.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 575a7ec..484040c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -171,6 +171,7 @@ Matthias Fuchs <matthias.fuchs@esd-electronics.com>
 	PCI405		PPC405GP
 	PLU405		PPC405EP
 	PMC405		PPC405GP
+	PMC405DE	PPC405EP
 	PMC440		PPC440EPx
 	VOH405		PPC405EP
 	VOM405		PPC405EP
diff --git a/MAKEALL b/MAKEALL
index 020ff73..f36a5fd 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -237,6 +237,7 @@ LIST_4xx="		\
 	PIP405		\
 	PLU405		\
 	PMC405		\
+	PMC405DE	\
 	PMC440		\
 	PPChameleonEVB	\
 	quad100hd	\
diff --git a/Makefile b/Makefile
index 090e645..a5d397b 100644
--- a/Makefile
+++ b/Makefile
@@ -1492,6 +1492,9 @@ PLU405_config:	unconfig
 PMC405_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405 esd
 
+PMC405DE_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405de esd
+
 PMC440_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc440 esd
 
diff --git a/board/esd/pmc405de/Makefile b/board/esd/pmc405de/Makefile
new file mode 100644
index 0000000..a080649
--- /dev/null
+++ b/board/esd/pmc405de/Makefile
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS-y	= $(BOARD).o
+COBJS-y	+= ../common/cmd_loadpci.o
+COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
+
+COBJS	:= $(COBJS-y)
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(OBJS) $(SOBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/esd/pmc405de/chip_config.c b/board/esd/pmc405de/chip_config.c
new file mode 100644
index 0000000..f1cafc1
--- /dev/null
+++ b/board/esd/pmc405de/chip_config.c
@@ -0,0 +1,47 @@
+/*
+ * (C) Copyright 2008-2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#include <common.h>
+#include <asm/ppc4xx_config.h>
+
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};
+
+int ppc4xx_config_count = ARRAY_SIZE(ppc4xx_config_val);
diff --git a/board/esd/pmc405de/config.mk b/board/esd/pmc405de/config.mk
new file mode 100644
index 0000000..ae855dc
--- /dev/null
+++ b/board/esd/pmc405de/config.mk
@@ -0,0 +1,23 @@
+#
+# (C) Copyright 2000
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+TEXT_BASE = 0xFFFC0000
diff --git a/board/esd/pmc405de/pmc405de.c b/board/esd/pmc405de/pmc405de.c
new file mode 100644
index 0000000..f68e1b5
--- /dev/null
+++ b/board/esd/pmc405de/pmc405de.c
@@ -0,0 +1,521 @@
+/*
+ * (C) Copyright 2009
+ * Matthias Fuchs, esd gmbh germany, matthias.fuchs at esd.eu
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <libfdt.h>
+#include <fdt_support.h>
+#include <asm/processor.h>
+#include <asm/io.h>
+#include <asm/gpio.h>
+#include <asm/4xx_pci.h>
+#include <command.h>
+#include <malloc.h>
+
+/*
+ * PMC405-DE cpld registers
+ * - all registers are 8 bit
+ * - all registers are on 32 bit addesses
+ */
+struct pmc405de_cpld {
+	/* cpld design version */
+	u8 version;
+	u8 reserved0[3];
+
+	/* misc. status lines */
+	u8 status;
+	u8 reserved1[3];
+
+	/*
+	 * gated control flags
+	 * gate bit(s) must be written with '1' to
+	 * access control flag
+	 */
+	u8 control;
+	u8 reserved2[3];
+};
+
+#define CPLD_VERSION_MASK		0x0f
+#define CPLD_CONTROL_POSTLED_N		0x01
+#define CPLD_CONTROL_POSTLED_GATE	0x02
+#define CPLD_CONTROL_RESETOUT_N		0x40
+#define CPLD_CONTROL_RESETOUT_N_GATE	0x80
+
+DECLARE_GLOBAL_DATA_PTR;
+
+extern void __ft_board_setup(void *blob, bd_t *bd);
+extern void pll_write(u32 a, u32 b);
+
+static int wait_for_pci_ready_done;
+
+static int is_monarch(void);
+static int pci_is_66mhz(void);
+static int board_revision(void);
+static int cpld_revision(void);
+static void upd_plb_pci_div(u32 pllmr0, u32 pllmr1, u32 div);
+
+int board_early_init_f(void)
+{
+	u32 pllmr0, pllmr1;
+
+	/*
+	 * check M66EN and patch PLB:PCI divider for 66MHz PCI
+	 *
+	 * fCPU==333MHz && fPCI==66MHz (PLBDiv==3 && M66EN==1): PLB/PCI=1
+	 * fCPU==333MHz && fPCI==33MHz (PLBDiv==3 && M66EN==0): PLB/PCI=2
+	 * fCPU==133|266MHz && fPCI==66MHz (PLBDiv==1|2 && M66EN==1): PLB/PCI=2
+	 * fCPU==133|266MHz && fPCI==33MHz (PLBDiv==1|2 && M66EN==0): PLB/PCI=3
+	 *
+	 * calling upd_plb_pci_div() may end in calling pll_write() which will
+	 * do a chip reset and never return.
+	 */
+	pllmr0 = mfdcr(CPC0_PLLMR0);
+	pllmr1 = mfdcr(CPC0_PLLMR1);
+
+	if ((pllmr0 & PLLMR0_CPU_TO_PLB_MASK) == PLLMR0_CPU_PLB_DIV_3) {
+		/* fCPU=333MHz, fPLB=111MHz */
+		if (pci_is_66mhz())
+			upd_plb_pci_div(pllmr0, pllmr1, PLLMR0_PCI_PLB_DIV_1);
+		else
+			upd_plb_pci_div(pllmr0, pllmr1, PLLMR0_PCI_PLB_DIV_2);
+	} else {
+		/* fCPU=133|266MHz, fPLB=133MHz */
+		if (pci_is_66mhz())
+			upd_plb_pci_div(pllmr0, pllmr1, PLLMR0_PCI_PLB_DIV_2);
+		else
+			upd_plb_pci_div(pllmr0, pllmr1, PLLMR0_PCI_PLB_DIV_3);
+	}
+
+	/*
+	 * IRQ 25 (EXT IRQ 0) PCI-INTA#; active low; level sensitive
+	 * IRQ 26 (EXT IRQ 1) PCI-INTB#; active low; level sensitive
+	 * IRQ 27 (EXT IRQ 2) PCI-INTC#; active low; level sensitive
+	 * IRQ 28 (EXT IRQ 3) PCI-INTD#; active low; level sensitive
+	 * IRQ 29 (EXT IRQ 4) ETH0-PHY-IRQ#; active low; level sensitive
+	 * IRQ 30 (EXT IRQ 5) ETH1-PHY-IRQ#; active low; level sensitive
+	 * IRQ 31 (EXT IRQ 6) PLD-IRQ#; active low; level sensitive
+	 */
+	mtdcr(uicsr, 0xFFFFFFFF);       /* clear all ints */
+	mtdcr(uicer, 0x00000000);       /* disable all ints */
+	mtdcr(uiccr, 0x00000000);       /* set all to be non-critical*/
+	mtdcr(uicpr, 0xFFFFFF80);       /* set int polarities */
+	mtdcr(uictr, 0x10000000);       /* set int trigger levels */
+	mtdcr(uicvcr, 0x00000001);      /* set vect base=0, INT0 highest prio */
+	mtdcr(uicsr, 0xFFFFFFFF);       /* clear all ints */
+
+	/*
+	 * EBC Configuration Register:
+	 * - set ready timeout to 512 ebc-clks -> ca. 15 us
+	 * - EBC lines are always driven
+	 */
+	mtebc(epcr, 0xa8400000);
+
+	return 0;
+}
+
+static void upd_plb_pci_div(u32 pllmr0, u32 pllmr1, u32 div)
+{
+	if ((pllmr0 & PLLMR0_PCI_TO_PLB_MASK) != div)
+		pll_write((pllmr0 & ~PLLMR0_PCI_TO_PLB_MASK) | div, pllmr1);
+}
+
+int misc_init_r(void)
+{
+	int i;
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	struct pmc405de_cpld *cpld =
+		(struct pmc405de_cpld *)CONFIG_SYS_CPLD_BASE;
+
+	if (!is_monarch()) {
+		/* PCI configuration done: release EREADY */
+		setbits_be32(&gpio0->or, CONFIG_SYS_GPIO_EREADY);
+		setbits_be32(&gpio0->tcr, CONFIG_SYS_GPIO_EREADY);
+	}
+
+	/* turn off POST LED */
+	out_8(&cpld->control,
+	      CPLD_CONTROL_POSTLED_N | CPLD_CONTROL_POSTLED_GATE);
+
+	/* turn on LEDs: RUN, A, B */
+	clrbits_be32(&gpio0->or,
+		     CONFIG_SYS_GPIO_LEDRUN_N |
+		     CONFIG_SYS_GPIO_LEDA_N |
+		     CONFIG_SYS_GPIO_LEDB_N);
+
+	for (i=0; i < 200; i++)
+		udelay(1000);
+
+	/* turn off LEDs: A, B */
+	setbits_be32(&gpio0->or,
+		     CONFIG_SYS_GPIO_LEDA_N |
+		     CONFIG_SYS_GPIO_LEDB_N);
+
+	return (0);
+}
+
+static int is_monarch(void)
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	return (in_be32(&gpio0->ir) & CONFIG_SYS_GPIO_MONARCH_N) == 0;
+}
+
+static int pci_is_66mhz(void)
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	return (in_be32(&gpio0->ir) & CONFIG_SYS_GPIO_M66EN);
+}
+
+static int board_revision(void)
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	return ((in_be32(&gpio0->ir) & CONFIG_SYS_GPIO_HWREV_MASK) >>
+		CONFIG_SYS_GPIO_HWREV_SHIFT);
+}
+
+static int cpld_revision(void)
+{
+	struct pmc405de_cpld *cpld =
+		(struct pmc405de_cpld *)CONFIG_SYS_CPLD_BASE;
+	return ((in_8(&cpld->version) & CPLD_VERSION_MASK));
+}
+
+/*
+ * Check Board Identity
+ */
+int checkboard(void)
+{
+	puts("Board: esd GmbH - PMC-CPU/405-DE");
+
+	gd->board_type = board_revision();
+	printf(", Rev 1.%ld, ", gd->board_type);
+
+	if (!is_monarch())
+		puts("non-");
+
+	printf("monarch, PCI=%s MHz, PLD-Rev 1.%d\n",
+	       pci_is_66mhz() ? "66" : "33", cpld_revision());
+
+	return 0;
+}
+
+
+static void wait_for_pci_ready(void)
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	int i;
+	char *s = getenv("pcidelay");
+
+	/* only wait once */
+	if (wait_for_pci_ready_done)
+		return;
+
+	/*
+	 * We have our own handling of the pcidelay variable.
+	 * Using CONFIG_PCI_BOOTDELAY enables pausing for host
+	 * and adapter devices. For adapter devices we do not
+	 * want this.
+	 */
+	if (s) {
+		int ms = simple_strtoul(s, NULL, 10);
+		printf("PCI:   Waiting for %d ms\n", ms);
+		for (i=0; i<ms; i++)
+			udelay(1000);
+	}
+
+	if (!(in_be32(&gpio0->ir) & CONFIG_SYS_GPIO_EREADY)) {
+		printf("PCI:   Waiting for EREADY (CTRL-C to skip) ... ");
+		while (1) {
+			if (ctrlc()) {
+				puts("abort\n");
+				break;
+			}
+			if (in_be32(&gpio0->ir) & CONFIG_SYS_GPIO_EREADY) {
+				printf("done\n");
+				break;
+			}
+		}
+	}
+
+	wait_for_pci_ready_done = 1;
+}
+
+/*
+ * Overwrite weak is_pci_host()
+ *
+ * This routine is called to determine if a pci scan should be
+ * performed. With various hardware environments (especially cPCI and
+ * PPMC) it's insufficient to depend on the state of the arbiter enable
+ * bit in the strap register, or generic host/adapter assumptions.
+ *
+ * Return 0 for adapter mode, non-zero for host (monarch) mode.
+ */
+int is_pci_host(struct pci_controller *hose)
+{
+	char *s;
+
+	if (!is_monarch()) {
+		/*
+		 * Overwrite PCI identification when running in
+		 * non-monarch mode
+		 * This should be moved into pci_target_init()
+		 * when it is sometimes available for 405 CPUs
+		 */
+		pci_write_config_word(PCIDEVID_405GP,
+				      PCI_SUBSYSTEM_ID,
+				      CONFIG_SYS_PCI_SUBSYS_ID_NONMONARCH);
+		pci_write_config_word(PCIDEVID_405GP,
+				      PCI_CLASS_SUB_CODE,
+				      CONFIG_SYS_PCI_CLASSCODE_NONMONARCH);
+	}
+
+	s = getenv("pciscan");
+	if (s == NULL) {
+		if (is_monarch()) {
+			wait_for_pci_ready();
+			return 1;
+		} else {
+			return 0;
+		}
+	} else {
+		if (!strcmp(s, "yes"))
+			return 1;
+	}
+
+	return 0;
+}
+
+/*
+ * Overwrite weak pci_pre_init()
+ *
+ * The default implementation enables the 405EP
+ * internal PCI arbiter. We do not want that
+ * on a PMC module.
+ */
+int pci_pre_init(struct pci_controller *hose)
+{
+	return 1;
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+void ft_board_setup(void *blob, bd_t *bd)
+{
+	int rc;
+
+	__ft_board_setup(blob, bd);
+
+	/*
+	 * Disable PCI in non-monarch mode.
+	 */
+	if (!is_monarch()) {
+		rc = fdt_find_and_setprop(blob, "/plb/pci at ec000000", "status",
+					  "disabled", sizeof("disabled"), 1);
+		if (rc) {
+			printf("Unable to update property status in PCI node, "
+			       "err=%s\n",
+			       fdt_strerror(rc));
+		}
+	}
+}
+#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
+
+#if defined(CONFIG_SYS_EEPROM_WREN)
+/* Input: <dev_addr>  I2C address of EEPROM device to enable.
+ *         <state>     -1: deliver current state
+ *                      0: disable write
+ *                      1: enable write
+ * Returns:            -1: wrong device address
+ *                      0: dis-/en- able done
+ *                    0/1: current state if <state> was -1.
+ */
+int eeprom_write_enable(unsigned dev_addr, int state)
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+
+	if (CONFIG_SYS_I2C_EEPROM_ADDR != dev_addr) {
+		return -1;
+	} else {
+		switch (state) {
+		case 1:
+			/* Enable write access, clear bit GPIO0. */
+			clrbits_be32(&gpio0->or, CONFIG_SYS_GPIO_EEPROM_WP);
+			state = 0;
+			break;
+		case 0:
+			/* Disable write access, set bit GPIO0. */
+			setbits_be32(&gpio0->or, CONFIG_SYS_GPIO_EEPROM_WP);
+			state = 0;
+			break;
+		default:
+			/* Read current status back. */
+			state = (0 == (in_be32(&gpio0->or) &
+				       CONFIG_SYS_GPIO_EEPROM_WP));
+			break;
+		}
+	}
+	return state;
+}
+
+int do_eep_wren(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	int query = argc == 1;
+	int state = 0;
+
+	if (query) {
+		/* Query write access state. */
+		state = eeprom_write_enable(CONFIG_SYS_I2C_EEPROM_ADDR, - 1);
+		if (state < 0) {
+			puts("Query of write access state failed.\n");
+		} else {
+			printf("Write access for device 0x%0x is %sabled.\n",
+				CONFIG_SYS_I2C_EEPROM_ADDR,
+				state ? "en" : "dis");
+			state = 0;
+		}
+	} else {
+		if ('0' == argv[1][0]) {
+			/* Disable write access. */
+			state = eeprom_write_enable(
+				CONFIG_SYS_I2C_EEPROM_ADDR, 0);
+		} else {
+			/* Enable write access. */
+			state = eeprom_write_enable(
+				CONFIG_SYS_I2C_EEPROM_ADDR, 1);
+		}
+		if (state < 0)
+			puts ("Setup of write access state failed.\n");
+	}
+
+	return state;
+}
+
+U_BOOT_CMD(eepwren, 2, 0, do_eep_wren,
+	"Enable / disable / query EEPROM write access",
+	""
+);
+#endif /* #if defined(CONFIG_SYS_EEPROM_WREN) */
+
+#if defined(CONFIG_PRAM)
+#include <environment.h>
+extern env_t *env_ptr;
+
+int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	u32 pram, nextbase, base;
+	char *v;
+	u32 param;
+	ulong *lptr;
+
+	v = getenv("pram");
+	if (v)
+		pram = simple_strtoul(v, NULL, 10);
+	else {
+		printf("Error: pram undefined. Please define pram in KiB\n");
+		return 1;
+	}
+
+	base = gd->bd->bi_memsize;
+#if defined(CONFIG_LOGBUFFER)
+	base -= LOGBUFF_LEN + LOGBUFF_OVERHEAD;
+#endif
+	/*
+	 * gd->bd->bi_memsize == physical ram size - CONFIG_SYS_MM_TOP_HIDE
+	 */
+	param = base - (pram << 10);
+	printf("PARAM: @%08x\n", param);
+	debug("memsize=0x%08x, base=0x%08x\n", gd->bd->bi_memsize, base);
+
+	/* clear entire PA ram */
+	memset((void*)param, 0, (pram << 10));
+
+	/* reserve 4k for pointer field */
+	nextbase = base - 4096;
+	lptr = (ulong*)(base);
+
+	/*
+	 * *(--lptr) = item_size;
+	 * *(--lptr) = base - item_base = distance from field top;
+	 */
+
+	/* env is first (4k aligned) */
+	nextbase -= ((CONFIG_ENV_SIZE + 4096 - 1) & ~(4096 - 1));
+	memcpy((void*)nextbase, env_ptr, CONFIG_ENV_SIZE);
+	*(--lptr) = CONFIG_ENV_SIZE;     /* size */
+	*(--lptr) = base - nextbase;  /* offset | type=0 */
+
+	/* free section */
+	*(--lptr) = nextbase - param; /* size */
+	*(--lptr) = (base - param) | 126; /* offset | type=126 */
+
+	/* terminate pointer field */
+	*(--lptr) = crc32(0, (void*)(base - 0x10), 0x10);
+	*(--lptr) = 0;                /* offset=0 -> terminator */
+	return 0;
+}
+U_BOOT_CMD(
+	painit,	1,	1,	do_painit,
+	"prepare PciAccess system",
+	""
+);
+#endif /* CONFIG_PRAM */
+
+int do_selfreset(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	struct ppc4xx_gpio *gpio0 = (struct ppc4xx_gpio *)GPIO_BASE;
+	setbits_be32(&gpio0->tcr, CONFIG_SYS_GPIO_SELFRST_N);
+	return 0;
+}
+U_BOOT_CMD(
+	selfreset,	1,	1,	do_selfreset,
+	"assert self-reset# signal",
+	""
+);
+
+int do_resetout(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	struct pmc405de_cpld *cpld =
+		(struct pmc405de_cpld *)CONFIG_SYS_CPLD_BASE;
+
+	if (argc > 1) {
+		if (argv[1][0] == '0') {
+			/* assert */
+			printf("PMC-RESETOUT# asserted\n");
+			out_8(&cpld->control,
+			      CPLD_CONTROL_RESETOUT_N_GATE);
+		} else {
+			/* deassert */
+			printf("PMC-RESETOUT# deasserted\n");
+			out_8(&cpld->control,
+			      CPLD_CONTROL_RESETOUT_N |
+			      CPLD_CONTROL_RESETOUT_N_GATE);
+		}
+	} else {
+		printf("PMC-RESETOUT# is %s\n",
+		       (in_8(&cpld->control) & CPLD_CONTROL_RESETOUT_N) ?
+		       "inactive" : "active");
+	}
+	return 0;
+}
+U_BOOT_CMD(
+	resetout,	2,	1,	do_resetout,
+	"assert PMC-RESETOUT# signal",
+	""
+);
diff --git a/board/esd/pmc405de/u-boot.lds b/board/esd/pmc405de/u-boot.lds
new file mode 100644
index 0000000..8c01016
--- /dev/null
+++ b/board/esd/pmc405de/u-boot.lds
@@ -0,0 +1,133 @@
+/*
+ * (C) Copyright 2000
+ * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+OUTPUT_ARCH(powerpc)
+/* Do we need any of these for elf?
+   __DYNAMIC = 0;    */
+SECTIONS
+{
+  .resetvec 0xFFFFFFFC :
+  {
+    *(.resetvec)
+  } = 0xffff
+
+  /* Read-only sections, merged into text segment: */
+  . = + SIZEOF_HEADERS;
+  .interp : { *(.interp) }
+  .hash          : { *(.hash)		}
+  .dynsym        : { *(.dynsym)		}
+  .dynstr        : { *(.dynstr)		}
+  .rel.text      : { *(.rel.text)		}
+  .rela.text     : { *(.rela.text)	}
+  .rel.data      : { *(.rel.data)		}
+  .rela.data     : { *(.rela.data)	}
+  .rel.rodata    : { *(.rel.rodata)	}
+  .rela.rodata   : { *(.rela.rodata)	}
+  .rel.got       : { *(.rel.got)		}
+  .rela.got      : { *(.rela.got)		}
+  .rel.ctors     : { *(.rel.ctors)	}
+  .rela.ctors    : { *(.rela.ctors)	}
+  .rel.dtors     : { *(.rel.dtors)	}
+  .rela.dtors    : { *(.rela.dtors)	}
+  .rel.bss       : { *(.rel.bss)		}
+  .rela.bss      : { *(.rela.bss)		}
+  .rel.plt       : { *(.rel.plt)		}
+  .rela.plt      : { *(.rela.plt)		}
+  .init          : { *(.init)	}
+  .plt : { *(.plt) }
+  .text      :
+  {
+    cpu/ppc4xx/start.o	(.text)
+
+    *(.text)
+    *(.fixup)
+    *(.got1)
+  }
+  _etext = .;
+  PROVIDE (etext = .);
+  .rodata    :
+  {
+    *(.eh_frame)
+    *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
+  }
+  .fini      : { *(.fini)    } =0
+  .ctors     : { *(.ctors)   }
+  .dtors     : { *(.dtors)   }
+
+  /* Read-write section, merged into data segment: */
+  . = (. + 0x00FF) & 0xFFFFFF00;
+  _erotext = .;
+  PROVIDE (erotext = .);
+  .reloc   :
+  {
+    *(.got)
+    _GOT2_TABLE_ = .;
+    *(.got2)
+    _FIXUP_TABLE_ = .;
+    *(.fixup)
+  }
+  __got2_entries = (_FIXUP_TABLE_ - _GOT2_TABLE_) >>2;
+  __fixup_entries = (. - _FIXUP_TABLE_)>>2;
+
+  .data    :
+  {
+    *(.data)
+    *(.data1)
+    *(.sdata)
+    *(.sdata2)
+    *(.dynamic)
+    CONSTRUCTORS
+  }
+  _edata  =  .;
+  PROVIDE (edata = .);
+
+  . = .;
+  __u_boot_cmd_start = .;
+  .u_boot_cmd : { *(.u_boot_cmd) }
+  __u_boot_cmd_end = .;
+
+
+  . = .;
+  __start___ex_table = .;
+  __ex_table : { *(__ex_table) }
+  __stop___ex_table = .;
+
+  . = ALIGN(256);
+  __init_begin = .;
+  .text.init : { *(.text.init) }
+  .data.init : { *(.data.init) }
+  . = ALIGN(256);
+  __init_end = .;
+
+  __bss_start = .;
+  .bss (NOLOAD)       :
+  {
+   *(.sbss) *(.scommon)
+   *(.dynbss)
+   *(.bss)
+   *(COMMON)
+   . = ALIGN(4);
+  }
+  _end = . ;
+  PROVIDE (end = .);
+}
diff --git a/include/configs/PMC405DE.h b/include/configs/PMC405DE.h
new file mode 100644
index 0000000..5232745
--- /dev/null
+++ b/include/configs/PMC405DE.h
@@ -0,0 +1,378 @@
+/*
+ * (C) Copyright 2009
+ * Matthias Fuchs, esd gmbh germany, matthias.fuchs at esd.eu
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CONFIG_405EP		1	/* This is a PPC405 CPU		*/
+#define CONFIG_4xx		1	/* ...member of PPC4xx family	*/
+#define CONFIG_PMC405DE		1	/* ...on a PMC405DE board	*/
+
+#define CONFIG_BOARD_EARLY_INIT_F 1	/* call board_early_init_f()	*/
+#define CONFIG_MISC_INIT_R	1	/* call misc_init_r()		*/
+#define CONFIG_BOARD_TYPES	1	/* support board types		*/
+
+#define CONFIG_SYS_CLK_FREQ	33330000 /* external frequency to pll	*/
+
+#define CONFIG_BAUDRATE		115200
+#define CONFIG_BOOTDELAY	3	/* autoboot after 3 seconds	*/
+
+#undef  CONFIG_BOOTARGS
+#undef  CONFIG_BOOTCOMMAND
+
+#define CONFIG_PREBOOT			/* enable preboot variable	*/
+
+#define CONFIG_SYS_LOADS_BAUD_CHANGE	1	/* allow baudrate change*/
+
+#define CONFIG_NET_MULTI	1
+#define CONFIG_HAS_ETH1
+
+#define CONFIG_PPC4xx_EMAC
+#define CONFIG_MII		1	/* MII PHY management		*/
+#define CONFIG_PHY_ADDR		1	/* PHY address			*/
+#define CONFIG_PHY1_ADDR	2	/* 2nd PHY address		*/
+
+#define CONFIG_SYS_RX_ETH_BUFFER	16 /* use 16 rx buffer on 405 emac */
+
+/*
+ * BOOTP options
+ */
+#define CONFIG_BOOTP_SUBNETMASK
+#define CONFIG_BOOTP_GATEWAY
+#define CONFIG_BOOTP_HOSTNAME
+#define CONFIG_BOOTP_BOOTPATH
+#define CONFIG_BOOTP_DNS
+#define CONFIG_BOOTP_DNS2
+#define CONFIG_BOOTP_SEND_HOSTNAME
+
+/*
+ * Command line configuration.
+ */
+#include <config_cmd_default.h>
+
+#define CONFIG_CMD_BSP
+#define CONFIG_CMD_CHIP_CONFIG
+#define CONFIG_CMD_DATE
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_EEPROM
+#define CONFIG_CMD_ELF
+#define CONFIG_CMD_I2C
+#define CONFIG_CMD_IRQ
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NFS
+#define CONFIG_CMD_PCI
+#define CONFIG_CMD_PING
+
+#define CONFIG_OF_LIBFDT
+#define CONFIG_OF_BOARD_SETUP
+
+#undef  CONFIG_WATCHDOG			/* watchdog disabled */
+#define CONFIG_SDRAM_BANK0	1	/* init onboard SDRAM bank 0 */
+#define CONFIG_PRAM		0
+
+/*
+ * Miscellaneous configurable options
+ */
+#define CONFIG_SYS_LONGHELP
+#define CONFIG_SYS_PROMPT	"=> "	/* Monitor Command Prompt */
+
+#define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_MAXARGS	16		/* max number of command args */
+#define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE /* Boot Args Buffer Size */
+
+#define CONFIG_SYS_DEVICE_NULLDEV	1	/* include nulldev device */
+#define CONFIG_SYS_CONSOLE_INFO_QUIET	1	/* don't print console info */
+
+#define CONFIG_SYS_MEMTEST_START	0x0100000 /* memtest works on */
+#define CONFIG_SYS_MEMTEST_END		0x3000000 /* 1 ... 48 MB in DRAM */
+
+#undef  CONFIG_SYS_EXT_SERIAL_CLOCK
+#define CONFIG_SYS_BASE_BAUD		691200
+#define CONFIG_UART1_CONSOLE
+
+/* The following table includes the supported baudrates */
+#define CONFIG_SYS_BAUDRATE_TABLE	\
+	{ 9600, 19200, 38400, 57600, 115200 }
+
+#define CONFIG_SYS_LOAD_ADDR	0x100000	/* default load address */
+#define CONFIG_SYS_EXTBDINFO	1	/* To use extended board_into (bd_t) */
+
+#define CONFIG_SYS_HZ		1000	/* decrementer freq: 1 ms ticks */
+
+#define CONFIG_CMDLINE_EDITING	1	/* add command line history     */
+#define CONFIG_LOOPW		1	/* enable loopw command         */
+#define CONFIG_MX_CYCLIC	1	/* enable mdc/mwc commands      */
+#define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
+#define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
+
+#define CONFIG_AUTOBOOT_KEYED	1
+#define CONFIG_AUTOBOOT_PROMPT	\
+	"Press SPACE to abort autoboot in %d seconds\n", bootdelay
+#undef CONFIG_AUTOBOOT_DELAY_STR
+#define CONFIG_AUTOBOOT_STOP_STR " "
+
+/*
+ * PCI stuff
+ */
+#define PCI_HOST_ADAPTER	0	/* configure as pci adapter	*/
+#define PCI_HOST_FORCE		1	/* configure as pci host	*/
+#define PCI_HOST_AUTO		2	/* detected via arbiter enable	*/
+
+#define CONFIG_PCI		/* include pci support			*/
+#define CONFIG_PCI_HOST	PCI_HOST_AUTO  /* select pci host function	*/
+#define CONFIG_PCI_PNP		/* do (not) pci plug-and-play		*/
+
+#define CONFIG_PCI_SCAN_SHOW	/* show pci devices on startup		*/
+
+/*
+ * PCI identification
+ */
+#define CONFIG_SYS_PCI_SUBSYS_VENDORID		PCI_VENDOR_ID_ESDGMBH
+#define CONFIG_SYS_PCI_SUBSYS_ID_NONMONARCH 0x040e /* Dev ID: Non-Monarch */
+#define CONFIG_SYS_PCI_SUBSYS_ID_MONARCH 0x040f	/* Dev ID: Monarch */
+#define CONFIG_SYS_PCI_CLASSCODE_NONMONARCH	PCI_CLASS_PROCESSOR_POWERPC
+#define CONFIG_SYS_PCI_CLASSCODE_MONARCH	PCI_CLASS_BRIDGE_HOST
+
+#define CONFIG_SYS_PCI_CLASSCODE CONFIG_SYS_PCI_CLASSCODE_MONARCH
+#define CONFIG_SYS_PCI_SUBSYS_DEVICEID CONFIG_SYS_PCI_SUBSYS_ID_MONARCH
+
+#define CONFIG_SYS_PCI_PTM1LA  0x00000000      /* point to sdram */
+#define CONFIG_SYS_PCI_PTM1MS  0xfc000001      /* 64MB, enable=1 */
+#define CONFIG_SYS_PCI_PTM1PCI 0x00000000      /* Host: use this pci address */
+#define CONFIG_SYS_PCI_PTM2LA  0xef000000      /* point to CPLD, GPIO */
+#define CONFIG_SYS_PCI_PTM2MS  0xff000001      /* 16MB, enable=1 */
+#define CONFIG_SYS_PCI_PTM2PCI 0x04000000      /* Host: use this pci address */
+
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define CONFIG_SYS_BOOTMAPSZ		(8 << 20)
+/*
+ * FLASH organization
+ */
+#define CONFIG_SYS_FLASH_CFI		1	/* CFI compatible */
+#define CONFIG_FLASH_CFI_DRIVER		1	/* Use common CFI driver */
+
+#define CONFIG_SYS_FLASH_BANKS_LIST	{ CONFIG_SYS_FLASH_BASE }
+
+#define CONFIG_SYS_MAX_FLASH_BANKS	1	/* max. no. memory banks */
+#define CONFIG_SYS_MAX_FLASH_SECT	512	/* max sectors per chip */
+
+#define CONFIG_SYS_FLASH_ERASE_TOUT	120000	/* erase timeout (in ms) */
+#define CONFIG_SYS_FLASH_WRITE_TOUT	500	/* write timeout (in ms) */
+
+#define CONFIG_SYS_FLASH_USE_BUFFER_WRITE 1	/* buffered writes (faster) */
+#define CONFIG_SYS_FLASH_PROTECTION	1	/* hardware flash protection */
+
+#define CONFIG_SYS_FLASH_EMPTY_INFO	1 /* 'E' for empty sector (flinfo) */
+#define CONFIG_SYS_FLASH_QUIET_TEST	1 /* don't warn upon unknown flash */
+
+
+/*
+ * Start addresses for the final memory configuration
+ * (Set up by the startup code)
+ * Please note that CONFIG_SYS_SDRAM_BASE _must_ start@0
+ */
+#define CONFIG_SYS_SDRAM_BASE		0x00000000
+#define CONFIG_SYS_FLASH_BASE		0xfe000000
+#define CONFIG_SYS_MONITOR_BASE		TEXT_BASE
+#define CONFIG_SYS_MONITOR_LEN		(~(TEXT_BASE) + 1)
+#define CONFIG_SYS_MALLOC_LEN		(256 * 1024)
+
+/*
+ * Environment in EEPROM setup
+ */
+#define CONFIG_ENV_IS_IN_EEPROM		1
+#define CONFIG_ENV_OFFSET		0x100
+#define CONFIG_ENV_SIZE			0x700
+
+/*
+ * I2C EEPROM (24W16) for environment
+ */
+#define CONFIG_HARD_I2C			/* I2c with hardware support */
+#define CONFIG_SYS_I2C_SPEED		400000 /* I2C speed and slave address */
+#define CONFIG_SYS_I2C_SLAVE		0x7F
+
+#define CONFIG_SYS_I2C_EEPROM_ADDR	0x50	/* EEPROM 24W16	*/
+#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 1	/* Bytes of address */
+/* mask of address bits that overflow into the "EEPROM chip address" */
+#define CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW	0x07
+#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS 4	/* The Catalyst CAT24WC08 has */
+					/* 16 byte page write mode using*/
+					/* last 4 bits of the address */
+#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10 /* and takes up to 10 msec */
+#define CONFIG_SYS_EEPROM_WREN		1
+
+#define CONFIG_4xx_CONFIG_I2C_EEPROM_ADDR	0x50
+#define CONFIG_4xx_CONFIG_I2C_EEPROM_OFFSET	0x40
+#define CONFIG_4xx_CONFIG_BLOCKSIZE		0x20
+
+/*
+ * RTC
+ */
+#define CONFIG_RTC_RX8025
+
+/*
+ * External Bus Controller (EBC) Setup
+ * (max. 55MHZ EBC clock)
+ */
+/* Memory Bank 0 (NOR flash) BAS=0xFE0,BS=32MB,BU=R/W,BW=16bit */
+#define CONFIG_SYS_EBC_PB0AP		0x03017200
+#define CONFIG_SYS_EBC_PB0CR		(CONFIG_SYS_FLASH_BASE | 0xba000)
+
+/* Memory Bank 1 (CPLD) BAS=0xEF0,BS=16MB,BU=R/W,BW=16bit */
+#define CONFIG_SYS_CPLD_BASE		0xef000000
+#define CONFIG_SYS_EBC_PB1AP		0x00800000
+#define CONFIG_SYS_EBC_PB1CR		(CONFIG_SYS_CPLD_BASE | 0x18000)
+
+/*
+ * Definitions for initial stack pointer and data area (in data cache)
+ */
+/* use on chip memory ( OCM ) for temperary stack until sdram is tested */
+#define CONFIG_SYS_TEMP_STACK_OCM	  1
+
+/* On Chip Memory location */
+#define CONFIG_SYS_OCM_DATA_ADDR	0xF8000000
+#define CONFIG_SYS_OCM_DATA_SIZE	0x1000
+/* inside SDRAM */
+#define CONFIG_SYS_INIT_RAM_ADDR	CONFIG_SYS_OCM_DATA_ADDR
+/* End of used area in RAM */
+#define CONFIG_SYS_INIT_RAM_END		CONFIG_SYS_OCM_DATA_SIZE
+
+#define CONFIG_SYS_GBL_DATA_SIZE	128 /* bytes res. for initial data */
+#define CONFIG_SYS_GBL_DATA_OFFSET	(CONFIG_SYS_INIT_RAM_END - \
+					 CONFIG_SYS_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_GBL_DATA_OFFSET
+
+/*
+ * GPIO Configuration
+ */
+#define CONFIG_SYS_4xx_GPIO_TABLE {                  /* GPIO    Alt1       */ \
+{                                                                             \
+/* GPIO Core 0 */                                                             \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO0   PerBLast   */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO1   TS1E       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO2   TS2E       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO3   TS1O       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO4   TS2O       */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_1 },      /* GPIO5   TS3        */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_1 },      /* GPIO6   TS4        */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_1 },      /* GPIO7   TS5        */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO8   TS6        */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_1 },      /* GPIO9   TrcClk     */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO10  PerCS1     */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO11  PerCS2     */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO12  PerCS3     */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO13  PerCS4     */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO14  PerAddr03  */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO15  PerAddr04  */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO16  PerAddr05  */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO17  IRQ0       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO18  IRQ1       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO19  IRQ2       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO20  IRQ3       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO21  IRQ4       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO22  IRQ5       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO23  IRQ6       */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO24  UART0_DCD  */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO25  UART0_DSR  */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO26  UART0_RI   */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO27  UART0_DTR  */ \
+{ GPIO_BASE, GPIO_IN,  GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO28  UART1_Rx   */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_NO_CHG }, /* GPIO29  UART1_Tx   */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO30  RejectPkt0 */ \
+{ GPIO_BASE, GPIO_OUT, GPIO_SEL,  GPIO_OUT_NO_CHG }, /* GPIO31  RejectPkt1 */ \
+}                                                                             \
+}
+
+#define CONFIG_SYS_GPIO_HWREV_MASK	(0xf0000000 >> 1)	/* GPIO1..4 */
+#define CONFIG_SYS_GPIO_HWREV_SHIFT	27
+#define CONFIG_SYS_GPIO_LEDRUN_N	(0x80000000 >> 5)	/* GPIO5 */
+#define CONFIG_SYS_GPIO_LEDA_N		(0x80000000 >> 6)	/* GPIO6 */
+#define CONFIG_SYS_GPIO_LEDB_N		(0x80000000 >> 7)	/* GPIO7 */
+#define CONFIG_SYS_GPIO_SELFRST_N	(0x80000000 >> 8)	/* GPIO8 */
+#define CONFIG_SYS_GPIO_EEPROM_WP	(0x80000000 >> 9)	/* GPIO9 */
+#define CONFIG_SYS_GPIO_MONARCH_N	(0x80000000 >> 11)	/* GPIO11 */
+#define CONFIG_SYS_GPIO_EREADY		(0x80000000 >> 12)	/* GPIO12 */
+#define CONFIG_SYS_GPIO_M66EN		(0x80000000 >> 13)	/* GPIO13 */
+
+/*
+ * Default speed selection (cpu_plb_opb_ebc) in mhz.
+ * This value will be set if iic boot eprom is disabled.
+ */
+#undef CONFIG_SYS_FCPU333MHZ
+#define CONFIG_SYS_FCPU266MHZ
+#undef CONFIG_SYS_FCPU133MHZ
+
+#if defined(CONFIG_SYS_FCPU333MHZ)
+/*
+ * CPU: 333MHz
+ * PLB/SDRAM/MAL: 111MHz
+ * OPB: 55MHz
+ * EBC: 55MHz
+ * PCI: 55MHz (111MHz on M66EN=1)
+ */
+#define PLLMR0_DEFAULT (PLL_CPUDIV_1 | PLL_PLBDIV_3 |		\
+			PLL_OPBDIV_2 | PLL_EXTBUSDIV_2 |	\
+			PLL_MALDIV_1 | PLL_PCIDIV_2)
+#define PLLMR1_DEFAULT (PLL_FBKDIV_10  |			\
+			PLL_FWDDIVA_3 | PLL_FWDDIVB_3 |		\
+			PLL_TUNE_15_M_40 | PLL_TUNE_VCO_HI)
+#endif
+
+#if defined(CONFIG_SYS_FCPU266MHZ)
+/*
+ * CPU: 266MHz
+ * PLB/SDRAM/MAL: 133MHz
+ * OPB: 66MHz
+ * EBC: 44MHz
+ * PCI: 44MHz (66MHz on M66EN=1)
+ */
+#define PLLMR0_DEFAULT (PLL_CPUDIV_1 | PLL_PLBDIV_2 |		\
+			PLL_OPBDIV_2 | PLL_EXTBUSDIV_3 |	\
+			PLL_MALDIV_1 | PLL_PCIDIV_3)
+#define PLLMR1_DEFAULT (PLL_FBKDIV_8  |  \
+			PLL_FWDDIVA_3 | PLL_FWDDIVB_3 |		\
+			PLL_TUNE_15_M_40 | PLL_TUNE_VCO_LOW)
+#endif
+
+#if defined(CONFIG_SYS_FCPU133MHZ)
+/*
+ * CPU: 133MHz
+ * PLB/SDRAM/MAL: 133MHz
+ * OPB: 66MHz
+ * EBC: 44MHz
+ * PCI: 44MHz (66MHz on M66EN=1)
+ */
+#define PLLMR0_DEFAULT (PLL_CPUDIV_1 | PLL_PLBDIV_1 |		\
+			PLL_OPBDIV_2 | PLL_EXTBUSDIV_3 |	\
+			PLL_MALDIV_1 | PLL_PCIDIV_3)
+#define PLLMR1_DEFAULT (PLL_FBKDIV_4  |  \
+			PLL_FWDDIVA_6 | PLL_FWDDIVB_6 |		\
+			PLL_TUNE_15_M_40 | PLL_TUNE_VCO_LOW)
+#endif
+
+#endif /* __CONFIG_H */
-- 
1.6.1

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-21 10:22 [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board Matthias Fuchs
@ 2009-07-22  7:26 ` Wolfgang Denk
  2009-07-22  7:36   ` Stefan Roese
  2009-07-22  8:24   ` Matthias Fuchs
  0 siblings, 2 replies; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22  7:26 UTC (permalink / raw)
  To: u-boot

Dear Matthias Fuchs,

In message <12481717431327-git-send-email-matthias.fuchs@esd.eu> you wrote:
> patch v2:
> 	- coding style cleanup
> 	- added CONFIG_PHY1_ADDR
> patch v3:
> 	- refactor PLL reconfiguration code
> 	- beautify some one-line-functions
> patch v4:
> 	- remove 'sbe' command
> 	- add CONFIG_CMD_CHIP_CONFIG support
> 	- use ppc4xx_gpio struct for GPIO access
> 	- use set/clrbits_be32 to modify GPIO registers
> 	- add CPLD register struct
> patch v5:
> 	- add patch history to commit message

Please get rid of this. This has NO place in the commit message. Such
comments go _below_ the "---" line.

> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
> ---
>  MAINTAINERS                      |    1 +
>  MAKEALL                          |    1 +
>  Makefile                         |    3 +
>  board/esd/pmc405de/Makefile      |   53 ++++
>  board/esd/pmc405de/chip_config.c |   47 ++++
>  board/esd/pmc405de/config.mk     |   23 ++
>  board/esd/pmc405de/pmc405de.c    |  521 ++++++++++++++++++++++++++++++++++++++
>  board/esd/pmc405de/u-boot.lds    |  133 ++++++++++
>  include/configs/PMC405DE.h       |  378 +++++++++++++++++++++++++++
>  9 files changed, 1160 insertions(+), 0 deletions(-)
>  create mode 100644 board/esd/pmc405de/Makefile
>  create mode 100644 board/esd/pmc405de/chip_config.c
>  create mode 100644 board/esd/pmc405de/config.mk
>  create mode 100644 board/esd/pmc405de/pmc405de.c
>  create mode 100644 board/esd/pmc405de/u-boot.lds
>  create mode 100644 include/configs/PMC405DE.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575a7ec..484040c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -171,6 +171,7 @@ Matthias Fuchs <matthias.fuchs@esd-electronics.com>
>  	PCI405		PPC405GP
>  	PLU405		PPC405EP
>  	PMC405		PPC405GP
> +	PMC405DE	PPC405EP
>  	PMC440		PPC440EPx
>  	VOH405		PPC405EP
>  	VOM405		PPC405EP
> diff --git a/MAKEALL b/MAKEALL
> index 020ff73..f36a5fd 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -237,6 +237,7 @@ LIST_4xx="		\
>  	PIP405		\
>  	PLU405		\
>  	PMC405		\
> +	PMC405DE	\
>  	PMC440		\
>  	PPChameleonEVB	\
>  	quad100hd	\
> diff --git a/Makefile b/Makefile
> index 090e645..a5d397b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1492,6 +1492,9 @@ PLU405_config:	unconfig
>  PMC405_config:	unconfig
>  	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405 esd
>  
> +PMC405DE_config:	unconfig
> +	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405de esd
> +
>  PMC440_config:	unconfig
>  	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc440 esd
>  
> diff --git a/board/esd/pmc405de/Makefile b/board/esd/pmc405de/Makefile
> new file mode 100644
> index 0000000..a080649
> --- /dev/null
> +++ b/board/esd/pmc405de/Makefile
> @@ -0,0 +1,53 @@
> +#
> +# (C) Copyright 2000-2006
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(BOARD).a
> +
> +COBJS-y	= $(BOARD).o
> +COBJS-y	+= ../common/cmd_loadpci.o
> +COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
> +
> +COBJS	:= $(COBJS-y)
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(COBJS))
> +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):	$(OBJS) $(SOBJS)
> +	$(AR) $(ARFLAGS) $@ $(OBJS)
> +
> +clean:
> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak $(obj).depend
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/esd/pmc405de/chip_config.c b/board/esd/pmc405de/chip_config.c
> new file mode 100644
> index 0000000..f1cafc1
> --- /dev/null
> +++ b/board/esd/pmc405de/chip_config.c
> @@ -0,0 +1,47 @@
> +/*
> + * (C) Copyright 2008-2009
> + * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + *
> + */
> +
> +#include <common.h>
> +#include <asm/ppc4xx_config.h>
> +
> +struct ppc4xx_config ppc4xx_config_val[] = {
> +
> +	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> +	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> +	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> +};

Indentation by TAB , please.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Whoever undertakes to set himself up as a judge of Truth  and  Know-
ledge is shipwrecked by the laughter of the gods."  - Albert Einstein

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  7:26 ` Wolfgang Denk
@ 2009-07-22  7:36   ` Stefan Roese
  2009-07-22  8:23     ` Matthias Fuchs
  2009-07-22  9:41     ` Wolfgang Denk
  2009-07-22  8:24   ` Matthias Fuchs
  1 sibling, 2 replies; 18+ messages in thread
From: Stefan Roese @ 2009-07-22  7:36 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > +struct ppc4xx_config ppc4xx_config_val[] = {
> > +
> > +	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> > +	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> > +	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > +	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> > +};
>
> Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces 
(< 8 spaces). Example:

	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with 
it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  7:36   ` Stefan Roese
@ 2009-07-22  8:23     ` Matthias Fuchs
  2009-07-22  8:29       ` Stefan Roese
  2009-07-22  9:41     ` Wolfgang Denk
  1 sibling, 1 reply; 18+ messages in thread
From: Matthias Fuchs @ 2009-07-22  8:23 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 09:36, Stefan Roese wrote:
> Hi Wolfgang,
> 
> On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > +
> > > +	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> > > +	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> > > +	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> > > +};
> >
> > Indentation by TAB , please.
> 
> I don't see a problem here. The code is aligned to the lines above via spaces 
> (< 8 spaces). Example:
> 
> 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>             ^^^^
> 
> The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with 
> it.
Yes, I think the identation is correct also. The only think that might be improved
is one empty line that might be too much. And the spaces before and after the curly braces.

These all should not be a reason for stopping this patch. Please let it make it's 
way into Stefan's repo.

Matthias
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  7:26 ` Wolfgang Denk
  2009-07-22  7:36   ` Stefan Roese
@ 2009-07-22  8:24   ` Matthias Fuchs
  2009-07-22  8:36     ` Stefan Roese
  2009-07-22  9:49     ` Wolfgang Denk
  1 sibling, 2 replies; 18+ messages in thread
From: Matthias Fuchs @ 2009-07-22  8:24 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> Dear Matthias Fuchs,
> 
> In message <12481717431327-git-send-email-matthias.fuchs@esd.eu> you wrote:
> > patch v2:
> > 	- coding style cleanup
> > 	- added CONFIG_PHY1_ADDR
> > patch v3:
> > 	- refactor PLL reconfiguration code
> > 	- beautify some one-line-functions
> > patch v4:
> > 	- remove 'sbe' command
> > 	- add CONFIG_CMD_CHIP_CONFIG support
> > 	- use ppc4xx_gpio struct for GPIO access
> > 	- use set/clrbits_be32 to modify GPIO registers
> > 	- add CPLD register struct
> > patch v5:
> > 	- add patch history to commit message
> 
> Please get rid of this. This has NO place in the commit message. Such
> comments go _below_ the "---" line.
Do you want me to resend the posting?

Matthias

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  8:23     ` Matthias Fuchs
@ 2009-07-22  8:29       ` Stefan Roese
  0 siblings, 0 replies; 18+ messages in thread
From: Stefan Roese @ 2009-07-22  8:29 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 10:23:11 Matthias Fuchs wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
> >
> > 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> >             ^^^^
> >
> > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong
> > with it.
>
> Yes, I think the identation is correct also. The only think that might be
> improved is one empty line that might be too much. And the spaces before
> and after the curly braces.

checkpatch will generate a warning if you don't have these spaces around the 
curly braces.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  8:24   ` Matthias Fuchs
@ 2009-07-22  8:36     ` Stefan Roese
  2009-07-22  9:49     ` Wolfgang Denk
  1 sibling, 0 replies; 18+ messages in thread
From: Stefan Roese @ 2009-07-22  8:36 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 10:24:33 Matthias Fuchs wrote:
> On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> > Dear Matthias Fuchs,
> >
> > In message <12481717431327-git-send-email-matthias.fuchs@esd.eu> you 
wrote:
> > > patch v2:
> > > 	- coding style cleanup
> > > 	- added CONFIG_PHY1_ADDR
> > > patch v3:
> > > 	- refactor PLL reconfiguration code
> > > 	- beautify some one-line-functions
> > > patch v4:
> > > 	- remove 'sbe' command
> > > 	- add CONFIG_CMD_CHIP_CONFIG support
> > > 	- use ppc4xx_gpio struct for GPIO access
> > > 	- use set/clrbits_be32 to modify GPIO registers
> > > 	- add CPLD register struct
> > > patch v5:
> > > 	- add patch history to commit message
> >
> > Please get rid of this. This has NO place in the commit message. Such
> > comments go _below_ the "---" line.
>
> Do you want me to resend the posting?

Yes, please.

Thanks.

Viele Gr??e,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  7:36   ` Stefan Roese
  2009-07-22  8:23     ` Matthias Fuchs
@ 2009-07-22  9:41     ` Wolfgang Denk
  2009-07-22  9:47       ` Stefan Roese
  2009-07-22 10:14       ` Matthias Fuchs
  1 sibling, 2 replies; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22  9:41 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <200907220936.55822.sr@denx.de> you wrote:
> Hi Wolfgang,
> 
> On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > +
> > > +	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> > > +	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> > > +	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > +	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> > > +};
> >
> > Indentation by TAB , please.
> 
> I don't see a problem here. The code is aligned to the lines above via spaces 
> (< 8 spaces). Example:

The braces should be indented by TABs.

> 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>             ^^^^
> 
> The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with 
> it.

Indentation is not done by TABs, but by TABs + spaces, and this is
wrong.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating, a totally parochial attitude.
	-- Spock, "Metamorphosis", stardate 3219.8

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  9:41     ` Wolfgang Denk
@ 2009-07-22  9:47       ` Stefan Roese
  2009-07-22 10:34         ` Wolfgang Denk
  2009-07-22 10:14       ` Matthias Fuchs
  1 sibling, 1 reply; 18+ messages in thread
From: Stefan Roese @ 2009-07-22  9:47 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 11:41:45 Wolfgang Denk wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
>
> The braces should be indented by TABs.
>
> > 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> >             ^^^^
> >
> > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong
> > with it.
>
> Indentation is not done by TABs, but by TABs + spaces, and this is
> wrong.

Why should this be wrong? This alignment looks better IMHO. Please allow the 
developers a little bit of freedom.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  8:24   ` Matthias Fuchs
  2009-07-22  8:36     ` Stefan Roese
@ 2009-07-22  9:49     ` Wolfgang Denk
  1 sibling, 0 replies; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22  9:49 UTC (permalink / raw)
  To: u-boot

Dear Matthias Fuchs,

In message <200907221024.33607.matthias.fuchs@esd.eu> you wrote:
> On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> > Dear Matthias Fuchs,
> > 
> > In message <12481717431327-git-send-email-matthias.fuchs@esd.eu> you wrote:
> > > patch v2:
> > > 	- coding style cleanup
> > > 	- added CONFIG_PHY1_ADDR
> > > patch v3:
> > > 	- refactor PLL reconfiguration code
> > > 	- beautify some one-line-functions
> > > patch v4:
> > > 	- remove 'sbe' command
> > > 	- add CONFIG_CMD_CHIP_CONFIG support
> > > 	- use ppc4xx_gpio struct for GPIO access
> > > 	- use set/clrbits_be32 to modify GPIO registers
> > > 	- add CPLD register struct
> > > patch v5:
> > > 	- add patch history to commit message
> > 
> > Please get rid of this. This has NO place in the commit message. Such
> > comments go _below_ the "---" line.
> Do you want me to resend the posting?

Well, such a cmmit message is definitely not  acceptable,  so  please
consider this version rejected.

Please also note that there is still this indentation problem.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  9:41     ` Wolfgang Denk
  2009-07-22  9:47       ` Stefan Roese
@ 2009-07-22 10:14       ` Matthias Fuchs
  2009-07-22 11:05         ` Wolfgang Denk
  1 sibling, 1 reply; 18+ messages in thread
From: Matthias Fuchs @ 2009-07-22 10:14 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang,

On Wednesday 22 July 2009 11:41, Wolfgang Denk wrote:
> Dear Stefan Roese,
> 
> In message <200907220936.55822.sr@denx.de> you wrote:
> > Hi Wolfgang,
> > 
> > On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > > > +struct ppc4xx_config ppc4xx_config_val[] = {
> > > > +
> > > > +	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> > > > +	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> > > > +	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> > > > +	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > > +	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> > > > +};
> > >
> > > Indentation by TAB , please.
> > 
> > I don't see a problem here. The code is aligned to the lines above via spaces 
> > (< 8 spaces). Example:
> 
> The braces should be indented by TABs.
Can you please post a suggestion you you would like to this these
lines indented. When I try to replace the spaces by TABs, the code
looks very ugly and unreadable and I don't like that. 

So perhaps I missed what you mean and I have to reconfigure my emacs 
autoindent mode to wd'mode.

Matthias
> 
> > 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> >             ^^^^
> > 
> > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with 
> > it.
> 
> Indentation is not done by TABs, but by TABs + spaces, and this is
> wrong.
> 
> Best regards,
> 
> Wolfgang Denk
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22  9:47       ` Stefan Roese
@ 2009-07-22 10:34         ` Wolfgang Denk
  2009-07-22 10:57           ` Stefan Roese
  0 siblings, 1 reply; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22 10:34 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <200907221147.25539.sr@denx.de> you wrote:
>
> > Indentation is not done by TABs, but by TABs + spaces, and this is
> > wrong.
> 
> Why should this be wrong? This alignment looks better IMHO. Please allow the 
> developers a little bit of freedom.

"Documentation/CodingStyle":

Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!) 
characters deep, and that is akin to trying to define the value of PI
to be 3.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wish Captain Vimes were here. He wouldn't have  known  what  to  do
either, but he's got a much better vocabulary to be baffled in.
                                 - Terry Pratchett, _Guards! Guards!_

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 10:34         ` Wolfgang Denk
@ 2009-07-22 10:57           ` Stefan Roese
  2009-07-22 11:08             ` Wolfgang Denk
  0 siblings, 1 reply; 18+ messages in thread
From: Stefan Roese @ 2009-07-22 10:57 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 12:34:44 Wolfgang Denk wrote:
> > > Indentation is not done by TABs, but by TABs + spaces, and this is
> > > wrong.
> >
> > Why should this be wrong? This alignment looks better IMHO. Please allow
> > the developers a little bit of freedom.
>
> "Documentation/CodingStyle":
>
> Tabs are 8 characters, and thus indentations are also 8 characters.
> There are heretic movements that try to make indentations 4 (or even 2!)
> characters deep, and that is akin to trying to define the value of PI
> to be 3.

Fuck Ack. But: This has nothing to do with the problem we are discussing here. 
I was talking about alignment and not indentation. Do you want to forbid 
people use alignment at all?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 10:14       ` Matthias Fuchs
@ 2009-07-22 11:05         ` Wolfgang Denk
  2009-07-22 11:12           ` Stefan Roese
  0 siblings, 1 reply; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22 11:05 UTC (permalink / raw)
  To: u-boot

Dear Matthias Fuchs,

In message <200907221214.25935.matthias.fuchs@esd.eu> you wrote:
> 
> > The braces should be indented by TABs.
> Can you please post a suggestion you you would like to this these
> lines indented. When I try to replace the spaces by TABs, the code
> looks very ugly and unreadable and I don't like that. 

So you want me to do the editing for you? May I send my invoice to
esd's address?

> So perhaps I missed what you mean and I have to reconfigure my emacs 
> autoindent mode to wd'mode.

I don't understand what's so difficult about it; just indent by TABs:

struct ppc4xx_config ppc4xx_config_val[] = {
	{
		"133",
		"CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"266",
		"CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"333",
		"CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00,
		}
	},
};


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 10:57           ` Stefan Roese
@ 2009-07-22 11:08             ` Wolfgang Denk
  2009-07-22 11:22               ` Stefan Roese
  0 siblings, 1 reply; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22 11:08 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <200907221257.30824.sr@denx.de> you wrote:
>
> Fuck Ack. But: This has nothing to do with the problem we are discussing here. 
> I was talking about alignment and not indentation. Do you want to forbid 
> people use alignment at all?

Please do me (and yourself, and us all) a favour and just read the
rules, and then follow them, instead of wasting our all time.

See http://www.denx.de/wiki/U-Boot/CodingStyle:

	Use TAB characters for indentation and vertical alignment, not
	spaces.

Anything else?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As of 1992, they're called European Economic Community fries.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 11:05         ` Wolfgang Denk
@ 2009-07-22 11:12           ` Stefan Roese
  2009-07-22 11:15             ` Wolfgang Denk
  0 siblings, 1 reply; 18+ messages in thread
From: Stefan Roese @ 2009-07-22 11:12 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 13:05:56 Wolfgang Denk wrote:
> I don't understand what's so difficult about it; just indent by TABs:
>
> struct ppc4xx_config ppc4xx_config_val[] = {
> 	{
> 		"133",
> 		"CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> 		{
> 			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 			0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
> 		}
> 	},

OK, now let's compare your version with ours:

> +     { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> +       { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +         0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },

Your version is 10 lines long, ours is 5. That twice as long. I still prefer 
our version and think this kind of personal freedom should be allowed.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 11:12           ` Stefan Roese
@ 2009-07-22 11:15             ` Wolfgang Denk
  0 siblings, 0 replies; 18+ messages in thread
From: Wolfgang Denk @ 2009-07-22 11:15 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <200907221312.17644.sr@denx.de> you wrote:
>
> Your version is 10 lines long, ours is 5. That twice as long. I still prefer 
> our version and think this kind of personal freedom should be allowed.

Nobody attempts to restrict yoru thoughts or preferences.

But you want to have the patch accepted, and I want you to stick with
the CodingStyle. That's all. Full stop.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
  2009-07-22 11:08             ` Wolfgang Denk
@ 2009-07-22 11:22               ` Stefan Roese
  0 siblings, 0 replies; 18+ messages in thread
From: Stefan Roese @ 2009-07-22 11:22 UTC (permalink / raw)
  To: u-boot

On Wednesday 22 July 2009 13:08:30 Wolfgang Denk wrote:
> Please do me (and yourself, and us all) a favour and just read the
> rules, and then follow them, instead of wasting our all time.

I'm pretty sure that I'm doing at least some developers a favour, in 
discussing this issue. It's annoying not being able to use a coding style 
that's accepted for example in the Linux kernel all the time.

But ok, I'm stopping here as well.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2009-07-22 11:22 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21 10:22 [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board Matthias Fuchs
2009-07-22  7:26 ` Wolfgang Denk
2009-07-22  7:36   ` Stefan Roese
2009-07-22  8:23     ` Matthias Fuchs
2009-07-22  8:29       ` Stefan Roese
2009-07-22  9:41     ` Wolfgang Denk
2009-07-22  9:47       ` Stefan Roese
2009-07-22 10:34         ` Wolfgang Denk
2009-07-22 10:57           ` Stefan Roese
2009-07-22 11:08             ` Wolfgang Denk
2009-07-22 11:22               ` Stefan Roese
2009-07-22 10:14       ` Matthias Fuchs
2009-07-22 11:05         ` Wolfgang Denk
2009-07-22 11:12           ` Stefan Roese
2009-07-22 11:15             ` Wolfgang Denk
2009-07-22  8:24   ` Matthias Fuchs
2009-07-22  8:36     ` Stefan Roese
2009-07-22  9:49     ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox