public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Wegner <wolfgang@leila.ping.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix
Date: Wed, 22 Jul 2009 11:41:27 +0200	[thread overview]
Message-ID: <20090722094127.GV20598@leila.ping.de> (raw)
In-Reply-To: <4A6602C3.2050007@psyent.com>

Dear Scott, Wolfgang,

On Tue, Jul 21, 2009 at 02:02:43PM -0400, Scott McNutt wrote:
> ... for a two line bug fix?
> 
> This is hardly a valid reason to claim copyright on the module.
> 
> This practice will only discourage the contribution of original work
> to the project. Nobody wants to have their work hijacked in such a
> manner.

So you really think your practice will encourage anybody to submit a
clean patch for a bug he spent days (or weeks) to find?

I found it very difficult to supply a clean patch for some of the
fixes or improvements I did for my private coldfire tree. For few
of them, I sent bug reports with the part to fix - but I am not even
sure if they finally got picked up by the maintainer.

On the one hand, you want patches to be tested (which is a good thing,
of course), on the other hand I can not test a patch without other
things changed for my board (which is not really useful for inclusion
in the official tree, I think). Keeping several trees up-to-date to
test the patches out of the vanilla tree and then rolling them back into
the vanilly tree is at least beyond my time scale (and, to be honest,
sometimes my knowledge of git, which is not self-explanatory at all).

I can understand the maintainers have not that much time, I can also
understand that the original work has to get its due credit - but then
those sending patches should get their credit, too, or else the maintainer
has to do the work of integrating the fix himself.

Just my 2C, of course...

Regards,
Wolfgang

  parent reply	other threads:[~2009-07-22  9:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 12:21 [U-Boot] PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix Renato Andreola
2009-07-17 22:13 ` Wolfgang Denk
2009-07-21 18:02 ` [U-Boot] Rejected: " Scott McNutt
2009-07-22  8:01   ` Renato Andreola
2009-07-22  9:43     ` Wolfgang Denk
2009-07-22  9:41   ` Wolfgang Wegner [this message]
2009-07-22 10:56     ` Wolfgang Denk
2009-07-22 10:33       ` Wolfgang Wegner
2009-07-22 14:54         ` Wolfgang Denk
2009-07-23  1:41     ` Scott McNutt
2009-11-22 20:12 ` [U-Boot] " Wolfgang Denk
2009-11-23 21:52   ` Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090722094127.GV20598@leila.ping.de \
    --to=wolfgang@leila.ping.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox