[U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board

Stefan Roese
2009-07-22T07:36:55Z

Hi Wolfgang,

On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
> > +struct ppc4xx_config ppc4xx_config_val[] = {
> > +
> > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> > + { "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> > + { "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> > +};
>
> Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces
(< 8 spaces). Example:

{ 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with
it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
=====================================================================