[U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board

Stefan Roese
2009-07-22T08:29:20Z

On Wednesday 22 July 2009 10:23:11 Matthias Fuchs wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
> >
> > { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > ^^^^
> >
> > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong
> > with it.
>
> Yes, I think the identation is correct also. The only think that might be
> improved is one empty line that might be too much. And the spaces before
> and after the curly braces.

checkpatch will generate a warning if you don't have these spaces around the
curly braces.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================