[U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board

Wolfgang Denk
2009-07-22T07:26:09Z

Dear Matthias Fuchs,

In message <12481717431327-git-send-email-matthias.fuchs@esd.eu> you wrote:
> patch v2:
> - coding style cleanup
> - added CONFIG_PHY1_ADDR
> patch v3:
> - refactor PLL reconfiguration code
> - beautify some one-line-functions
> patch v4:
> - remove 'sbe' command
> - add CONFIG_CMD_CHIP_CONFIG support
> - use ppc4xx_gpio struct for GPIO access
> - use set/clrbits_be32 to modify GPIO registers
> - add CPLD register struct
> patch v5:
> - add patch history to commit message

Please get rid of this. This has NO place in the commit message. Such
comments go _below_ the "---" line.

> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
> ---
> MAINTAINERS | 1 +
> MAKEALL | 1 +
> Makefile | 3 +
> board/esd/pmc405de/Makefile | 53 ++++
> board/esd/pmc405de/chip_config.c | 47 ++++
> board/esd/pmc405de/config.mk | 23 ++
> board/esd/pmc405de/pmc405de.c | 521 ++++++++++++++++++++++++++++++++++++++
> board/esd/pmc405de/u-boot.lds | 133 ++++++++++
> include/configs/PMC405DE.h | 378 +++++++++++++++++++++++++++
> 9 files changed, 1160 insertions(+), 0 deletions(-)
> create mode 100644 board/esd/pmc405de/Makefile
> create mode 100644 board/esd/pmc405de/chip_config.c
> create mode 100644 board/esd/pmc405de/config.mk
> create mode 100644 board/esd/pmc405de/pmc405de.c
> create mode 100644 board/esd/pmc405de/u-boot.lds
> create mode 100644 include/configs/PMC405DE.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575a7ec..484040c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -171,6 +171,7 @@ Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> PCI405 PPC405GP
> PLU405 PPC405EP
> PMC405 PPC405GP
> + PMC405DE PPC405EP
> PMC440 PPC440EPx
> VOH405 PPC405EP
> VOM405 PPC405EP
> diff --git a/MAKEALL b/MAKEALL
> index 020ff73..f36a5fd 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -237,6 +237,7 @@ LIST_4xx=" \
> PIP405 \
> PLU405 \
> PMC405 \
> + PMC405DE \
> PMC440 \
> PPChameleonEVB \
> quad100hd \
> diff --git a/Makefile b/Makefile
> index 090e645..a5d397b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1492,6 +1492,9 @@ PLU405_config: unconfig
> PMC405_config: unconfig
> @$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405 esd
>
> +PMC405DE_config: unconfig
> + @$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405de esd
> +
> PMC440_config: unconfig
> @$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc440 esd
>
> diff --git a/board/esd/pmc405de/Makefile b/board/esd/pmc405de/Makefile
> new file mode 100644
> index 0000000..a080649
> --- /dev/null
> +++ b/board/esd/pmc405de/Makefile
> @@ -0,0 +1,53 @@
> +#
> +# (C) Copyright 2000-2006
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB = $(obj)lib$(BOARD).a
> +
> +COBJS-y = $(BOARD).o
> +COBJS-y += ../common/cmd_loadpci.o
> +COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
> +
> +COBJS := $(COBJS-y)
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
> +SOBJS := $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB): $(OBJS) $(SOBJS)
> + $(AR) $(ARFLAGS) $@ $(OBJS)
> +
> +clean:
> + rm -f $(SOBJS) $(OBJS)
> +
> +distclean: clean
> + rm -f $(LIB) core *.bak $(obj).depend
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/esd/pmc405de/chip_config.c b/board/esd/pmc405de/chip_config.c
> new file mode 100644
> index 0000000..f1cafc1
> --- /dev/null
> +++ b/board/esd/pmc405de/chip_config.c
> @@ -0,0 +1,47 @@
> +/*
> + * (C) Copyright 2008-2009
> + * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + *
> + */
> +
> +#include <common.h>
> +#include <asm/ppc4xx_config.h>
> +
> +struct ppc4xx_config ppc4xx_config_val[] = {
> +
> + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
> + { "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
> + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
> + { "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
> + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
> +};

Indentation by TAB , please.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Whoever undertakes to set himself up as a judge of Truth and Know-
ledge is shipwrecked by the laughter of the gods." - Albert Einstein