From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 22 Jul 2009 11:47:25 +0200
Subject: [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board
In-Reply-To: <20090722094145.A7745832E416@gemini.denx.de>
References: <12481717431327-git-send-email-matthias.fuchs@esd.eu>
	<200907220936.55822.sr@denx.de>
	<20090722094145.A7745832E416@gemini.denx.de>
Message-ID: <200907221147.25539.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 22 July 2009 11:41:45 Wolfgang Denk wrote:
> > > Indentation by TAB , please.
> >
> > I don't see a problem here. The code is aligned to the lines above via
> > spaces (< 8 spaces). Example:
>
> The braces should be indented by TABs.
>
> > 	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > 	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> >             ^^^^
> >
> > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong
> > with it.
>
> Indentation is not done by TABs, but by TABs + spaces, and this is
> wrong.

Why should this be wrong? This alignment looks better IMHO. Please allow the 
developers a little bit of freedom.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================